The committers listed above are authorized under a signed CLA.

• ✅ login: erdii / name: Josh Gwosdz (7a24c4c)

Welcome @erdii!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

Hi @erdii. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

/sig api-machinery

/approve cancel

/approve

can try targeted approval again on the next dep update

/approve
/lgtm-cancel
[cancelling lgtm until unwanted-dependencies.json is updated to prevent pointless retesting]

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/131444/pull-kubernetes-dependencies/1915590712347332608

@erdii please add this to the yaml.v3 list in hack/unwanted-dependencies.json:

  	      "github.com/google/cadvisor",
+ 	      "github.com/google/cel-go",
  	      "github.com/google/gnostic-models",

targeted approval worked!

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

• The PR does have any do-not-merge/* labels
• The PR does not have the needs-ok-to-test label
• The PR is mergeable (does not have a needs-rebase label)
• The PR is approved (has cncf-cla: yes, lgtm, approved labels)
• The PR is failing tests required for merge

You can:

• Review the full test history for this PR
• Prevent this bot from retesting with /lgtm cancel or /hold
• Help make our tests less flaky by following our Flaky Tests Guide

/retest

/lgtm cancel
for the #131444 (comment)

We tightly control rollouts of changes in accepted syntax and additional library functions usable in cel expressions from within kubernetes (otherwise the previous version of kube-apiserver can consider persisted CEL expressions invalid).

For the PR author, unless we take action to opt into the newer versions of the libraries, I don't think the quoted fields or first/last accessors you mentioned will be automatically available as a result of this bump

Understood! What would need to be done to make newer libraries available?

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, erdii, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

I've updated hack/unwanted-dependencies.json as requested.

/lgtm

LGTM label has been added.