Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[SFN] Set SFN V2 provider as default #8779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 7, 2023
Merged

[SFN] Set SFN V2 provider as default #8779

merged 7 commits into from
Nov 7, 2023

Conversation

MEPalma
Copy link
Contributor

@MEPalma MEPalma commented Jul 31, 2023 •
edited
Loading

This PR

This is a playground PR to experiment using SFN V2 provider as default provider for Step Functions.

API Actions

Action Supported Notes
CreateActivity ✗ Activities are unsupported
CreateStateMachine ✓ No parity in error messages of InvalidDefinition errors
CreateStateMachineAlias ✗
DeleteActivity ✗
DeleteStateMachine ✓
DeleteStateMachineAlias ✗ Aliasing is unsupported
DeleteStateMachineVersion ✓
DescribeActivity ✗
DescribeExecution ✓
DescribeMapRun ✓
DescribeStateMachine ✓
DescribeStateMachineAlias ✗
DescribeStateMachineForExecution ✓
GetActivityTask ✗
GetExecutionHistory ✓
ListActivities ✗
ListExecutions ✓
ListMapRuns ✓
ListStateMachineAliases ✗
ListStateMachines ✓
ListStateMachineVersions ✓
ListTagsForResource ✓
PublishStateMachineVersion ✓
SendTaskFailure ✓
SendTaskHeartbeat ✓
SendTaskSuccess ✓
StartExecution ✓
StartSyncExecution ✗
StopExecution ✓
TagResource ✓
UntagResource ✓
UpdateMapRun ✗
UpdateStateMachine ✓
UpdateStateMachineAlias ✗

Optimised Integrations

Service Supported sync sync:2 waitForTaskToken Notes
Lambda ✓ ✓
AWS Batch ✗
DynamoDB ✓ ✓
Amazon ECS/AWS Fargate ✗
Amazon SNS ✓ ✓
Amazon SQS ✓ ✓
AWS Glue ✗
SageMaker ✗
Amazon EMR ✗
Amazon EMR on EKS ✗
CodeBuild ✗
Athena ✗
Amazon EKS ✗
API Gateway ✓ ✓
AWS Glue DataBrew ✗
Amazon EventBridge ✓ ✓
AWS Step Functions ✓ ✓ ✓ ✓
AWS SDK integrations ✓ ✓

Language Features

Feature Name Notes
COMMENT
STATES
STARTAT
NEXT
END
INPUTPATH
OUTPUTPATH
ITEMSPATH
RESULTPATH
RESULT
PARAMETERS
TYPE
TASK
CHOICE
FAIL
SUCCEED
PASS
WAIT
PARALLEL
MAP
CHOICES
VARIABLE
DEFAULT
BRANCHES
SECONDSPATH
SECONDS
TIMESTAMPPATH
TIMESTAMP
TIMEOUTSECONDS
TIMEOUTSECONDSPATH
HEARTBEATSECONDS
HEARTBEATSECONDSPATH
ITEMPROCESSOR
ITEMSELECTOR
PROCESSORCONFIG
MODE
INLINE
MAXCONCURRENCY
ITERATOR
CAUSE
ERROR
CATCH
RETRY
ERROREQUALS
INTERVALSECONDS Parsed but has no effect
MAXATTEMPTS
BACKOFFRATE Parsed but has no effect
StatesALL
StatesHeartbeatTimeout
StatesTimeout
StatesTaskFailed
StatesPermissions
StatesResultPathMatchFailure
StatesParameterPathFailure
StatesBranchFailed
StatesNoChoiceMatched
StatesIntrinsicFailure
StatesExceedToleratedFailureThreshold
StatesItemReaderFailed
StatesResultWriterFailed

Choice Operators

Operator Notes
AND
BOOLEANEQUALS
BOOLEANQUALSPATH
ISBOOLEAN
ISNULL
ISNUMERIC
ISPRESENT
ISSTRING
ISTIMESTAMP
NOT
NUMERICEQUALS
NUMERICEQUALSPATH
NUMERICGREATERTHAN
NUMERICGREATERTHANPATH
NUMERICGREATERTHANEQUALS
NUMERICGREATERTHANEQUALSPATH
NUMERICLESSTHAN
NUMERICLESSTHANPATH
NUMERICLESSTHANEQUALS
NUMERICLESSTHANEQUALSPATH
OR
STRINGEQUALS
STRINGEQUALSPATH
STRINGGREATERTHAN
STRINGGREATERTHANPATH
STRINGGREATERTHANEQUALS
STRINGGREATERTHANEQUALSPATH
STRINGLESSTHAN
STRINGLESSTHANPATH
STRINGLESSTHANEQUALS
STRINGLESSTHANEQUALSPATH
STRINGMATCHES
TIMESTAMPEQUALS
TIMESTAMPEQUALSPATH
TIMESTAMPGREATERTHAN
TIMESTAMPGREATERTHANPATH
TIMESTAMPGREATERTHANEQUALS
TIMESTAMPGREATERTHANEQUALSPATH
TIMESTAMPLESSTHAN
TIMESTAMPLESSTHANPATH
TIMESTAMPLESSTHANEQUALS
TIMESTAMPLESSTHANEQUALSPATH

Intrinsic Functions:

Expression Notes
Format
StringToJson
JsonToString
Array
ArrayPartition
ArrayContains
ArrayRange
ArrayGetItem
ArrayLength
ArrayUnique
Base64Encode
Base64Decode
Hash
JsonMerge
MathRandom
MathAdd
StringSplit
UUID

@MEPalma MEPalma added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Jul 31, 2023
@MEPalma MEPalma added this to the Playground milestone Jul 31, 2023
@MEPalma MEPalma requested a review from dominikschubert July 31, 2023 12:50
@MEPalma MEPalma self-assigned this Jul 31, 2023
@github-actions
Copy link

github-actions bot commented Aug 6, 2023 •
edited
Loading

LocalStack Community integration with Pro

       2 files  ±0         2 suites  ±0   1h 18m 58s ⏱️ + 19m 31s
2 302 tests ±0  2 006 ✔️ +221  296 💤  - 221  0 ❌ ±0 
2 303 runs  ±0  2 006 ✔️ +221  297 💤  - 221  0 ❌ ±0 

Results for commit ff7d139. ± Comparison against base commit dffe61f.

♻️ This comment has been updated with latest results.

This was referenced Aug 7, 2023
Closed
Closed
Closed
Closed
Merged
Merged
This was referenced Aug 20, 2023
Merged
Closed
@BrianMcBrayer BrianMcBrayer mentioned this pull request Aug 21, 2023
Closed
1 task
@MEPalma MEPalma mentioned this pull request Aug 29, 2023
Merged
@coveralls
Copy link

coveralls commented Aug 29, 2023 •
edited
Loading

Coverage Status

coverage: 84.068% (-0.2%) from 84.224%
when pulling ff7d139 on MEP-sfn-v2-default
into dffe61f on release/v3.0.

@MEPalma MEPalma mentioned this pull request Aug 30, 2023
Closed
1 task
@MEPalma MEPalma modified the milestones: Playground, 3.0 Sep 4, 2023
@MEPalma MEPalma marked this pull request as ready for review October 31, 2023 12:45
pinzon
pinzon approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

alexrashed
alexrashed requested changes Nov 1, 2023
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is looking good! I setting a "Request changes" until the PR targets the release branch (to make sure this isn't accidentially merged into master).

@alexrashed alexrashed added semver: major Breaking changes which can be included in a major release only and removed semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases labels Nov 1, 2023
@MEPalma MEPalma changed the base branch from master to release/v3.0 November 1, 2023 14:41
@alexrashed alexrashed force-pushed the release/v3.0 branch 4 times, most recently from 19c8422 to 6ff5c4c Compare November 2, 2023 09:24
@alexrashed alexrashed force-pushed the release/v3.0 branch 2 times, most recently from fb5da7d to 99278b3 Compare November 4, 2023 13:46
@alexrashed alexrashed mentioned this pull request Nov 7, 2023
Merged
20 tasks
dominikschubert and others added 3 commits November 7, 2023 09:58
@dominikschubert @MEPalma
adapt tests for stepfunctions v2 as default
7d60470 
---------

Co-authored-by: MEPalma <[email protected]>
@dominikschubert @MEPalma
set sfn v2 provider as default
5168f60 
---------

Co-authored-by: MEPalma <[email protected]>
@dominikschubert @MEPalma
fix circleci config
9b74177 
---------

Co-authored-by: MEPalma <[email protected]>
@localstack localstack deleted a comment from localstack-bot Nov 7, 2023
alexrashed
alexrashed approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This PR is now targeting the release branch, and I took another look:
The changes are looking great! I only added a comment concerning the provider alias (maybe we should keep them, but add the env to the list of deprecations).

@dominikschubert
Copy link
Member

I've also moved the old provider intro a legacy package and renamed the two provider files accordingly.
provider.py was previously the v1 provider and now houses the new v2 provider.

@dominikschubert dominikschubert merged commit 2c674ce into release/v3.0 Nov 7, 2023
@dominikschubert dominikschubert deleted the MEP-sfn-v2-default branch November 7, 2023 16:27
alexrashed pushed a commit that referenced this pull request Nov 7, 2023
@MEPalma @dominikschubert @alexrashed
Set StepFunctions v2 provider as the default provider (#8779)
4461987 
Co-authored-by: Dominik Schubert <[email protected]>
localstack-bot pushed a commit that referenced this pull request Nov 9, 2023
@MEPalma @dominikschubert
Set StepFunctions v2 provider as the default provider (#8779)
6448656 
Co-authored-by: Dominik Schubert <[email protected]>
alexrashed pushed a commit that referenced this pull request Nov 9, 2023
@MEPalma @dominikschubert @alexrashed
Set StepFunctions v2 provider as the default provider (#8779)
5b29bdd 
Co-authored-by: Dominik Schubert <[email protected]>
alexrashed pushed a commit that referenced this pull request Nov 9, 2023
@MEPalma @dominikschubert @alexrashed
Set StepFunctions v2 provider as the default provider (#8779)
75105c1 
Co-authored-by: Dominik Schubert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed alexrashed approved these changes

@pinzon pinzon pinzon approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

Assignees

@MEPalma MEPalma

Labels
semver: major Breaking changes which can be included in a major release only
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@MEPalma @coveralls @dominikschubert @alexrashed @pinzon