BUG: __getattr__ must raise AttributeError if name not found #20822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR matplotlib#20733 added module-level `__getattr__` functions to several modules. All of the functions with the exception of the one in `matplotlib.style.core` had a terminal `raise AttributeError` to handle unmatched attributes. The omission in `matplotlib.style.core` was probably unintentional; it results in confusing and buggy behavior such as: ```pycon >>> import matplotlib.style.core >>> if hasattr(matplotlib.style.core, '__warningregistry__'): ... del matplotlib.style.core.__warningregistry__ ... Traceback (most recent call last): File "<stdin>", line 2, in <module> AttributeError: __warningregistry__ ``` This causes problems in the unit tests for astropy affiliated packages. See astropy/astropy#12038.
9 tasks
QuLogic
approved these changes
Aug 10, 2021
jklymak
approved these changes
Aug 10, 2021
lpsinger
added a commit
to lpsinger/matplotlib
that referenced
this pull request
Aug 18, 2021
PR matplotlib#20806 added another instance of a module-level `__getattr__` function that was missing a final `raise AttributeError` to catch unknown attributes. This is the same kind of bug as matplotlib#20822. See also astropy/astropy#12038.
7 tasks
lpsinger
added a commit
to lpsinger/matplotlib
that referenced
this pull request
Aug 18, 2021
lpsinger
added a commit
to lpsinger/matplotlib
that referenced
this pull request
Aug 18, 2021
7 tasks
lpsinger
added a commit
to lpsinger/matplotlib
that referenced
this pull request
Aug 18, 2021
lpsinger
added a commit
to lpsinger/matplotlib
that referenced
this pull request
Aug 18, 2021
7 tasks
lpsinger
added a commit
to lpsinger/matplotlib
that referenced
this pull request
Aug 18, 2021
lpsinger
added a commit
to lpsinger/matplotlib
that referenced
this pull request
Aug 19, 2021
tacaswell
pushed a commit
to anntzer/matplotlib
that referenced
this pull request
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR #20733 added module-level
__getattr__functions to several modules. All of the functions with the exception of the one inmatplotlib.style.corehad a terminalraise AttributeErrorto handle unmatched attributes.The omission in
matplotlib.style.corewas probably unintentional; it results in confusing and buggy behavior such as:This causes problems in the unit tests for astropy affiliated packages. See astropy/astropy#12038.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).