Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Replaced list with tuple in pyplot for axes #26521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

EngineerKhan
Copy link
Contributor

PR summary

PR checklist

@@ -1134,7 +1134,7 @@ def figlegend(*args, **kwargs) -> Legend:

@_docstring.dedent_interpd
def axes(
arg: None | tuple[float, float, float, float] = None,
arg: None | tuple(float, float, float, float) = None,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need to be square brackets, that is type hinting syntax, which does not change because it's a tuple

Copy link
Member

@timhoffm timhoffm Aug 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty of reverting this via an additional commit in the GitHub UI. @devs Please squash-merge.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@rcomer rcomer linked an issue Aug 14, 2023 that may be closed by this pull request
@timhoffm timhoffm marked this pull request as ready for review August 30, 2023 20:13
@timhoffm timhoffm dismissed ksunden’s stale review August 30, 2023 20:14

type hint changes are reverted

@timhoffm timhoffm added this to the v3.8.0 milestone Aug 30, 2023
@timhoffm timhoffm merged commit 80fb37d into matplotlib:main Aug 30, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Aug 30, 2023
@timhoffm
Copy link
Member

Thanks @EngineerKhan!

ksunden added a commit that referenced this pull request Aug 31, 2023
…521-on-v3.8.x

Backport PR #26521 on branch v3.8.x (Replaced list with tuple in pyplot for axes)
@ksunden ksunden mentioned this pull request Sep 15, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[Doc]: Pyplot Axes – tuple or list?
3 participants