-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Replaced list with tuple in pyplot for axes #26521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lib/matplotlib/pyplot.py
Outdated
@@ -1134,7 +1134,7 @@ def figlegend(*args, **kwargs) -> Legend: | |||
|
|||
@_docstring.dedent_interpd | |||
def axes( | |||
arg: None | tuple[float, float, float, float] = None, | |||
arg: None | tuple(float, float, float, float) = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These need to be square brackets, that is type hinting syntax, which does not change because it's a tuple
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty of reverting this via an additional commit in the GitHub UI. @devs Please squash-merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
Thanks @EngineerKhan! |
…521-on-v3.8.x Backport PR #26521 on branch v3.8.x (Replaced list with tuple in pyplot for axes)
PR summary
PR checklist