Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Ensure local host only if connection not available #10600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2020

Conversation

karthiknadig
Copy link
Member

For #10597

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.

This is currently breaking multi-proc in insiders. This feature is not shipped yet, so stable is fine.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

codecov-io commented Mar 16, 2020

Codecov Report

Merging #10600 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10600      +/-   ##
==========================================
- Coverage   60.79%   60.77%   -0.02%     
==========================================
  Files         579      579              
  Lines       31412    31412              
  Branches     4469     4469              
==========================================
- Hits        19097    19091       -6     
- Misses      11344    11348       +4     
- Partials      971      973       +2     
Impacted Files Coverage Δ
src/client/debugger/types.ts 100.00% <ø> (ø)
...bugger/extension/configuration/resolvers/attach.ts 81.66% <100.00%> (ø)
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 324824a...5526372. Read the comment docs.

@karthiknadig karthiknadig merged commit e0fa883 into microsoft:master Mar 16, 2020
DonJayamanne added a commit that referenced this pull request Mar 17, 2020
* master:
  Move redux logging to a different file (#10605)
  Ensure local host only if connection not available (#10600)
  Fix a bunch of debugger issues (#10572)
  Bump acorn from 6.0.0 to 6.4.1 (#10570)
  Resize plot to fit within pdf page (#10547)
  Update dev build instructions to mention "python.insidersChannel"
  Install the ZMQ prebuilt binaries and verify ZMQ works on startup (#10551)
DonJayamanne added a commit that referenced this pull request Mar 17, 2020
* master:
  Fix merge issue
  Move redux logging to a different file (#10605)
  Disable custom editor API (#10604)
  Ensure local host only if connection not available (#10600)
  Delegate management of notebooks (creation and disposing) to I… (#10568)
  Refactor to accommodate upstream VSCode API changes (#10569)
  Use a single notebook beetween multiple native editors (#10514)
  Add support for synchronising edits between two nb editors of… (#10189)
  Fix tests in ds/custom_editor branch (#10512)
  Fix linter
  Reimplement custom editor using new API
karthiknadig added a commit to karthiknadig/vscode-python that referenced this pull request Mar 18, 2020
* Ensure local host only if connection not available

* Add news item
karthiknadig added a commit that referenced this pull request Mar 18, 2020
* Ensure local host only if connection not available

* Add news item
karthiknadig added a commit that referenced this pull request Mar 26, 2020
* Davidkutu/port intellisense fix (#10531)

* Jupyter autocompletion will only show up on empty lines,
instead of appearing in functions.

* filter out magic commands instead of
ignoring all the jupyter intellisense.

* moved the new code to a function and created tests

* removed pressCtrlSpace function

* added comments

* update changelog and delete news file

* Rename datascience to datascience_modules (#10525) (#10528)

* Rename datascience to datascience_modules (#10525)

* Rename datascience to datascience_modules

* Change name to something even harder to get wrong

* Fix unit test failure for release

* Ensure local host only if connection not available (#10600) (#10644)

* Ensure local host only if connection not available

* Add news item

* Fix #10437: Update launch.json handling to support "listen" and "connect" (#10517) (#10654)

Co-authored-by: Pavel Minaev <[email protected]>

* Update version and change log (#10662)

* Update version and change log

* Fix flakey file system tests (#10541)

Co-authored-by: Rich Chiodo <[email protected]>

Co-authored-by: David Kutugata <[email protected]>
Co-authored-by: Rich Chiodo <[email protected]>
Co-authored-by: Pavel Minaev <[email protected]>
@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2020
@karthiknadig karthiknadig deleted the issue10597 branch April 28, 2020 23:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants