BUG: Fix for #10533 np.dtype(ctype) does not respect endianness #12380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: #10533 Added some code that uses the __name__ of the ctypes type. Also added some new test to make sure we'll know if the ctypes data that allows this workaround breaks in the future.
Removed the TODO for this bug.
eric-wieser
reviewed
Nov 13, 2018
eric-wieser
reviewed
Nov 13, 2018
eric-wieser
reviewed
Nov 13, 2018
eric-wieser
reviewed
Nov 13, 2018
Solved the recursiveness issue that failed the automated test. Also did some of Eric's requested changes.
'if t.__ctypes_be__ is t' on Eric's suggestion.
eric-wieser
reviewed
Nov 14, 2018
eric-wieser
reviewed
Nov 14, 2018
eric-wieser
reviewed
Nov 14, 2018
eric-wieser
reviewed
Nov 14, 2018
eric-wieser
reviewed
Nov 14, 2018
eric-wieser
reviewed
Nov 14, 2018
eric-wieser
reviewed
Nov 14, 2018
eric-wieser
reviewed
Nov 14, 2018
eric-wieser
reviewed
Nov 14, 2018
eric-wieser
reviewed
Nov 14, 2018
eric-wieser
approved these changes
Nov 15, 2018
|
Thank you for the review Eric! I enjoyed working on this. I'll go choose some other bug today to check out. |
|
I was thinking the same. I will wait a few days and if he won't reply I will send a PR. I was also looking at #11304 to work on. |
|
Thanks @bmakos and Eric. |
This was referenced Nov 19, 2018
liwt31
pushed a commit
to liwt31/numpy
that referenced
this pull request
Nov 19, 2018
…umpy#12380) * BUG: Fix for numpy#10533 np.dtype(ctype) does not respect endianness See: numpy#10533 Added some code that uses the __name__ of the ctypes type. Also added some new test to make sure we'll know if the ctypes data that allows this workaround breaks in the future. * Fix for numpy#10533 np.dtype(ctype) does not respect endianness Removed the TODO for this bug. * Fix for numpy#10533 np.dtype(ctype) does not respect endianness Solved the recursiveness issue that failed the automated test. Also did some of Eric's requested changes. * Small mistake in the new function fixed. * Changed 'if t.__name__.endswith('_be') ' with 'if t.__ctypes_be__ is t' on Eric's suggestion. * Code cleanup on Eric's recommendations. * Cleaned up the tests on Eric's suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #10533
Added some code that uses the name of the ctypes type. Also
added some new test to make sure we'll know if the ctypes data
that allows this workaround breaks in the future.