-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix(nuxt): correctly move v-if from slot to wrapper component #26386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There might be cases like v-else-if or v-show too. Is there some generic way to solve this instead of having to list out each directive manually? π Also, I believe getPropsToString({'foo-bar': 'baz'}) // gives --- [{ foo-bar: `baz` }] which is invalid JS. (maybe needs |
indeed thank you ! I'm currently working on changing the way slots and client works internally to make this work for non-SFC too. For now I think we only need to extract a few directive, I believe we still want to leave directive on the component (other than v-if/else/elseif) |
This is still not fixed. Or is it guaranteed that the passed bindings won't contain any name having any character other than :a-zA-Z π If not, then something like this at line 162 of const content = Object.entries(bindings).filter(b => b[0] && b[0] !== '_bind').map(([name, value]) => isBinding(name) ? `[\`${name.slice(1)}\`]: ${value}` : `[\`${name}\`]: \`${value}\``).join(',') |
Co-authored-by: Divyansh Singh <[email protected]>
oops sorry, i completly forgot about that ! thanks ! |
π Linked issue
fix #26361
β Type of change
π Description
Hi π this fix a bug where v-if are not correctly moved from the slot to the wrapper component
π Checklist