Add deviation for interface counter #642
Merged
Merged
Conversation
liulk
suggested changes
Oct 13, 2022
| InterfaceEnabled = flag.Bool("deviation_interface_enabled", false, | ||
| "Device requires interface enabled leaf booleans to be explicitly set to true. Full OpenConfig compliant devices should pass both with and without this deviation.") | ||
|
|
||
| CounterLeavesNotUpdated = flag.Bool("deviation_counters_leaves_notupdated", false, "Device updates counters when they are queried at the container level.") |
Contributor
There was a problem hiding this comment.
Suggested change
| CounterLeavesNotUpdated = flag.Bool("deviation_counters_leaves_notupdated", false, "Device updates counters when they are queried at the container level.") | |
| InterfaceCountersFromContainer = flag.Bool("deviation_interface_counters_from_container", false, "Device only supports querying interface counters from the state container, not from individual counter leaves.") |
Contributor
Author
There was a problem hiding this comment.
thank you, addressed
Comment on lines
+909
to
+911
| if *deviations.InterfaceEnabled { | ||
| s.Enabled = ygot.Bool(true) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
no, I missed this one
Pull Request Test Coverage Report for Build 3247650336
💛 - Coveralls |
liulk
approved these changes
Oct 14, 2022
Contributor
|
/gcbrun |
singh-prem
pushed a commit
to mingyangcisco/featureprofiles
that referenced
this pull request
Dec 13, 2022
* add InterfaceOperStatus deviation * Revert "add InterfaceOperStatus deviation" This reverts commit f9855b4. * add deviation for counters leaves that are not updated * add deviation for counters leaves that are not updated * addressed comments
jasdeep-hundal
added a commit
to jasdeep-hundal/featureprofiles
that referenced
this pull request
Apr 11, 2023
jasdeep-hundal
added a commit
to jasdeep-hundal/featureprofiles
that referenced
this pull request
Apr 12, 2023
jasdeep-hundal
added a commit
to jasdeep-hundal/featureprofiles
that referenced
this pull request
Apr 12, 2023
jasdeep-hundal
added a commit
to jasdeep-hundal/featureprofiles
that referenced
this pull request
Apr 19, 2023
jasdeep-hundal
added a commit
that referenced
this pull request
Apr 19, 2023
) * Replicate PR545/546 in OTG telemetry basic test References: - #545 - #546 * Replicate PR642 in OTG telemetry basic test Reference: #642 * Replicate PR890 in OTG telemetry basic test Reference: #890 * Replicate PR1025 in OTG telemetry basic test Reference: #1025 * Replicate PR652 in OTG telemetry basic test Reference: #652 * Replicate PR1196 in OTG telemetry basic test Reference: #1196 * Replicate PR1195 in OTG telemetry basic test Reference: #1195 * Replicate PR1211 in OTG telemetry basic test Reference: #1211 * Replicate PR1248 in OTG telemetry basic test Reference: #1248 * Replicate PR1212 in OTG telemetry basic test Reference: #1212 * Replicate PR1317 in OTG telemetry basic test Reference: #1317 * Remove extra subintf enabled bit not guarded by correct deviations
jasdeep-hundal
added a commit
that referenced
this pull request
Apr 19, 2023
… the ATE version (#1415) * Replicate PR358 in OTG telemetry basic test Reference: #358 * Replicate PR373/412 in OTG telemetry basic test References: - #373 - #412 * Replicate PR641 in OTG telemetry basic test Reference: #641 * Replicate PR642 in OTG telemetry basic test Reference: #642 * Replicate PR1322 in OTG telemetry basic test Reference: #1322 * Replicate PR1407 in OTG telemetry basic test Reference: #1407 * Remove duplicated test case
prinikasn
pushed a commit
that referenced
this pull request
Jun 30, 2023
* add InterfaceOperStatus deviation * Revert "add InterfaceOperStatus deviation" This reverts commit f9855b4. * add deviation for counters leaves that are not updated * add deviation for counters leaves that are not updated * addressed comments
prinikasn
pushed a commit
that referenced
this pull request
Jun 30, 2023
) * Replicate PR545/546 in OTG telemetry basic test References: - #545 - #546 * Replicate PR642 in OTG telemetry basic test Reference: #642 * Replicate PR890 in OTG telemetry basic test Reference: #890 * Replicate PR1025 in OTG telemetry basic test Reference: #1025 * Replicate PR652 in OTG telemetry basic test Reference: #652 * Replicate PR1196 in OTG telemetry basic test Reference: #1196 * Replicate PR1195 in OTG telemetry basic test Reference: #1195 * Replicate PR1211 in OTG telemetry basic test Reference: #1211 * Replicate PR1248 in OTG telemetry basic test Reference: #1248 * Replicate PR1212 in OTG telemetry basic test Reference: #1212 * Replicate PR1317 in OTG telemetry basic test Reference: #1317 * Remove extra subintf enabled bit not guarded by correct deviations
prinikasn
pushed a commit
that referenced
this pull request
Jun 30, 2023
… the ATE version (#1415) * Replicate PR358 in OTG telemetry basic test Reference: #358 * Replicate PR373/412 in OTG telemetry basic test References: - #373 - #412 * Replicate PR641 in OTG telemetry basic test Reference: #641 * Replicate PR642 in OTG telemetry basic test Reference: #642 * Replicate PR1322 in OTG telemetry basic test Reference: #1322 * Replicate PR1407 in OTG telemetry basic test Reference: #1407 * Remove duplicated test case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull adds a deviation to use gnmi get at the container level for reading interface counters. It also guards the ipv4/enabled with the related deviation.