Codestin Search App

taschenb · 2018-02-09T21:35:53Z

This replaces the deprecated Wireless Extensions with nl80211.

Fixes #277

NBonaparte · 2018-02-09T22:38:52Z

+#include <netlink/genl/genl.h>
+#include <netlink/genl/mngt.h>
+#include <netlink/netlink.h>
+


These aren't needed; you could forward declare nl_msg and nlattr instead.

NBonaparte · 2018-02-09T22:39:35Z

 #include "common.hpp"
-#include "settings.hpp"
 #include "errors.hpp"
+#include "settings.hpp"


NBonaparte · 2018-02-09T22:47:15Z

+#include <netlink/genl/genl.h>
+#include <netlink/netlink.h>
+#include <iostream>
+


netlink/netlink.h and iostream aren't needed.

NBonaparte · 2018-02-09T22:50:24Z


   private:
-    shared_ptr<wireless_info> m_info{};
+    unsigned int m_ifid;


Might as well use brace initialization here to be consistent.

NBonaparte · 2018-02-09T23:42:47Z

+      if (ies_len < hdr_len || ies_len < ies[1] + hdr_len) {
+        m_essid.clear();
+      } else {
+        m_essid = string(reinterpret_cast<char*>(ies + hdr_len));


We can cast ies to char * from the beginning (line 419) and avoid having to cast it again. Also, we should pass the ESSID length (ies[1]) to the string constructor so we don't include the data after the ESSID as part of the name.

On top of that, ies can contain non-printable characters. So isprint should be used to test ies.

NBonaparte · 2018-02-10T00:08:04Z

+      // For a more intuitive result, clamp the result to a
+      // signal range, where 100% are reachable without directly
+      // sitting on top of the AP
+      const int hardware_max = -40;


IMO if we modify the values too much it might confuse users if they compare it to other sources.
From nl80211_xbm_to_percent it seems like -20 and -90 dBm are the commonly used values, so it might be best to use those instead.

This just came up in #1834. Though nl80211_xbm_to_percent in the NetworkManager code says it goes from -20 to -90, the way the percentage is calculated, it actually goes from -120dBm to -20dBm. -90dBm corresponds to 30%.

But I think the -20 to -90 range is good.

NBonaparte · 2018-04-18T02:16:20Z

@taschenb Do you have any interest in continuing this PR?

patrick96 · 2018-05-05T08:51:07Z

I think we should, for the time being, have both wireless_tools and nl80211 available side by side and have a config option to enable nl80211. This way we don't leave users with a broken bar, if something doesn't work.

su8 · 2018-05-05T14:43:47Z


-    // Ignore interfaces in ad-hoc mode
-    if (req.u.mode == IW_MODE_ADHOC) {
+    nl_socket_modify_cb(sk, NL_CB_VALID, NL_CB_CUSTOM, scan_cb, this);


if (0 != (nl_socket_modify_cb ...)) { handle_error }

su8 · 2018-05-05T14:48:40Z

-      m_linkquality.val = stats.qual.qual;
-      m_linkquality.max = range.max_qual.qual;
-    }
+    return status == NL80211_BSS_STATUS_ASSOCIATED || status == NL80211_BSS_STATUS_IBSS_JOINED;


NL80211_BSS_STATUS_AUTHENTICATED should be tested too.

Also a switch() or & operator will be better to test against multiple cases.

taschenb · 2018-06-08T18:01:39Z

I am deeply sorry for the late response.
I addressed the feedback from the code review. Thank you for that so far.

As for the coexistence with Wext, what approach would you suggest to select the interface to use? Would a simple CMake option or fallback-search for libnl in case libiw isn't found be sufficient for the time being? Or should we cleanup the network interface and expose a option in the network module?

NBonaparte · 2018-06-08T20:18:03Z

A compile option should suffice. We should probably have libnl as the default and use libiw as a fallback in case the former isn't found.

One of the builds failed when doing apt-get install so I restarted it, and it successfully completed this time.

taschenb · 2018-06-09T19:58:54Z

In the latest update, nl80211 is now the preferred interface. In case libnl-genl-3.0 is not preset or -DWITH_LIBNL=OFF, it will fall back to Wext.

NBonaparte

Code looks good; I think README and build.sh should still mention both libnl and wireless_tools.

taschenb · 2018-06-12T08:29:20Z

You are right, totally forgot about readding it. Is now in there as well.

NBonaparte · 2018-06-14T20:15:02Z

A little nitpicky, but could you extend the other prompts to be the same length by adding more -s?

taschenb · 2018-06-15T13:35:24Z

Good catch and not nitpicky. Everything should be and look consistent.
But the length of the prompt is still OK in general or should we try to limit this?

Prepare for different implementations of wireless_network

NBonaparte · 2018-06-16T02:17:53Z

We could probably shorten it to Include support for "internal/network" (requires libnl/libiw) -- [y/N]: unless there's an even shorter way.

This patch enables support for nl80211. In case the libnl-genl-3.0 library isn't found, it will fall back to Wext instead. The library to use can also be manually set with the CMake option WITH_LIBNL. The Wireless-Extensions (WE or Wext) are deprecated and long replaced by cfg80211. Although Wext isn't used by WiFi drivers anymore, CFG80211_WEXT allows old tools to communicate with modern drivers by providing a wrapper API.

Breaking Changes: * `0 < label-NAME-maxlen < 3` will now throw an exception and disable the containing module, if ellipsis is enabled for that label. (#1198) Changelog: Deprecations: * `internal/volume` is now called `internal/alsa` (#967) * temperature: The `%temperature%` is deprecated in favor of `%temperature-c%`(#897) * mpd: `icon-repeatone` is deprecated in favor of `icon-single` (#1295), see #1279 Features: * feat(mpd): Add support for icon-consume (#861) * feat(bspwm): Add workspace separator (#942) * feat(i3): Add workspace separator (#938), see #929 * feat(build): Make polybar build on FreeBSD (#931, polybar/xpp#8), see #239 * feat(volume): Add pulseaudio backend (#779) * feat(script): Add %pid% token for tail commands (#934) * feat(temp): Add temperature tokens without unit (#897) * feat(memory): Add memory used/free ramp (#1038), see #1037 * feat(memory): Add swap tokens (#1018) * feat(net): Add unknown-as-up option (#1077), see #457 * feat(config): Support fractional size and offset (#972), see #953 * feat(xwindow): Add label-empty (#1136) * feat(battery): Add animation-discharging (analog to animation-charging) (#1190) * feat(config): Support pixel offset for bar size and offset values (#1224) * feat(mpd): Add `%album-artist%` token (#1263) * feat(net): Add local_ip6 token (#1239), see #1234 * feat(net): Add nl80211 support (#1009), see #277 Fixes: * fix(mpd): Wrong elapsed time when after standby (#921), see #915 * fix(config): Wrong min, maxlen when using the same token multiple times (#974), see #971 * fix(battery): use power_now correctly (#958), see #928 * fix(mpd): Crash when mpd isn't running (#983), see #979 * fix(xworkspaces): Respect 'enable-scroll' (#1002) * fix(xbacklight): Respect 'enable-scroll' (#1014) * fix(build): support xcb-proto >=1.13 (polybar/xpp#11), see #973 * fix(mpd): Respect MPD_HOST env variable (#1025), see #1007 * fix(i3): Reconnect i3 IPC socket on restart/error (#1099), see #762 * fix(cursor): Occasional crash on mouseover (#1124), see #1117 * fix(net): Mark 'not connected' on querying failure (#1171), see #1163 * fix(gcc): Fix -Wstringop-truncation warning (#1216, polybar/i3ipcpp#7), see #1215 * fix(builder): Don't truncate colors with same channels (#1217), see #1183 * fix(bspwm): Consistent behavior when scrolling through multiple desktops (#986), see #981 * fix(builder): Respect label-ellipsis option (#1198), see #1194

NBonaparte requested changes Feb 10, 2018

View reviewed changes

NBonaparte mentioned this pull request Mar 14, 2018

Adding support for iw in addition to wireless_tools #1094

Closed

NBonaparte mentioned this pull request Apr 18, 2018

No built-in support for 'internal/network' in Archlinux Linux #1173

Closed

patrick96 mentioned this pull request May 5, 2018

Network module: failed to query interface #1211

Closed

su8 reviewed May 5, 2018

View reviewed changes

taschenb force-pushed the nl80211 branch from 6cbc7ff to 715fe6c Compare June 8, 2018 16:50

taschenb force-pushed the nl80211 branch from 715fe6c to 7cca106 Compare June 9, 2018 19:47

taschenb changed the title ~~feat(net): Replace Wext with nl80211~~ feat(net): Add nl80211 support Jun 9, 2018

NBonaparte requested changes Jun 12, 2018

View reviewed changes

taschenb force-pushed the nl80211 branch from 7cca106 to 3d44baf Compare June 12, 2018 08:00

taschenb force-pushed the nl80211 branch 2 times, most recently from fb99001 to 0329703 Compare June 15, 2018 13:30

taschenb added 3 commits June 15, 2018 16:00

refactor(net): Remove trailing whitespaces

98bd0d7

refactor(net): Remove unused headers

2fc6cc4

refactor(net): Move wireless in its own file

30fff8d

Prepare for different implementations of wireless_network

taschenb added 2 commits June 16, 2018 08:45

refactor(build): Realign prompt

33a5012

taschenb force-pushed the nl80211 branch from 0329703 to 33a5012 Compare June 16, 2018 06:49

NBonaparte merged commit 3afc341 into polybar:master Jun 19, 2018

NBonaparte mentioned this pull request Jul 18, 2018

failed to query wlan interface, but iw and ip and ifconfig all show it #1276

Closed

Uh oh!

Uh oh!

Conversation

taschenb commented Feb 9, 2018 • edited by patrick96 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NBonaparte commented Apr 18, 2018

Uh oh!

patrick96 commented May 5, 2018

Uh oh!

su8 May 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

taschenb commented Jun 8, 2018

Uh oh!

NBonaparte commented Jun 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

taschenb commented Jun 9, 2018

Uh oh!

NBonaparte left a comment

Choose a reason for hiding this comment

Uh oh!

taschenb commented Jun 12, 2018

Uh oh!

NBonaparte commented Jun 14, 2018

Uh oh!

taschenb commented Jun 15, 2018

Uh oh!

NBonaparte commented Jun 16, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

taschenb commented Feb 9, 2018 •

edited by patrick96

Loading

su8 May 5, 2018 •

edited

Loading

NBonaparte commented Jun 8, 2018 •

edited

Loading