Added FreeBSD Support#931
Conversation
patrick96
left a comment
There was a problem hiding this comment.
Finally got around to setting up a FreeBSD VM to test this. With gcc, this works fine, with clang, I had to pass -DCMAKE_EXE_LINKER_FLAGS="-L/usr/local/lib" in order for it to work, because /usr/bin/ld doesn't look in /usr/local/lib (on my system at least).
Can you please add -L/usr/local/lib to the linker flags inside cmake
|
Hi @patrick96 This is not necessary because it is made by the ports system. See localbase:ldflags in HERE. EDIT: Also HERE. |
|
That won't work, if someone wants to build against the git repository directly though. |
|
The practice on FreeBSD are: 1- use the pre-built packages FreeBSD users building directly from source are expected to know how to deal with these kind of particularities. Also, if someone want to build from HEAD (for instance) he/she just need to add GH_TAGNAME to the port. Anyway, if @kylecook80 wants to add that will not harm either. |
|
Fair enough. We can also just add it to the wiki, if necessary |
|
The real point is @kylecook80 seems to be gone and we may need to wait forever for that. The way it is, is fine. I do not know C++ but I can try to patch it later. Thanks! |
|
Yeah, I'm gonna merge this and just add a note to the wiki |
|
So, I managed to add CMAKE_EXE_LINKER_FLAGS="-L/usr/local/lib" over the @kylecook80 patch, and is building fine. If you merge this I bring a PR with that ASAP. Thanks. |
|
I apologize for disappearing for a bit. I'm not really doing stuff with FreeBSD anymore. The idea is that each port in the ports tree references a single release, so adding arbitrary GH_TAGNAME when it is unnecessary won't be allowed. Building from source will take tweaking, but using ports is the preferred way to go. Hope that helps. |
Breaking Changes: * `0 < label-NAME-maxlen < 3` will now throw an exception and disable the containing module, if ellipsis is enabled for that label. (#1198) Changelog: Deprecations: * `internal/volume` is now called `internal/alsa` (#967) * temperature: The `%temperature%` is deprecated in favor of `%temperature-c%`(#897) * mpd: `icon-repeatone` is deprecated in favor of `icon-single` (#1295), see #1279 Features: * feat(mpd): Add support for icon-consume (#861) * feat(bspwm): Add workspace separator (#942) * feat(i3): Add workspace separator (#938), see #929 * feat(build): Make polybar build on FreeBSD (#931, polybar/xpp#8), see #239 * feat(volume): Add pulseaudio backend (#779) * feat(script): Add %pid% token for tail commands (#934) * feat(temp): Add temperature tokens without unit (#897) * feat(memory): Add memory used/free ramp (#1038), see #1037 * feat(memory): Add swap tokens (#1018) * feat(net): Add unknown-as-up option (#1077), see #457 * feat(config): Support fractional size and offset (#972), see #953 * feat(xwindow): Add label-empty (#1136) * feat(battery): Add animation-discharging (analog to animation-charging) (#1190) * feat(config): Support pixel offset for bar size and offset values (#1224) * feat(mpd): Add `%album-artist%` token (#1263) * feat(net): Add local_ip6 token (#1239), see #1234 * feat(net): Add nl80211 support (#1009), see #277 Fixes: * fix(mpd): Wrong elapsed time when after standby (#921), see #915 * fix(config): Wrong min, maxlen when using the same token multiple times (#974), see #971 * fix(battery): use power_now correctly (#958), see #928 * fix(mpd): Crash when mpd isn't running (#983), see #979 * fix(xworkspaces): Respect 'enable-scroll' (#1002) * fix(xbacklight): Respect 'enable-scroll' (#1014) * fix(build): support xcb-proto >=1.13 (polybar/xpp#11), see #973 * fix(mpd): Respect MPD_HOST env variable (#1025), see #1007 * fix(i3): Reconnect i3 IPC socket on restart/error (#1099), see #762 * fix(cursor): Occasional crash on mouseover (#1124), see #1117 * fix(net): Mark 'not connected' on querying failure (#1171), see #1163 * fix(gcc): Fix -Wstringop-truncation warning (#1216, polybar/i3ipcpp#7), see #1215 * fix(builder): Don't truncate colors with same channels (#1217), see #1183 * fix(bspwm): Consistent behavior when scrolling through multiple desktops (#986), see #981 * fix(builder): Respect label-ellipsis option (#1198), see #1194
Added support for FreeBSD. Uses libinotify wrapper for inotify calls. I also had to disable some compiler warnings as libinotify uses c99 extensions.
Fixes #239.