feat(script): %pid% token for tail commands#934
Merged
Conversation
Is replaced with the pid of the exec command
Member
|
Not exactly relevant to this PR specifically but is Travis having some issues? The clang build failed here as well as for #931 and I had to restart the builds for it to pass. |
Member
Author
|
I've had it once before where the travis build would suddenly fail for no reason. I think it's just a minor hickup. |
Member
|
Does this fix #720? |
Member
Author
No, it only adds a new token to the script module click commands nothing else. The output of a click command can still not be used inside the bar. However this makes it easier to notify a tail command about a click event, whereas before we would have to write to a certain file to share information with a tailed script. |
NBonaparte
approved these changes
Jan 21, 2018
Member
|
I put the example in the wiki as part of the examples section. |
patrick96
added a commit
that referenced
this pull request
Jul 23, 2018
Breaking Changes: * `0 < label-NAME-maxlen < 3` will now throw an exception and disable the containing module, if ellipsis is enabled for that label. (#1198) Changelog: Deprecations: * `internal/volume` is now called `internal/alsa` (#967) * temperature: The `%temperature%` is deprecated in favor of `%temperature-c%`(#897) * mpd: `icon-repeatone` is deprecated in favor of `icon-single` (#1295), see #1279 Features: * feat(mpd): Add support for icon-consume (#861) * feat(bspwm): Add workspace separator (#942) * feat(i3): Add workspace separator (#938), see #929 * feat(build): Make polybar build on FreeBSD (#931, polybar/xpp#8), see #239 * feat(volume): Add pulseaudio backend (#779) * feat(script): Add %pid% token for tail commands (#934) * feat(temp): Add temperature tokens without unit (#897) * feat(memory): Add memory used/free ramp (#1038), see #1037 * feat(memory): Add swap tokens (#1018) * feat(net): Add unknown-as-up option (#1077), see #457 * feat(config): Support fractional size and offset (#972), see #953 * feat(xwindow): Add label-empty (#1136) * feat(battery): Add animation-discharging (analog to animation-charging) (#1190) * feat(config): Support pixel offset for bar size and offset values (#1224) * feat(mpd): Add `%album-artist%` token (#1263) * feat(net): Add local_ip6 token (#1239), see #1234 * feat(net): Add nl80211 support (#1009), see #277 Fixes: * fix(mpd): Wrong elapsed time when after standby (#921), see #915 * fix(config): Wrong min, maxlen when using the same token multiple times (#974), see #971 * fix(battery): use power_now correctly (#958), see #928 * fix(mpd): Crash when mpd isn't running (#983), see #979 * fix(xworkspaces): Respect 'enable-scroll' (#1002) * fix(xbacklight): Respect 'enable-scroll' (#1014) * fix(build): support xcb-proto >=1.13 (polybar/xpp#11), see #973 * fix(mpd): Respect MPD_HOST env variable (#1025), see #1007 * fix(i3): Reconnect i3 IPC socket on restart/error (#1099), see #762 * fix(cursor): Occasional crash on mouseover (#1124), see #1117 * fix(net): Mark 'not connected' on querying failure (#1171), see #1163 * fix(gcc): Fix -Wstringop-truncation warning (#1216, polybar/i3ipcpp#7), see #1215 * fix(builder): Don't truncate colors with same channels (#1217), see #1183 * fix(bspwm): Consistent behavior when scrolling through multiple desktops (#986), see #981 * fix(builder): Respect label-ellipsis option (#1198), see #1194
patrick96
added a commit
to patrick96/polybar
that referenced
this pull request
Oct 4, 2018
If a tailed command is used polybar would generate two action tags, one with %counter% replaced and one with %pid% replaced, but never both This is a bug that was introduced in polybar#934
patrick96
added a commit
to patrick96/polybar
that referenced
this pull request
Oct 5, 2018
If a tailed command is used polybar would generate two action tags, one with %counter% replaced and one with %pid% replaced, but never both This is a bug that was introduced in polybar#934
NBonaparte
pushed a commit
that referenced
this pull request
Oct 9, 2018
If a tailed command is used polybar would generate two action tags, one with %counter% replaced and one with %pid% replaced, but never both This is a bug that was introduced in #934
patrick96
added a commit
to patrick96/polybar
that referenced
this pull request
Nov 17, 2018
If a tailed command is used polybar would generate two action tags, one with %counter% replaced and one with %pid% replaced, but never both This is a bug that was introduced in polybar#934
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be used to send signals to the script running (e.g. SIGUSR1, etc) which
makes it easier to have an updatable state inside the script. With this, it is
for example possible to have a two-state date script:
date.sh:Todo: