Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(tray): Reconfigure tray on error#1392

Merged
patrick96 merged 1 commit into
masterfrom
fix/reconfigure-tray
Aug 21, 2018
Merged

fix(tray): Reconfigure tray on error#1392
patrick96 merged 1 commit into
masterfrom
fix/reconfigure-tray

Conversation

@patrick96

@patrick96 patrick96 commented Aug 21, 2018

Copy link
Copy Markdown
Member

See #591. This is the patch jaagr worked on. Some people report this is working, or at least making things better.

EDIT:
Fixes #591

This will fix the issue of the tray container not being
properly reconfigured when a tray client fails to be added
or removed.
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #1392 into master will increase coverage by 2.73%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1392      +/-   ##
=========================================
+ Coverage    5.84%   8.57%   +2.73%     
=========================================
  Files         161     172      +11     
  Lines        8914    9842     +928     
=========================================
+ Hits          521     844     +323     
- Misses       8393    8998     +605
Flag Coverage Δ
#unittests 8.57% <0%> (+2.73%) ⬆️
Impacted Files Coverage Δ
src/x11/tray_manager.cpp 0.16% <0%> (ø) ⬆️
tests/unit_tests/components/builder.cpp 100% <0%> (ø)
...queue/include/moodycamel/blockingconcurrentqueue.h 0% <0%> (ø)
...ncurrentqueue/include/moodycamel/concurrentqueue.h 0% <0%> (ø)
tests/unit_tests/utils/string.cpp 100% <0%> (ø)
tests/unit_tests/components/command_line.cpp 100% <0%> (ø)
tests/unit_tests/utils/math.cpp 100% <0%> (ø)
tests/unit_tests/utils/file.cpp 100% <0%> (ø)
tests/unit_tests/utils/memory.cpp 100% <0%> (ø)
tests/unit_tests/utils/color.cpp 100% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b32e48a...0edaead. Read the comment docs.

@NBonaparte NBonaparte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure whether this was finished so I never made a PR, but if it works, then I guess we can merge it.

@patrick96

Copy link
Copy Markdown
Member Author

I don't think it will hurt anything.

@patrick96 patrick96 merged commit 676d9d7 into master Aug 21, 2018
@patrick96 patrick96 deleted the fix/reconfigure-tray branch August 21, 2018 19:07
patrick96 added a commit to patrick96/polybar that referenced this pull request Nov 17, 2018
This will fix the issue of the tray container not being
properly reconfigured when a tray client fails to be added
or removed.
patrick96 added a commit that referenced this pull request Dec 23, 2018
### Breaking Changes:
None

### Changelog

**New Config Options**
The following config options were added

In the `[settings]` section:
* `pseudo-transparency`

In `internal/cpu`:
* `ramp-coreload-spacing`, spacing between elements in `<ramp-coreload>` elements
* `%percentage-sum%` in `label`. Shows sum of all percentages

In `custom/script`:
* `double-click-left`
* `double-click-middle`
* `double-click-right`

In `internal/pulseaudio`:
* `interval`, volume increase and decrease steps in percentage points

In `internal/memory`:
* `bar-swap-used`
* `bar-swap-free`
* `ramp-swap-used`
* `ramp-swap-free`

**Deprecations**
* `tray-transparent` in the bar section is no longer used. The tray now always uses pseudo-transparency

**Features**
* volume: adjustable volume steps (#1364), see #1361
* memory: Add progress bars and ramps for swap (#1325)
* render: pseudo-transparency (always used in the tray)  (#595)
* cpu: 
    * Configurable spacing in between coreloads (#1472), see #1389
    * Non-normalized cpu load (#1517), see #1516
* script: Double click actions (#1442)
* net: Support for bridge interfaces (#1528), see #1522
* token: zero pad tokens when min-width value starts with a `0` (#1341), see #1332

**Fixes**
* config: Use font patterns detected on system in sample config (#1350)
* net: Disconnected module when SSID is only an emoji (#1371), see #1367
* tray: Tray overlapping with bar (#1392), see #591
* build: Several build errors (#1395, #1454, #1470, polybar/xpp#12, #1493), see #1447, #1469, #750, #1492
* mpd: format-online-prefix not working (#1402), see #1399
* font: Crash for some font-patterns (#1451), see #1435
* script: 
    * Only `%counter%` or `%pid%` token usable, never both (#1456)
    * click actions with colons in them (#1457), see #984
* renderer: Bar locks up when xorg composite extension is disabled (#1430), see #1425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants