Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(font): Check FcNameParse return value#1451

Merged
NBonaparte merged 1 commit into
polybar:masterfrom
patrick96:issue/1435
Nov 1, 2018
Merged

fix(font): Check FcNameParse return value#1451
NBonaparte merged 1 commit into
polybar:masterfrom
patrick96:issue/1435

Conversation

@patrick96

@patrick96 patrick96 commented Oct 2, 2018

Copy link
Copy Markdown
Member

If FcNameParse returns NULL FcDefaultSubstitute segfaults

We log and throw an error here because the signal emitter swallows all
exceptions so if that exception was thrown, the bar would stop rendering
without any indication as to why.

Fixes #1435

If FcNameParse returns NULL FcDefaultSubstitute segfaults

We log and throw an error here because the signal emitter swallows all
exceptions so if that exception was thrown, the bar would stop rendering
without any indication as to why.

Fixes polybar#1435
@codecov-io

codecov-io commented Oct 2, 2018

Copy link
Copy Markdown

Codecov Report

Merging #1451 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1451      +/-   ##
=========================================
- Coverage    5.84%   5.83%   -0.01%     
=========================================
  Files         161     161              
  Lines        8919    8922       +3     
=========================================
  Hits          521     521              
- Misses       8398    8401       +3
Flag Coverage Δ
#unittests 5.83% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
include/cairo/font.hpp 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fba443...15b7399. Read the comment docs.

@NBonaparte NBonaparte merged commit 01f4957 into polybar:master Nov 1, 2018
@patrick96 patrick96 deleted the issue/1435 branch November 1, 2018 08:17
patrick96 added a commit that referenced this pull request Dec 23, 2018
### Breaking Changes:
None

### Changelog

**New Config Options**
The following config options were added

In the `[settings]` section:
* `pseudo-transparency`

In `internal/cpu`:
* `ramp-coreload-spacing`, spacing between elements in `<ramp-coreload>` elements
* `%percentage-sum%` in `label`. Shows sum of all percentages

In `custom/script`:
* `double-click-left`
* `double-click-middle`
* `double-click-right`

In `internal/pulseaudio`:
* `interval`, volume increase and decrease steps in percentage points

In `internal/memory`:
* `bar-swap-used`
* `bar-swap-free`
* `ramp-swap-used`
* `ramp-swap-free`

**Deprecations**
* `tray-transparent` in the bar section is no longer used. The tray now always uses pseudo-transparency

**Features**
* volume: adjustable volume steps (#1364), see #1361
* memory: Add progress bars and ramps for swap (#1325)
* render: pseudo-transparency (always used in the tray)  (#595)
* cpu: 
    * Configurable spacing in between coreloads (#1472), see #1389
    * Non-normalized cpu load (#1517), see #1516
* script: Double click actions (#1442)
* net: Support for bridge interfaces (#1528), see #1522
* token: zero pad tokens when min-width value starts with a `0` (#1341), see #1332

**Fixes**
* config: Use font patterns detected on system in sample config (#1350)
* net: Disconnected module when SSID is only an emoji (#1371), see #1367
* tray: Tray overlapping with bar (#1392), see #591
* build: Several build errors (#1395, #1454, #1470, polybar/xpp#12, #1493), see #1447, #1469, #750, #1492
* mpd: format-online-prefix not working (#1402), see #1399
* font: Crash for some font-patterns (#1451), see #1435
* script: 
    * Only `%counter%` or `%pid%` token usable, never both (#1456)
    * click actions with colons in them (#1457), see #984
* renderer: Bar locks up when xorg composite extension is disabled (#1430), see #1425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants