fix(mpd): Get format-online-{prefix,suffix} explicitly (#1399)#1402
Conversation
NBonaparte
left a comment
There was a problem hiding this comment.
We could get rid of the try/catch blocks by using load_optional_label() and have an empty string for the fallback.
|
@NBonaparte I would argue that they need to be loaded as |
|
Whoops, I meant to say to use |
|
@NBonaparte yeah, I've thought of that as well, but it seems to be possible for them to be |
|
All right, I guess this is the best way then. Hopefully we can have multiple inheritance implemented soon so we can avoid these hacky workarounds. |
|
Do I understand this correctly that |
|
@patrick96 yes, as well as |
|
Oh, you're right, I thought it would only use the |
### Breaking Changes: None ### Changelog **New Config Options** The following config options were added In the `[settings]` section: * `pseudo-transparency` In `internal/cpu`: * `ramp-coreload-spacing`, spacing between elements in `<ramp-coreload>` elements * `%percentage-sum%` in `label`. Shows sum of all percentages In `custom/script`: * `double-click-left` * `double-click-middle` * `double-click-right` In `internal/pulseaudio`: * `interval`, volume increase and decrease steps in percentage points In `internal/memory`: * `bar-swap-used` * `bar-swap-free` * `ramp-swap-used` * `ramp-swap-free` **Deprecations** * `tray-transparent` in the bar section is no longer used. The tray now always uses pseudo-transparency **Features** * volume: adjustable volume steps (#1364), see #1361 * memory: Add progress bars and ramps for swap (#1325) * render: pseudo-transparency (always used in the tray) (#595) * cpu: * Configurable spacing in between coreloads (#1472), see #1389 * Non-normalized cpu load (#1517), see #1516 * script: Double click actions (#1442) * net: Support for bridge interfaces (#1528), see #1522 * token: zero pad tokens when min-width value starts with a `0` (#1341), see #1332 **Fixes** * config: Use font patterns detected on system in sample config (#1350) * net: Disconnected module when SSID is only an emoji (#1371), see #1367 * tray: Tray overlapping with bar (#1392), see #591 * build: Several build errors (#1395, #1454, #1470, polybar/xpp#12, #1493), see #1447, #1469, #750, #1492 * mpd: format-online-prefix not working (#1402), see #1399 * font: Crash for some font-patterns (#1451), see #1435 * script: * Only `%counter%` or `%pid%` token usable, never both (#1456) * click actions with colons in them (#1457), see #984 * renderer: Bar locks up when xorg composite extension is disabled (#1430), see #1425
Resolves #1399
This is directly related to #868.
I should note that both this fix as well as #868 result in
format-{playing,paused,stopped}options being ignored if the sameformat-onlineoptions have been specified, though I guess it is preferable to config breakage.Sorry for causing this mess in the first place, my bad.