Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(isr): add compression (#1755) #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

feat(isr): add compression (#1755) #1768

wants to merge 42 commits into from

Conversation

maxisam
Copy link
Contributor

@maxisam maxisam commented Sep 3, 2024 •
edited
Loading

  • update type of express, to work with express compress
  • add two more options
    • compressHtml: compression callback to compress the html before storing it in the cache.
    • htmlCompressionMethod: html compression method, it will use gzip by default if not provided.
  • with compressHtml handler, it will automatically disable modifyCachedHtml, since cached html is btye after compressed.
  • with compressHtml, it will send Buffer to cache handler instead of string, since stringify buffer could add 50% in size.
    For redis cache handler, user can use hgetBuffer / hgetallBuffer to handle buffer
  • update doc to show how to use redis with buffer, also improve the redis example by using hash, so it doesn't need to convert to json string first.

maxisam added 27 commits August 20, 2024 14:47
@maxisam
chore(isr): update CacheHandler and IsrServiceInterface typings
ba1cbbe
@maxisam
refactor: fix eslint issues
f7755ac
@maxisam
fix(isr): filter urlsOnHold by cacheKey instead of url
0af4f56
@maxisam
feat: add allowed query params options rx-angular#1743
244bff7
@maxisam
feat: handle query string for filesystem cache rx-angular#1690
50643b3
@maxisam
fix(isr): in memory cache handler should use extends rx-angular#1736
9dc5a70
@maxisam
Merge branch 'fix/instanceof' into dev
76aa916
@maxisam
Merge branch 'refactor/es-lint' into dev
fcb59b2
@maxisam
Merge branch 'feat/allowed-query-params' into dev
cc19ee3
@maxisam
refactor(isr): rename CacheRegeneration to CacheGeneration
c37269b
@maxisam
refactor(isr): rename CacheRegeneration to CacheGeneration
039f09c
@maxisam
fix(isr): handle modifyGeneratedHtml behavior consistantly rx-angular…
c95d1c6 
…#1758
@maxisam
Merge branch 'main' into dev
e7ed6a5
@maxisam
refactor(isr): use modifyGeneratedHtml instead
cb0261a
@maxisam
feat(isr): update the example to show modifyGeneratedHtml usage
2dd9551
@maxisam
Merge branch 'main' into feat/callback-cachemsg
9f4f0cd
@maxisam
Merge pull request #2 from maxisam/feat/consolidate-cache-generation
5b7603e 
Feat: consolidate cache generation
@maxisam
feat(isr): add non-blocking-render option
2c88c4f
@maxisam
feat(isr): add background revalidation option
dcc61f9
@maxisam
feat(isr): enable background revalidation and non-blocking render
fe0bac2
@maxisam
Merge pull request #3 from maxisam/feat/response-first
a88b5ca 
feat(isr): nonBlockingRender & backgroundRevalidation
@maxisam
feat(isr): add compression rx-angular#1755
2ae8857
@maxisam
chore(isr): rename HTML compression method
85b0dc3
@maxisam
Merge pull request #4 from maxisam/feat/compression
bdcc48b 
feat(isr): add compression rx-angular#1755
@maxisam
Merge pull request #5 from maxisam/feat/compression
cd5c42d 
chore(isr): rename HTML compression method
@maxisam
Merge branch 'main' into dev
68f1d59
@maxisam
fix: merging issue
a2192db
@maxisam maxisam changed the title feat(isr): add compression feat(isr): add compression (#1755) Sep 3, 2024
@maxisam maxisam mentioned this pull request Sep 3, 2024
Closed
@maxisam maxisam reopened this Sep 3, 2024
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Sep 3, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e08dd51. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@hoebbelsB hoebbelsB requested a review from eneajaho September 19, 2024 15:27
@github-actions github-actions bot added the 📚 Docs Web Documentation hosted on github pages label Oct 7, 2024
@github-actions github-actions bot added </> Template @rx-angular/template related { } State @rx-angular/state related 🔬 Experimental Experimental: Feature, docs, demos 🛂 Test Unit tests, e2e tests, integration tests, test coverage 🛠️ CDK CDK related labels Nov 24, 2024
@maxisam maxisam marked this pull request as draft November 24, 2024 22:08
@maxisam maxisam marked this pull request as ready for review November 27, 2024 16:40
@maxisam
Copy link
Contributor Author

maxisam commented Nov 27, 2024

@eneajaho I just cleaned it up. It should be good for review now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eneajaho eneajaho Awaiting requested review from eneajaho

Assignees
No one assigned
Labels
🛠️ CDK CDK related 📚 Docs Web Documentation hosted on github pages 🔬 Experimental Experimental: Feature, docs, demos 🚀 ISR { } State @rx-angular/state related </> Template @rx-angular/template related 🛂 Test Unit tests, e2e tests, integration tests, test coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maxisam