FEA add LearningCurveDisplay to show plot learning curve #24084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8019) Co-authored-by: Maren Westermann <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]>
…ion(scikit-learn#24093) Co-authored-by: Guillaume Lemaitre <[email protected]>
…umentation for parameter method (scikit-learn#24098)
…cikit-learn#24094) Co-authored-by: Guillaume Lemaitre <[email protected]>
…#24044) Co-authored-by: Julien Jerphanion <[email protected]>
…scikit-learn#23927) Co-authored-by: Maren Westermann <[email protected]>
Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Meekail Zain <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: Julien Jerphanion <[email protected]>
ArturoAmorQ
reviewed
Oct 27, 2022
Member
ArturoAmorQ
left a comment
There was a problem hiding this comment.
Thanks for the PR @glemaitre, it will certainly be a nice feature!
Here is a batch of comments.
jeremiedbb
reviewed
Nov 16, 2022
jeremiedbb
reviewed
Nov 16, 2022
Co-authored-by: Jérémie du Boisberranger <[email protected]>
ArturoAmorQ
approved these changes
Nov 23, 2022
Member
ArturoAmorQ
left a comment
There was a problem hiding this comment.
A second pass of comments, after-which the PR LGTM ;)
Comment on lines
+158
to
+168
| if std_display_style not in ("errorbar", "fill_between", None): | ||
| raise ValueError( | ||
| f"Unknown std_display_style: {std_display_style}. Should be one of" | ||
| " 'errorbar', 'fill_between', or None." | ||
| ) | ||
|
|
||
| if score_type not in ("test", "train", "both"): | ||
| raise ValueError( | ||
| f"Unknown score_type: {score_type}. Should be one of 'test', " | ||
| "'train', or 'both'." | ||
| ) |
Member
There was a problem hiding this comment.
Can we use the @validate_params decorator here? The tests should then be modified accordingly, though :(
Member
Author
There was a problem hiding this comment.
The current tests for validating parameters are written for Python functions and not class methods.
We will do the changes in the future but I would not include the required changes in this PR.
Co-authored-by: Arturo Amor <[email protected]>
Co-authored-by: Arturo Amor <[email protected]>
Member
|
The rendering issue is fixed and the last comments have been addressed. Let's merge. Thanks @glemaitre ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new display to plot the output of
learning_curvewith sensible default.