Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FIX raise proper error for not supporting multilabel in VotingClassifier #27702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 228 commits into from
Feb 10, 2024
Merged

FIX raise proper error for not supporting multilabel in VotingClassifier #27702

merged 228 commits into from
Feb 10, 2024

Conversation

glemaitre
Copy link
Member

While reviewing #26956, I found that the error message was not correct when Y was multilabel in the format of a DataFrame.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: c49f83d. Link to the linter CI: here

@glemaitre glemaitre mentioned this pull request Nov 2, 2023
Draft
OmarManzoor
OmarManzoor approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @glemaitre

@OmarManzoor OmarManzoor added the Waiting for Second Reviewer First reviewer is done, need a second one! label Dec 6, 2023
ogrisel and others added 20 commits February 10, 2024 18:08
@ogrisel @glemaitre
UX: make the fetch_opeml version warning more informative by listing …
08e0042 
…all versions and urls (scikit-learn#27885)
@scikit-learn-bot @web-flow @glemaitre
🔒 🤖 CI Update lock files for scipy-dev CI build(s) 🔒 🤖 (scikit-learn#…
851b95a 
…27934)

Co-authored-by: Lock file bot <[email protected]>
@scikit-learn-bot @web-flow @glemaitre
🔒 🤖 CI Update lock files for main CI build(s) 🔒 🤖 (scikit-learn#27935)
5c19258 
Co-authored-by: Lock file bot <[email protected]>
@thomasjpfan @glemaitre
MAINT Remove deprecated kwargs support in density (scikit-learn#27925)
ce2e8ae
@thomasjpfan @glemaitre
MAINT Remove deprecated support for int in boolean constraint (scikit…
b1b4b0a 
…-learn#27924)
@lesteve @glemaitre
MAINT Remove left-over from KMeans n_init default deprecation (scikit…
ed71cd4 
…-learn#27938)
@glemaitre @OmarManzoor @betatim
FIX f1_score with zero_division=1 uses directly confusion matrix stat…
0698d97 
…istic (scikit-learn#27577)

Co-authored-by: Omar Salman <[email protected]>
Co-authored-by: Tim Head <[email protected]>
@fcharras @glemaitre
MNT remove take fn in array_api wrapper (scikit-learn#27939)
b36c7f7
@fcharras @glemaitre
MNT Prune unused argument in _array_api_for_tests util (scikit-lear…
d5af01c 
…n#27941)
@glemaitre @lesteve
MAINT order changelog and fix some entries (scikit-learn#27944)
1f4636e 
Co-authored-by: Loïc Estève <[email protected]>
@glemaitre
MAINT bumpversion Python and dependencies (scikit-learn#27910)
4c35970
@glemaitre
MAINT change the default solver in QuantileRegressor (scikit-learn#27943
2fae8d6 
)
@glemaitre
DOC fixes sphinx warning due to rendering issue (scikit-learn#27951)
13f8446
@glemaitre
MAINT do not check for warnings in doc_min_dependencies (scikit-learn…
36a01dd 
…#27949)
@qbarthelemy @agramfort
@glemaitre @jeremiedbb
ENH allow shrunk_covariance to handle multiple matrices at once (scik…
64a6aa5 
…it-learn#25275)

Co-authored-by: Alexandre Gramfort <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: Jérémie du Boisberranger <[email protected]>
@lesteve @ogrisel @glemaitre
MAINT Remove Python<3.9 code from sklearn.utils.fixes (scikit-learn#2…
c6c42bf 
…7945)

Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
@Charlie-XIAO @glemaitre
CLN avoid nested conftests (scikit-learn#27954)
3797778
@glemaitre
MAINT do not copy anymore conftest.py (scikit-learn#27958)
bbbc73b
@Charlie-XIAO @glemaitre
DOC update doc build sphinx link to by matching regex in lock file (s…
be0a42e 
…cikit-learn#27970)
@scikit-learn-bot @web-flow @glemaitre
🔒 🤖 CI Update lock files for scipy-dev CI build(s) 🔒 🤖 (scikit-learn#…
65e7867 
…27975)

Co-authored-by: Lock file bot <[email protected]>
scikit-learn-bot and others added 21 commits February 10, 2024 18:08
@scikit-learn-bot @web-flow @glemaitre
🔒 🤖 CI Update lock files for main CI build(s) 🔒 🤖 (scikit-learn#28216)
efd4bc4 
Co-authored-by: Lock file bot <[email protected]>
@scikit-learn-bot @web-flow @glemaitre
🔒 🤖 CI Update lock files for pypy CI build(s) 🔒 🤖 (scikit-learn#28215)
4cf9b91 
Co-authored-by: Lock file bot <[email protected]>
@scikit-learn-bot @web-flow @glemaitre
🔒 🤖 CI Update lock files for cirrus-arm CI build(s) 🔒 🤖 (scikit-learn…
b073d35 
…#28303)

Co-authored-by: Lock file bot <[email protected]>
@lesteve @ogrisel @glemaitre
CI Update codecov uploader to 0.7.1 (scikit-learn#28361)
4cc9145 
Co-authored-by: Olivier Grisel <[email protected]>
@adrinjalali @glemaitre
FIX MultiOutput* when sub-estimator does not accept metadata (scikit-…
59a8a72 
…learn#28240)
@lesteve @ogrisel @glemaitre
CI Fix pandas copy-on-write issues in scipy-dev (scikit-learn#28348)
f69fff3 
Co-authored-by: Olivier Grisel <[email protected]>
@thomasjpfan @glemaitre
CLN Support _MultimetricScorer directly for internal methods (scikit-…
7bdc959 
…learn#28359)
@punndcoder28 @glemaitre
DOC add links to cross decomposition examples (scikit-learn#26934)
3e4b875
@lesteve @glemaitre
CI Fix following scipy dev coo_matrix attr renaming (scikit-learn#28374)
76f99d1
@Charlie-XIAO @glemaitre
MAINT create robots.txt for setting up pydata-sphinx-theme preview (
5839004 
scikit-learn#28376)
@thomasjpfan @ogrisel @glemaitre
CI Moves macos arm64 wheel building to GitHub Actions (scikit-learn#2…
899bcd4 
…8346)

Co-authored-by: Olivier Grisel <[email protected]>
@alanlivio @glemaitre
Missing import at documentation preprocessing.rst closes scikit-learn…
c1200cb 
…#28381 (scikit-learn#28382)
@lesteve @ogrisel @glemaitre
CI Use environment variable to turn warnings into errors in tests and…
2999c59 
… doc build (scikit-learn#28372)

Co-authored-by: Olivier Grisel <[email protected]>
@Charlie-XIAO @glemaitre
MAINT remove unneeded robots.txt (scikit-learn#28387)
2677ecf
@lesteve @glemaitre
FIX HistgradientBoosting with pandas extension dtypes (scikit-learn#2…
5d3e509 
…8385)
@Choudhry-Shaharyar @glemaitre
DOC: Improved clarity and structure of Support documentation (scikit-…
d0af2b6 
…learn#28292)
@eddiebergman @glemaitre
FIX handle dataframe in ARDRegression when predict requests std. dev. (…
4bcf134 
…scikit-learn#28377)

Co-authored-by: Guillaume Lemaitre <[email protected]>
@bmgdc @glemaitre
DOC add interval range for parameter of SGDRegressor (scikit-learn#28373
6cf261a 
)

Co-authored-by: Guillaume Lemaitre <[email protected]>
@ogrisel @glemaitre
ENH use check_finite=False when calling scipy.linalg functions in ran…
60cd013 
…domized_range_finder (scikit-learn#27537)
@glemaitre
Merge remote-tracking branch 'origin/main' into voting_classifier_err…
f0b3f6e 
…or_dataframe_multilabel
@glemaitre
fix changelog
c49f83d
@glemaitre
Copy link
Member Author

I fixed the changelog (adding to 1.4.1 entry).

@glemaitre glemaitre removed the Waiting for Second Reviewer First reviewer is done, need a second one! label Feb 10, 2024
@glemaitre glemaitre added this to the 1.4.1 milestone Feb 10, 2024
@glemaitre
Copy link
Member Author

Enabling auto-merge upon the two approvals

@glemaitre glemaitre enabled auto-merge (squash) February 10, 2024 17:19
@glemaitre glemaitre merged commit 52943b7 into scikit-learn:main Feb 10, 2024
LeoGrin pushed a commit to LeoGrin/scikit-learn that referenced this pull request Feb 12, 2024
@glemaitre @LeoGrin
FIX raise proper error for not supporting multilabel in VotingClassif…
1c9d6c2 
…ier (scikit-learn#27702)
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Feb 13, 2024
@glemaitre
FIX raise proper error for not supporting multilabel in VotingClassif…
72c8c8d 
…ier (scikit-learn#27702)
glemaitre added a commit that referenced this pull request Feb 13, 2024
@glemaitre
FIX raise proper error for not supporting multilabel in VotingClassif…
b90bfe0 
…ier (#27702)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amueller amueller amueller approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees
No one assigned
Labels
module:ensemble
Projects
None yet
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.