[WIP]Sample weight support to hamming loss #4067
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
marking this as supporting sample weights in the common metrics tests should suffice. |
| n_differences = count_nonzero(y_true - y_pred) | ||
| a = y_true - y_pred | ||
| n_differences = sum([count_nonzero(a[i])*sample_weight[i] | ||
| for i in xrange(a.shape[0])]) |
There was a problem hiding this comment.
use range for python 3 compatibility.
There was a problem hiding this comment.
count_nonzero supports weight and axis calculations...
|
I close wrt #5465 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #3450
Have to add tests, should i test this in the corresponding
hamming_losstests intest_classification?