fixed issue #3450 for hamming loss #5439
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should add a test please. For instance checking that putting a weight of 2 on a sample is equivalent to duplicating it. |
|
Also, I think that it would be good to compare to the scipy implementation in a simple test, now that we are no longer using it. |
|
I suggest re-using the common metric tests which are in https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/metrics/tests/test_common.py |
… in sklean/metrics/tests/test_classification.py
|
Why was this PR closed? |
|
#5465 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added sample_weight support for hamming_loss in scikit-learn/sklearn/metrics/classification.py