[MRG+1] partly fixed issue #3450 for hamming loss #5465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in sklean/metrics/tests/test_classification.py
|
the issue with ci/circleci seems to be related with numpy, and not with the code I provided |
|
yeah ignore circleci for now. |
| @@ -1457,6 +1461,7 @@ def hamming_loss(y_true, y_pred, classes=None): | |||
| >>> hamming_loss(np.array([[0, 1], [1, 1]]), np.zeros((2, 2))) | |||
| 0.75 | |||
| """ | |||
| #check_consistent_length(y_true, y_pred) | |||
There was a problem hiding this comment.
If it's not needed, please remove.
There was a problem hiding this comment.
sorry for this. it's done!
|
Looks good to me |
|
LGTM merging |
agramfort
added a commit
that referenced
this pull request
Oct 21, 2015
[MRG+1] partly fixed issue #3450 for hamming loss
This was referenced Jan 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sample weight support to hamming_loss in sklearn/metrics/classification.py.
Added test with https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/metrics/tests/test_common.py
Added test to compare our implementation of hamming loss with scipy's one