[Form] Fix BC break introduced in #14050 #14223
Conversation
nicolas-grekas
commented
Apr 5, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
This PR was merged into the 2.7 branch. Discussion ---------- [Form] Fix BC break introduced in #14050 | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- f3dbb5d [Form] Fix BC break introduced in #14050
|
The new choice view now has the inherited label, view and data defined again for no reason. |
|
I did it this way to make the source code of the new class as close as possible to the target code in 3.0, thus ease future merges. But if this should be removed, I'm fine with it of course. I merged a lot of PRs today to fix tests. I may continue tonight until travis is back to green. But I'm really fine with re-patching on top of course, provided tests remain green :) |
|
IIUC, this was done to fix passing "new" |
|
You're right, and to allow the reverse also: providing a new ChoiceView to an old type-hinted ChoiceView |
| parent::__construct($label, $value, $data); | ||
| $this->data = $data; | ||
| $this->value = $value; | ||
| $this->label = $label; | ||
|
|
||
| trigger_error('The '.__CLASS__.' class is deprecated since version 2.7 and will be removed in 3.0. Use Symfony\Component\Form\ChoiceList\View\ChoiceView instead.', E_USER_DEPRECATED); |
There was a problem hiding this comment.
this should be triggered only when get_class($this) === __CLASS__
There was a problem hiding this comment.
@stof no it must not because the new class does not call the parent class at all
There was a problem hiding this comment.
but for people extending the choice view to provide their own implementation, this would still be useful indeed
There was a problem hiding this comment.
@Tobion they would get the deprecation thrown by the DebugClassLoader already
There was a problem hiding this comment.
I'm fixing this issue in #14201.
There was a problem hiding this comment.
There was a problem hiding this comment.
Looks like we worked on the same at the same time :) See #14258 for an alternative