[Form] Fix a BC break in the entity #15277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
1 similar comment
|
👍 |
|
Thank you @jakzal. |
fabpot
added a commit
that referenced
this pull request
Jul 15, 2015
This PR was merged into the 2.7 branch. Discussion ---------- [Form] Fix a BC break in the entity | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15273 | License | MIT | Doc PR | - @webmozart this brings back the old behaviour. Attached test case passes on 2.3 with no code modifications. Code [here](https://github.com/symfony/symfony/blob/73bbaa6cc7d706b0e945107657fbd240efec0c97/src/Symfony/Bridge/Doctrine/Form/Type/DoctrineType.php#L199-L206) promises any integer number can be handled with `createChoiceName()`: ```php // If the object has a single-column, numeric ID, use that ID as // field name. We can only use numeric IDs as names, as we cannot // guarantee that a non-numeric ID contains a valid form name if ($idReader->isIntId()) { return array(__CLASS__, 'createChoiceName'); } // Otherwise, an incrementing integer is used as name automatically ``` While `createChoiceName()` can only handle natural numbers. Commits ------- 03642b8 [Form] Fix a BC break in the entity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@webmozart this brings back the old behaviour. Attached test case passes on 2.3 with no code modifications.
Code here promises any integer number can be handled with
createChoiceName():While
createChoiceName()can only handle natural numbers.