[2.8] [Form] Add feature choice_label_attr to ChoiceType #15447
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR was merged into the 2.7 branch. Discussion ---------- [Debug] fix composer.json | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 7cd74d5 [Debug] fix composer.json
* 2.6: [Debug] add missing conflict dep rules [VarDumper] fix very special vars handling
* 2.7: [Debug] fix composer.json [Debug] add missing conflict dep rules [VarDumper] fix very special vars handling Conflicts: src/Symfony/Component/Debug/composer.json
Conflicts: src/Symfony/Component/Routing/Matcher/Dumper/ApacheMatcherDumper.php src/Symfony/Component/Routing/Tests/Matcher/Dumper/LegacyApacheMatcherDumperTest.php
* 2.7: [TwigBundle] added some missing deprecation notices [TwigBundle] use the new Twig autoescaping strategy exit when Twig environment is not set [HttpKernel] fixed missing use cases fixed typo moved AppVariable to the bridge Conflicts: src/Symfony/Bridge/Twig/composer.json
…n (fabpot)
This PR was merged into the 3.0-dev branch.
Discussion
----------
[TwigBundle] removed deprecated ActionsExtension
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | yes
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
This removes the `{% render %}` tags which was replaced by the `{{ render }}` function in 2.2.
Commits
-------
70cd6c9 [TwigBundle] removed deprecated ActionsExtension
* 2.7: [FrameworkBundle] fix routing descriptor for options exit when Twig environment is not set [Routing] fix misleading test for condition [Debug] fix test
This PR was merged into the 3.0-dev branch. Discussion ---------- fixed wrong merge | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- 238bbab fixed wrong merge
This PR was merged into the 3.0-dev branch. Discussion ---------- removed deprecated Twig features | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- 2afd614 removed deprecated Twig features
…etDispatcher methods.
…lClassLoader and DebugClassLoader classes. (hhamon) This PR was merged into the 3.0-dev branch. Discussion ---------- [3.0] [ClassLoader] removed deprecated UniversalClassLoader and DebugClassLoader classes. | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- 1d7cbdd [ClassLoader] removed deprecated UniversalClassLoader and DebugClassLoader classes.
…d methods (aitboudad) This PR was merged into the 3.0-dev branch. Discussion ---------- [3.0][EventDispatcher][Event] removed deprecated methods | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Fixed tickets | ~ | Tests pass? | yes | License | MIT Commits ------- 4ab3e8b [3.0] [EventDispatcher][Event] removed deprecated name methods. ba70a48 [3.0] [EventDispatcher][Event] removed deprecated setDispatcher and getDispatcher methods.
* 2.7: fixed tests [EventDispatcher] Add missing checks to RegisterListenersPass Inline private 'is quoting required' methods in Escaper [HttpKernel] Add request uri to Logger context removed notices for some constants as it does not work well [Debug] fix loading order for legacy classes Add comment as requested Remove duplicate 'require' [Yaml] Improve YAML boolean escaping
…deprecated methods (rosier) This PR was squashed before being merged into the 3.0-dev branch (closes symfony#13348). Discussion ---------- [3.0][Monolog] Remove deprecated interface and deprecated methods | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT Commits ------- 0fa072c [3.0][Monolog] Remove deprecated interface and deprecated methods
…utputInterface (frne) This PR was squashed before being merged into the 3.0-dev branch (closes symfony#13086). Discussion ---------- [Console] Define isVerbose(), etc. methods in OutputInterface Could / should the ```Symfony\Component\Console\Output\OutputInterface``` define the methods ```isQuiet()```, ```isVerbose()```, ```isVeryVerbose()``` and ```isDebug()```? Because the Interface already defines the verbosity constants and the ```getVerbosity()``` method, it will probalby be the right place to do so... | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 1ac95b1 [Console] Define isVerbose(), etc. methods in OutputInterface
Updates the wording and adds missing `Event::getName()` method (the `Event::setName()` method was actually listed twice instead).
…(xabbuh) This PR was merged into the 3.0-dev branch. Discussion ---------- [EventDispatcher] update changelog entry wording | Q | A | ------------- | --- | Fixed tickets | | License | MIT Updates the wording and adds missing `Event::getName()` method (the `Event::setName()` method was actually listed twice instead). Commits ------- 96c992c [EventDispatcher] update changelog entry wording
… IteratorAggregate
…sten) This PR was squashed before being merged into the 3.0-dev branch (closes symfony#15506). Discussion ---------- Unpack nested array instead of using temp var | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Since php 5.5 we can [unpack nested arrays with `list()`](http://php.net/manual/en/control-structures.foreach.php#control-structures.foreach.list) to avoid temp vars. Commits ------- 20e9ed6 Unpack nested array instead of using temp var
* 2.8: (22 commits) [Form] fixed BC-break on grouped choice lists [WebProfilerBundle] add import for Twig macro made Symfony compatible with both Twig 1.x and 2.x [VarDumper] Add caster for pgsql resources [Debug/VarDumper] minor cleanups [Form] only use PropertyPath if not already callable [Form] fix reworked choice list phpdoc [DoctrineBridge][Form] Add old tests to legacy group Fixed warning when command alias is longer than command name removed _self usage when not needed Add support for target attributes. Implement the support of timezone objects in the stub IntlDateFormatter typofix - https://github.com/vlajos/misspell_fixer make doctrine mappings compiler pass exception message more understandable fix debug-ext 003.phpt [Yaml] Nested merge keys [FrameworkBundle] [Command] removed unused variable. [FrameworkBundle] fix serializer config check [Debug] Enhance DebugClassLoader performance on MacOSX Add support for variadic arguments in the GetSetNormalizer ...
* 2.8: fixed Twig deprecations replaced deprecated Twig sameas test by same as fixed a namespace in the upgrade file
* 2.8: fixes CS fixed CS [DependencyInjection] Add missing file headers fixed typo made Symfony compatible with both Twig 1.x and 2.x [FrameworkBundle] Fix precedence of xdebug.file_link_format
|
@xabbuh OK tests should be fixed with last commit |
* 2.8: (21 commits) Fix merge Fix typo Various fixes esp. on Windows Fix the validation of form resources to register the default theme Fix the retrieval of the value with property path when using a loader [appveyor] minor enhancements [Process] Disable failing tests on Windows [Translation] Fix the string casting in the XliffFileLoader Windows and Intl fixes Add appveyor.yml for C.I. on Windows [VarDumper] fixed HtmlDumper to target specific the head tag [travis] merge php: nightly and deps=high test-matrix lines consistently use str_replace to unify directory separators Support omitting the <target> node in an .xlf file. Fix the handling of values for multiple choice types moved PHP nightly to PHP 7.0 fixed tests using deprecation features [Form] made deprecation notice more precise fixed CS Fix BC break after split of ACL from core ... Conflicts: .travis.yml composer.json src/Symfony/Bundle/TwigBundle/DependencyInjection/Configuration.php src/Symfony/Component/Intl/DateFormatter/IntlDateFormatter.php src/Symfony/Component/Intl/Tests/DateFormatter/AbstractIntlDateFormatterTest.php src/Symfony/Component/Locale/Tests/LocaleTest.php
* 2.8: [Console] ProgressBarTest::testAnsiColorsAndEmojis() requires extension mbstring [SecurityBundle] Skip SetAclCommandTest when sqlite is not available [VarDumper] Windows compat for SplCasterTest [Translation][Xliff loader] fixed check target node.
* 2.8: bumped minimal version in appveyor to 5.3.9 [VarDumper] Fix missing support for dumping PHP7 return type Require security-acl 2.7 for BC [travis] disable symfony_debug ext when deps!=no Require actual version of ACL component until ACL/2.8 branch released Do not normalize the kernel root directory path (see symfony#15474). Don't trigger deprecation on interfaces [Debug] Ignore silencing for deprecations [ci] Run minimal versions on appveyor only Deprecated Security ClassUtils in favor of Acl ClassUtils Fix appveyor file consistently use str_replace to unify directory separators (remaining)
|
@HeahDude Looks like you need to do some more rebasing (the diff is far too big). |
|
You are reverting lots of changes done in Symfony 2.8 here. Please fix your PR as it cannot be merged as is (it cannot even be reviewed) |
* 2.8: Mark deprecated Twig functions as deprecated with the Twig feature [appveyor] PHP 5.3.11 for Symfony 2.7 [HttpKernel] Group deprecation notices [Translation] added <tool> element metadata to XliffFileDumper Conflicts: appveyor.yml src/Symfony/Bridge/Twig/AppVariable.php src/Symfony/Bridge/Twig/Extension/AssetExtension.php src/Symfony/Bridge/Twig/Extension/FormExtension.php
|
@HeahDude it's still broken. There's many commits in your PR made by other people. Perhaps it'll be easier if you create a new branch and commit your stuff again. |
|
Closed. See #15887 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkboxes when choice field type is expanded.
null by default