-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Console][FrameworkBundle] Revised console header formatting #19275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
If it's namespaced it can get messy.. but you're right; it's different information. Both are useful :') What about; Or with verbosity;
vs.
But im not sure thats common or even semantically correct.. |
I personally prefer the verbosity flag but I don't know how intuitive this is. |
Another solution would be to remove the |
There might be a lot more info about the kernel you'd want to see... What about simply adding the version + release date (if available) and making an application info command? Not sure if this would be interesting for the core, but it might show nice things such as which bundles are enabled. |
@iltar i was just thinking about that.. with |
I'm afraid that eventually it will come down to this: We need a command line WDT variant |
Agree, this is still not great as a header line when used with Perhaps kernel info is a bit too specific indeed =/ |
For now I'd say a limit of what's available in the |
|
Please, let's focus first on finishing this pull request about the console header. Then we can discuss about the |
Done. |
.sprintf( | ||
' (env: <comment>%s</comment>, debug: <comment>%s</comment>)', | ||
$this->kernel->getEnvironment(), $this->kernel->isDebug() ? 'true' : 'false' | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be on one line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can i go with <comment>%s</>
(vs. <comment>%s</comment>
) btw? Would improve readability in a way :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC we already do that in other places.
I would not remove the app name here. You can have several one and being able to have it with |
Any news on this one? |
@ro0NL Still interested in finishing this one? |
Yes. Try to work on it today. As soon as my laptop is connected :( Op 19 jul. 2016 17:35 schreef "Fabien Potencier" [email protected]:
|
Back up :) @fabpot it's going to be I think it makes sense.. if #19278 is accepted we have more detailed information anyway. Maybe the minor UI change for console applications is worth noting..., not sure. |
Tests should be updated as they do not pass with these changes. |
Green :) |
Thank you @ro0NL. |
Before/After
