Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Console][FrameworkBundle] Revised console header formatting #19275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

[Console][FrameworkBundle] Revised console header formatting #19275

wants to merge 5 commits into from

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Jul 3, 2016

Q A
Branch? "master"
Bug fix? no
New feature? yes (ui change)
BC breaks? no
Deprecations? no
Tests pass? not yet
Fixed tickets #19095
License MIT
Doc PR reference to the documentation PR, if any

Before/After
image

@linaori
Copy link
Contributor

linaori commented Jul 3, 2016

app is not really the kernel, just the name. In this case I'd expect to see AppKernel, would that be nicer to show?

@ro0NL
Copy link
Contributor Author

ro0NL commented Jul 3, 2016

If it's namespaced it can get messy.. but you're right; it's different information. Both are useful :')

What about;
Symfony 3.2.0-DEV on \My\AppKernel(name: app, env: dev, debug: true)

Or with verbosity;

$ bin/console -V
Symfony 3.2.0-DEV

vs.

$ bin/console -V --verbose
Symfony 3.2.0-DEV on \My\AppKernel(name: app, env: dev, debug: true)

But im not sure thats common or even semantically correct..

@linaori
Copy link
Contributor

linaori commented Jul 3, 2016

I personally prefer the verbosity flag but I don't know how intuitive this is.

@javiereguiluz
Copy link
Member

Another solution would be to remove the name: app thing and to not add the kernel info either.

@linaori
Copy link
Contributor

linaori commented Jul 3, 2016

There might be a lot more info about the kernel you'd want to see... What about simply adding the version + release date (if available) and making an application info command? Not sure if this would be interesting for the core, but it might show nice things such as which bundles are enabled.

@ro0NL
Copy link
Contributor Author

ro0NL commented Jul 3, 2016

@iltar i was just thinking about that.. with --verbose we can go really crazy;

image

@linaori
Copy link
Contributor

linaori commented Jul 3, 2016

I'm afraid that eventually it will come down to this: We need a command line WDT variant

@ro0NL
Copy link
Contributor Author

ro0NL commented Jul 3, 2016

Agree, this is still not great as a header line when used with bin/console. So what do we need to show for -V then? (assuming everything is available with bin/console info in some time).

Perhaps kernel info is a bit too specific indeed =/

@linaori
Copy link
Contributor

linaori commented Jul 3, 2016

For now I'd say a limit of what's available in the Kernel constants. I would love to have more debugging info on the command line though, such as a CLI WDT. Maybe a nice feature for 3.2 (though I have no time to work on this).

@ro0NL
Copy link
Contributor Author

ro0NL commented Jul 3, 2016

removed kernel:info command

@javiereguiluz
Copy link
Member

Please, let's focus first on finishing this pull request about the console header. Then we can discuss about the kernel:info command in a separate issue. Thanks!

@ro0NL
Copy link
Contributor Author

ro0NL commented Jul 3, 2016

Done.

.sprintf(
' (env: <comment>%s</comment>, debug: <comment>%s</comment>)',
$this->kernel->getEnvironment(), $this->kernel->isDebug() ? 'true' : 'false'
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be on one line.

Copy link
Contributor Author

@ro0NL ro0NL Jul 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can i go with <comment>%s</> (vs. <comment>%s</comment>) btw? Would improve readability in a way :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC we already do that in other places.

@ro0NL ro0NL changed the title [WIP] Revised console header formatting [Console][FrameworkBundle] Revised console header formatting Jul 4, 2016
@fabpot
Copy link
Member

fabpot commented Jul 8, 2016

I would not remove the app name here. You can have several one and being able to have it with -V is important.

@fabpot
Copy link
Member

fabpot commented Jul 13, 2016

Any news on this one?

@fabpot
Copy link
Member

fabpot commented Jul 19, 2016

@ro0NL Still interested in finishing this one?

@ro0NL
Copy link
Contributor Author

ro0NL commented Jul 20, 2016

Yes. Try to work on it today. As soon as my laptop is connected :(

Op 19 jul. 2016 17:35 schreef "Fabien Potencier" [email protected]:

@ro0NL https://github.com/ro0NL Still interested in finishing this one?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#19275 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA_8kAIy7NN_USpVFhfpth5vuvP7fo8Pks5qXO68gaJpZM4JD0O5
.

@ro0NL
Copy link
Contributor Author

ro0NL commented Jul 20, 2016

Back up :) @fabpot it's going to be Symfony 3.2.0-DEV (kernel: app, env: dev, debug: true) then.. where kernel refers the kernel name, not the kernel type.

I think it makes sense.. if #19278 is accepted we have more detailed information anyway.

Maybe the minor UI change for console applications is worth noting..., not sure.

@fabpot
Copy link
Member

fabpot commented Jul 28, 2016

Tests should be updated as they do not pass with these changes.

@ro0NL
Copy link
Contributor Author

ro0NL commented Jul 29, 2016

Green :)

@fabpot
Copy link
Member

fabpot commented Jul 29, 2016

Thank you @ro0NL.

@fabpot fabpot closed this in ad85c79 Jul 29, 2016
@ro0NL ro0NL deleted the frameworkbundle/console-header branch August 6, 2016 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants