[EventDispatcher] Remove deprecation layer #31709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5c719bb to
64ad6fe
Compare
64ad6fe to
f7fb9d9
Compare
f7fb9d9 to
f0fca27
Compare
a405ead to
d22d8de
Compare
|
Travis build should be green after #31712. |
nicolas-grekas
added a commit
that referenced
this pull request
May 30, 2019
…atcher 5 (derrabus) This PR was merged into the 4.4 branch. Discussion ---------- Marked several components as incompatible with EventDispatcher 5 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A Quite a few components still use the old event class that is to be removed in Symfony 5. This PR ensures that they are only installed with EventDispatcher 4. Follow up to #31709 Commits ------- e6a4526 Marked several components as incompatible with EventDispatcher 5.
d22d8de to
d50da46
Compare
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function dispatch($event, string $eventName = null); |
There was a problem hiding this comment.
already in the parent interface, thus not needed
There was a problem hiding this comment.
Yes, but in the parent interface, the second argument is commented out. As far as I understand this note, event dispatcher implementations in 5.0 must have this signature, so I'm making sure that they do.
src/Symfony/Component/EventDispatcher/LegacyEventDispatcherProxy.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/EventDispatcher/Tests/ImmutableEventDispatcherTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/Tests/Debug/TraceableEventDispatcherTest.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
requested changes
May 30, 2019
That would violate the contracts interface, wouldn't it?
The changes that I've made to the other components should not affect the compatibility with EventDispatcher 4.4, as far as I can tell. |
|
PHP 7.2 return type variance allows adding the type, right? |
Oh right, the return type. Yes, of course. I misread your comment and thought you meant the type-hint for the |
d50da46 to
dd97350
Compare
nicolas-grekas
added a commit
that referenced
this pull request
May 30, 2019
… (derrabus) This PR was merged into the 4.4 branch. Discussion ---------- [HttpKernel] Don't install HttpKernel 4.4 with Console 5 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A Another attempt to get the build of #31709 green. Because the base class of `ConsoleEvent` was changed, the Console component 5.0 in going to be incompatible with `DebugHandlersListener` in HttpKernel 4.4. Commits ------- 44f326d HttpKernel 4.4 is incompatible with Console 5 because of the EventDispatcher changes.
dd97350 to
638e2af
Compare
a46983c to
9a185e8
Compare
nicolas-grekas
approved these changes
May 30, 2019
chalasr
approved these changes
May 30, 2019
9a185e8 to
678e066
Compare
|
Thank you @derrabus. |
nicolas-grekas
added a commit
that referenced
this pull request
May 31, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [EventDispatcher] Remove deprecation layer | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A This PR removes all deprecations from the event dispatcher component. Commits ------- 678e066 [EventDispatcher] Remove deprecation layer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all deprecations from the event dispatcher component.