Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Messenger] make StopWorkerOnSignalsListener listen by default on SIGTERM and SIGINT #49539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Feb 26, 2023

Q A
Branch? 6.3
Bug fix? no
New feature? yes
Deprecations? yes
Tickets Fix #49156
License MIT
Doc PR no need I guess

@lyrixx
Copy link
Member Author

lyrixx commented Mar 2, 2023

This PR is ready for review 👍🏼

@carsonbot
Copy link

Hey!

I think @ruudk has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@lyrixx lyrixx force-pushed the messenge-signal branch from 3759eac to ec409e6 Compare March 9, 2023 17:10
@lyrixx lyrixx force-pushed the messenge-signal branch from ec409e6 to 9415b43 Compare March 9, 2023 17:12
@fabpot
Copy link
Member

fabpot commented Mar 10, 2023

Thank you @lyrixx.

@fabpot fabpot merged commit 550b92f into symfony:6.3 Mar 10, 2023
@lyrixx lyrixx deleted the messenge-signal branch March 10, 2023 13:45
@fabpot fabpot mentioned this pull request May 1, 2023
nicolas-grekas added a commit that referenced this pull request Sep 29, 2023
…HypeMC)

This PR was merged into the 6.3 branch.

Discussion
----------

[Messenger] Fix exiting `messenger:failed:retry` command

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

#49539 introduced a bug where it's impossible to exit the `messenger:failed:retry` command:

![Screenshot](https://github.com/symfony/symfony/assets/2445045/6d6d271b-b5f6-4d2f-a150-847ead22083b)

`Ctrl+C` doesn't work because the `StopWorkerOnSignalsListener` handles the signal but doesn't actually exit the command, so the only way to currently exit the command is to kill it by force.

Commits
-------

cd6816b [Messenger] Fix exiting `FailedMessagesRetryCommand`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Messenger] Also listen to SIGINT in StopWorkerOnSigtermSignalListener
4 participants