-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Messenger] make StopWorkerOnSignalsListener listen by default on SIGTERM and SIGINT #49539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lyrixx
commented
Feb 26, 2023
•
edited
Loading
edited
Q | A |
---|---|
Branch? | 6.3 |
Bug fix? | no |
New feature? | yes |
Deprecations? | yes |
Tickets | Fix #49156 |
License | MIT |
Doc PR | no need I guess |
6430e04
to
3759eac
Compare
This PR is ready for review 👍🏼 |
Hey! I think @ruudk has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
src/Symfony/Bundle/FrameworkBundle/Resources/config/messenger.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Mar 9, 2023
fabpot
approved these changes
Mar 10, 2023
Thank you @lyrixx. |
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Sep 29, 2023
…HypeMC) This PR was merged into the 6.3 branch. Discussion ---------- [Messenger] Fix exiting `messenger:failed:retry` command | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - #49539 introduced a bug where it's impossible to exit the `messenger:failed:retry` command:  `Ctrl+C` doesn't work because the `StopWorkerOnSignalsListener` handles the signal but doesn't actually exit the command, so the only way to currently exit the command is to kill it by force. Commits ------- cd6816b [Messenger] Fix exiting `FailedMessagesRetryCommand`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.