Update esi.rst #7653
Update esi.rst #7653
Conversation
| // you can use a controller reference | ||
| use Symfony\Component\HttpKernel\Controller\ControllerReference; | ||
| ?> | ||
| <?php echo $view['actions']->render( |
There was a problem hiding this comment.
It's useless to have end/open blocks.
There was a problem hiding this comment.
It's "useless" most of the times ... but in this case this is an example of a PHP template, so you must open/close PHP tags whenever you add PHP code. However, I don't know which is the current practice in the docs regarding the use ... imports. Maybe we do an exception for those blocks? Let's ask to @wouterj and @xabbuh. Thanks!
There was a problem hiding this comment.
In other template code examples, each piece of PHP code is surrounded by open/close tags as @javiereguiluz said? I just did the same and I am not sure about what's the correct practice in this case
|
Thank you for the many good catches and improvements @atailouloute! To ease the merging of all the small fixes I will combine your PRs in a single PR (see #7737) and merge that one instead. |
…ULOUTE) This PR was squashed before being merged into the 2.7 branch (closes #7737). Discussion ---------- lots of minor tweaks and fixes This PR contains all the commits from the following pull requests: * #7641 * #7652 * #7653 * #7666 * #7667 * #7669 * #7673 * #7674 * #7675 * #7677 * #7680 * #7681 * #7710 * #7711 * #7712 * #7713 * #7714 * #7716 * #7717 * #7718 * #7721 * #7722 * #7736 Commits ------- 3d61281 lots of minor tweaks and fixes
Fixing some portions of PHP code that are not surrounded with PHP tags