Update hostname_pattern.rst #7714
Conversation
| @@ -193,7 +193,8 @@ instance, if you want to match both ``m.example.com`` and | |||
| <?xml version="1.0" encoding="UTF-8" ?> | |||
| <routes xmlns="http://symfony.com/schema/routing" | |||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
| xsi:schemaLocation="http://symfony.com/schema/routing http://symfony.com/schema/routing/routing-1.0.xsd"> | |||
| xsi:schemaLocation="http://symfony.com/schema/routing | |||
There was a problem hiding this comment.
I searched on the documentation (all of it), the https is never used in XML examples. Is it normal to do it just in this example ?
There was a problem hiding this comment.
I think @atailouloute is right. We have literally thousands of these XML URLs and none of them use HTTPS. We recently added HTTPS for every link that points to symfony.com (see #7481) but we left on purpose these links unchanged. The reason is that it could generate lots of conflicts when merging other PRs ... but maybe I'm wrong and changing to HTTPS would create no conflicts. In any case, I think we should decide to do that (or not) in a separate PR. Thanks!
There was a problem hiding this comment.
Ok for doing it a specific PR then, but we really should!
|
Thank you for the many good catches and improvements @atailouloute! To ease the merging of all the small fixes I will combine your PRs in a single PR (see #7737) and merge that one instead. |
…ULOUTE) This PR was squashed before being merged into the 2.7 branch (closes #7737). Discussion ---------- lots of minor tweaks and fixes This PR contains all the commits from the following pull requests: * #7641 * #7652 * #7653 * #7666 * #7667 * #7669 * #7673 * #7674 * #7675 * #7677 * #7680 * #7681 * #7710 * #7711 * #7712 * #7713 * #7714 * #7716 * #7717 * #7718 * #7721 * #7722 * #7736 Commits ------- 3d61281 lots of minor tweaks and fixes
Update some XML examples to remove the horizontal scrollbar and to be coherent with the other examples in the same page