Fix some PHP codes #7736
Closed
Fix some PHP codes #7736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Apr 1, 2017
| @@ -68,7 +68,7 @@ directory: | |||
| $container->loadFromExtension('twig', array( | |||
| 'paths' => array( | |||
| '%kernel.root_dir%/../vendor/acme/foo-bar/templates' => 'foo_bar', | |||
| ); | |||
| ) | |||
There was a problem hiding this comment.
we should add a trailing comma here
|
Thank you for the many good catches and improvements @atailouloute! To ease the merging of all the small fixes I will combine your PRs in a single PR (see #7737) and merge that one instead. |
xabbuh
added a commit
that referenced
this pull request
Apr 1, 2017
…ULOUTE) This PR was squashed before being merged into the 2.7 branch (closes #7737). Discussion ---------- lots of minor tweaks and fixes This PR contains all the commits from the following pull requests: * #7641 * #7652 * #7653 * #7666 * #7667 * #7669 * #7673 * #7674 * #7675 * #7677 * #7680 * #7681 * #7710 * #7711 * #7712 * #7713 * #7714 * #7716 * #7717 * #7718 * #7721 * #7722 * #7736 Commits ------- 3d61281 lots of minor tweaks and fixes
xabbuh
added a commit
that referenced
this pull request
Apr 1, 2017
HeahDude
reviewed
Apr 1, 2017
| @@ -294,7 +293,7 @@ file: | |||
| 'twig' => array( | |||
| 'functions' => array( | |||
| 'jpegoptim' => array( | |||
| output => 'images/*.jpg' | |||
| 'output' => 'images/*.jpg' | |||
There was a problem hiding this comment.
There should be a trailing comma here too.
There was a problem hiding this comment.
The PR is closed, I'll do this changes in another commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.