Literal keys contents / values #1036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eemeli
requested changes
Feb 21, 2025
There was a problem hiding this comment.
Rather than defining the value of a literal, it's clearer if we define the string value of a literal.
That's a term that can be naturally used in the places referring to it, and more directly incorporates "string" as a qualifier for "value", a term that we've tried to avoid using unadorned.
Merge @eemeli's suggestions plus the "forked" suggestion from Mark Co-authored-by: Eemeli Aro <[email protected]>
aphillips
reviewed
Feb 21, 2025
aphillips
approved these changes
Feb 21, 2025
eemeli
approved these changes
Feb 21, 2025
Comment on lines
+759
to
+763
| The **_<dfn>string value</dfn>_** of a _literal_ | ||
| for _unquoted literals_ is the text content of that _literal_; | ||
| or for _quoted literals_, the text content of that _literal_ | ||
| after removing the enclosing `|` characters | ||
| then unescaping any escaped characters. |
There was a problem hiding this comment.
This feels a bit clumsy, but not objectionably so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1028