Thanks to visit codestin.com
Credit goes to github.com

Skip to content

hashsum: don't fail on dirs #8930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2025
Merged

hashsum: don't fail on dirs #8930

merged 1 commit into from
Oct 26, 2025

Conversation

@Ada-Armstrong
Copy link
Contributor

@Ada-Armstrong Ada-Armstrong commented Oct 16, 2025 •
edited
Loading

Fix for #8912.
Playing around with GNU md5sum I found that not only does it continue on IsADirectory but also on other OS errors as well, such as NotFound and PermissionDenied.

@github-actions
Copy link

github-actions bot commented Oct 16, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

@Ada-Armstrong Ada-Armstrong force-pushed the hashsum_continue_on_dirs branch from d773b72 to 8af74a1 Compare October 16, 2025 19:38
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 16, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8930 will not alter performance

Comparing Ada-Armstrong:hashsum_continue_on_dirs (214bc1c) with main (a452d86)

Summary

✅ 106 untouched
⏩ 73 skipped1

Footnotes

  1. 73 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@Ada-Armstrong Ada-Armstrong force-pushed the hashsum_continue_on_dirs branch from 8af74a1 to 8d84ea8 Compare October 16, 2025 19:55
@github-actions
Copy link

github-actions bot commented Oct 16, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/rm/rm1 (passes in this run but fails in the 'main' branch)

@Ada-Armstrong
Copy link
Contributor Author

Ada-Armstrong commented Oct 16, 2025

Could someone who has access to a Windows machine run the following: md5sum dir
Where dir is a directory using GNU md5sum. I'm not sure what the expected stderr message is supposed to be, thanks!

@naoNao89 naoNao89 mentioned this pull request Oct 17, 2025
Merged
@oech3
Copy link
Contributor

oech3 commented Oct 20, 2025

#8930 (comment)
I think GNU's coreutils itself does not support Win and any difference between Linux should be treated as bug of emulator for Linux.

@sylvestre
Copy link
Contributor

sylvestre commented Oct 20, 2025

Could someone who has access to a Windows machine run the following: md5sum dir Where dir is a directory using GNU md5sum. I'm not sure what the expected stderr message is supposed to be, thanks!

You can do it in the CI. just write a windows specific test with some println! and an expected failure

@Ada-Armstrong Ada-Armstrong force-pushed the hashsum_continue_on_dirs branch 2 times, most recently from 2f68552 to dab7554 Compare October 22, 2025 17:43
sylvestre
sylvestre reviewed Oct 22, 2025
View reviewed changes
src/uu/hashsum/src/hashsum.rs Outdated
(command, is_hashsum_bin)
}

fn print_os_error(binary_name: &str, filename: &str, os_error: &Error) {
Copy link
Contributor

@sylvestre sylvestre Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have this:
https://docs.rs/uucore/latest/uucore/error/fn.strip_errno.html

Copy link
Contributor Author

@Ada-Armstrong Ada-Armstrong Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I should have done more searching.

Copy link
Contributor

@sylvestre sylvestre Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries!

@github-actions
Copy link

github-actions bot commented Oct 22, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@Ada-Armstrong Ada-Armstrong force-pushed the hashsum_continue_on_dirs branch from dab7554 to 889d59c Compare October 23, 2025 13:32
@github-actions
Copy link

github-actions bot commented Oct 23, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@Ada-Armstrong Ada-Armstrong force-pushed the hashsum_continue_on_dirs branch from 889d59c to 345e322 Compare October 25, 2025 03:35
@Ada-Armstrong Ada-Armstrong force-pushed the hashsum_continue_on_dirs branch from 345e322 to 214bc1c Compare October 25, 2025 03:48
@sylvestre sylvestre merged commit f7e639f into uutils:main Oct 26, 2025
120 of 121 checks passed
@mfontanaar mfontanaar mentioned this pull request Nov 9, 2025
Open
@BrewTestBot BrewTestBot mentioned this pull request Nov 10, 2025
Merged
@moonfruit moonfruit mentioned this pull request Nov 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvestre sylvestre sylvestre left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ada-Armstrong @oech3 @sylvestre