Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/python-spanner
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.15.1
Choose a base ref
...
head repository: googleapis/python-spanner
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.16.0
Choose a head ref
  • 16 commits
  • 35 files changed
  • 7 contributors

Commits on Apr 15, 2020

  1. docs(spanner): changes to support sphinx new release (#54) 

    * docs(spanner): changes to support sphinx new release

* docs(spanner): variable fix in changelog file

* docs(spanner): nit
    @HemangChothani
    HemangChothani authored Apr 15, 2020
    Configuration menu
    Copy the full SHA
    c45f4fc View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2020

  1. fix: add keepalive changes to synth.py (#55) 

    Co-authored-by: larkee <[email protected]>
    @larkee
    larkee and larkee authored Apr 16, 2020
    Configuration menu
    Copy the full SHA
    805bbb7 View commit details
    Browse the repository at this point in the history

  2. docs(spanner): fix single character parameter (#48) 

    * docs(spanner): fix single character parameter

* docs(spanner): fix single character parameters

* docs(spanner): fix lint

* docs(spanner): nits

* docs(spanner): nit
    @HemangChothani
    HemangChothani authored Apr 16, 2020
    Configuration menu
    Copy the full SHA
    0f526bf View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2020

  1. fix: pass gRPC config options to gRPC channel creation (#26) 

    * fix: pass gRPC config options to grpc channel creation

* regen spanner_grpc_transport.py to include changes (via synth)

Co-authored-by: larkee <[email protected]>
    @larkee
    larkee and larkee authored Apr 17, 2020
    Configuration menu
    Copy the full SHA
    6c9a1ba View commit details
    Browse the repository at this point in the history

  2. test: use assertIsInstance where possible (#57) 

    Co-authored-by: larkee <[email protected]>
    @larkee
    larkee and larkee authored Apr 17, 2020
    Configuration menu
    Copy the full SHA
    df199f7 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2020

  1. docs: update how to set up background thread to ping PingingPool and … 

    …TransactionPingingPool (#62)

Co-authored-by: larkee <[email protected]>
    @larkee
    larkee and larkee authored Apr 21, 2020
    Configuration menu
    Copy the full SHA
    b16ee7c View commit details
    Browse the repository at this point in the history

  2. docs: add begin_pending_transactions() to the background thread examp… 

    …le for TransactionPingingPool (#63)

Co-authored-by: larkee <[email protected]>
    @larkee
    larkee and larkee authored Apr 21, 2020
    Configuration menu
    Copy the full SHA
    1d49766 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2020

  1. docs: make it clear ddl_statements is a list in docs (#59) 

    The ddl_statements fields expects a list of strings, not a string. This aims to make that more clear in the documentation.
    @bpg130
    bpg130 authored Apr 28, 2020
    Configuration menu
    Copy the full SHA
    d63dcb6 View commit details
    Browse the repository at this point in the history

  2. chore: Migrate python-spanner synth.py from artman to bazel (#64)

    @vam-google
    vam-google authored Apr 28, 2020
    Configuration menu
    Copy the full SHA
    5d8935d View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2020

  1. docs: re-pin sphinx version (#70) 

    Reopens #50

Unfortunately, synthtool has pinned to sphinx<3.0.0 which means any code regen via synth will cause docs to fail. Until it is updated to support it, we also need to pin to sphinx<3.0.0.
    @larkee
    larkee authored Apr 29, 2020
    Configuration menu
    Copy the full SHA
    4d54a5c View commit details
    Browse the repository at this point in the history

  2. chore: update backup timeout config (via synth) (#65) 

    This PR was generated using Autosynth. 🌈


<details><summary>Log from Synthtool</summary>

```
2020-04-21 06:27:51,005 synthtool > Executing /tmpfs/src/git/autosynth/working_repo/synth.py.
On branch autosynth
nothing to commit, working tree clean
2020-04-21 06:27:51,079 synthtool > Ensuring dependencies.
2020-04-21 06:27:51,084 synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:b3b47805231a305d0f40c4bf069df20f6a2635574e6d4259fac651d3f9f6e098
Status: Image is up to date for googleapis/artman:latest
2020-04-21 06:27:52,770 synthtool > Cloning googleapis.
2020-04-21 06:27:53,424 synthtool > Running generator for google/spanner/artman_spanner.yaml.
2020-04-21 06:28:12,779 synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1.
2020-04-21 06:28:12,780 synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/v1/mutation.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1/google/cloud/spanner_v1/proto/mutation.proto
2020-04-21 06:28:12,780 synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/v1/spanner.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1/google/cloud/spanner_v1/proto/spanner.proto
2020-04-21 06:28:12,781 synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/v1/type.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1/google/cloud/spanner_v1/proto/type.proto
2020-04-21 06:28:12,781 synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/v1/keys.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1/google/cloud/spanner_v1/proto/keys.proto
2020-04-21 06:28:12,781 synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/v1/result_set.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1/google/cloud/spanner_v1/proto/result_set.proto
2020-04-21 06:28:12,781 synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/v1/transaction.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1/google/cloud/spanner_v1/proto/transaction.proto
2020-04-21 06:28:12,782 synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/v1/query_plan.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1/google/cloud/spanner_v1/proto/query_plan.proto
2020-04-21 06:28:12,782 synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-v1/google/cloud/spanner_v1/proto.
2020-04-21 06:28:12,791 synthtool > Replaced 'import google.api_core.grpc_helpers\n' in google/cloud/spanner_v1/gapic/transports/spanner_grpc_transport.py.
2020-04-21 06:28:12,791 synthtool > Replaced 'from google.cloud.spanner_v1.proto import spanner_pb2_grpc\n' in google/cloud/spanner_v1/gapic/transports/spanner_grpc_transport.py.
2020-04-21 06:28:12,793 synthtool > Replaced "(\\s+)'grpc.max_receive_message_length': -1," in google/cloud/spanner_v1/gapic/transports/spanner_grpc_transport.py.
2020-04-21 06:28:12,795 synthtool > Replaced '(\\s+)return google.api_core.grpc_helpers.create_channel\\(\n' in google/cloud/spanner_v1/gapic/transports/spanner_grpc_transport.py.
2020-04-21 06:28:12,795 synthtool > Replaced 'from google.cloud import spanner_v1' in tests/unit/gapic/v1/test_spanner_client_v1.py.
2020-04-21 06:28:12,796 synthtool > Running generator for google/spanner/admin/instance/artman_spanner_admin_instance.yaml.
2020-04-21 06:28:29,994 synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-admin-instance-v1.
2020-04-21 06:28:29,995 synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/admin/instance/v1/spanner_instance_admin.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-admin-instance-v1/google/cloud/spanner_admin_instance_v1/proto/spanner_instance_admin.proto
2020-04-21 06:28:29,995 synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-admin-instance-v1/google/cloud/spanner_admin_instance_v1/proto.
2020-04-21 06:28:30,000 synthtool > Replaced "'google-cloud-spanner-admin-instance'" in google/cloud/spanner_admin_instance_v1/gapic/instance_admin_client.py.
2020-04-21 06:28:30,004 synthtool > Replaced 'from google\\.cloud\\.spanner\\.admin\\.instance_v1.proto' in google/cloud/spanner_admin_instance_v1/proto/spanner_instance_admin_pb2_grpc.py.
2020-04-21 06:28:30,009 synthtool > Replaced '====*' in google/cloud/spanner_v1/proto/transaction_pb2.py.
2020-04-21 06:28:30,010 synthtool > Replaced '----*' in google/cloud/spanner_v1/proto/transaction_pb2.py.
2020-04-21 06:28:30,010 synthtool > Replaced '~~~~*' in google/cloud/spanner_v1/proto/transaction_pb2.py.
2020-04-21 06:28:30,010 synthtool > Running generator for google/spanner/admin/database/artman_spanner_admin_database.yaml.
2020-04-21 06:28:48,880 synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-admin-database-v1.
2020-04-21 06:28:48,881 synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/admin/database/v1/common.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-admin-database-v1/google/cloud/spanner_admin_database_v1/proto/common.proto
2020-04-21 06:28:48,881 synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/admin/database/v1/backup.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-admin-database-v1/google/cloud/spanner_admin_database_v1/proto/backup.proto
2020-04-21 06:28:48,882 synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/spanner/admin/database/v1/spanner_database_admin.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-admin-database-v1/google/cloud/spanner_admin_database_v1/proto/spanner_database_admin.proto
2020-04-21 06:28:48,882 synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/spanner-admin-database-v1/google/cloud/spanner_admin_database_v1/proto.
2020-04-21 06:28:48,890 synthtool > Replaced "'google-cloud-spanner-admin-database'" in google/cloud/spanner_admin_database_v1/gapic/database_admin_client.py.
2020-04-21 06:28:48,892 synthtool > Replaced 'from google\\.cloud\\.spanner\\.admin\\.database_v1.proto' in google/cloud/spanner_admin_database_v1/proto/backup_pb2.py.
2020-04-21 06:28:48,893 synthtool > Replaced 'from google\\.cloud\\.spanner\\.admin\\.database_v1.proto' in google/cloud/spanner_admin_database_v1/proto/spanner_database_admin_pb2_grpc.py.
2020-04-21 06:28:48,893 synthtool > Replaced 'from google\\.cloud\\.spanner\\.admin\\.database_v1.proto' in google/cloud/spanner_admin_database_v1/proto/spanner_database_admin_pb2.py.
2020-04-21 06:28:48,899 synthtool > Replaced '"""Attributes:' in google/cloud/spanner_admin_instance_v1/proto/spanner_instance_admin_pb2.py.
2020-04-21 06:28:48,900 synthtool > Replaced 'cloud.spanner_admin_instance_v1.types._OperationFuture' in google/cloud/spanner_admin_instance_v1/gapic/instance_admin_client.py.
2020-04-21 06:28:48,901 synthtool > Replaced 'cloud.spanner_admin_database_v1.types._OperationFuture' in google/cloud/spanner_admin_database_v1/gapic/database_admin_client.py.
.coveragerc
.flake8
.github/CONTRIBUTING.md
.github/ISSUE_TEMPLATE/bug_report.md
.github/ISSUE_TEMPLATE/feature_request.md
.github/ISSUE_TEMPLATE/support_request.md
.github/PULL_REQUEST_TEMPLATE.md
.github/release-please.yml
.gitignore
.kokoro/build.sh
.kokoro/continuous/common.cfg
.kokoro/continuous/continuous.cfg
.kokoro/docs/common.cfg
.kokoro/docs/docs.cfg
.kokoro/presubmit/common.cfg
.kokoro/presubmit/presubmit.cfg
.kokoro/publish-docs.sh
.kokoro/release.sh
.kokoro/release/common.cfg
.kokoro/release/release.cfg
.kokoro/trampoline.sh
CODE_OF_CONDUCT.md
CONTRIBUTING.rst
LICENSE
MANIFEST.in
docs/_static/custom.css
docs/_templates/layout.html
docs/conf.py.j2
noxfile.py.j2
renovate.json
setup.cfg
2020-04-21 06:28:48,986 synthtool > Replaced 'include README.rst LICENSE\n' in MANIFEST.in.
Running session blacken
Creating virtual environment (virtualenv) using python3.6 in .nox/blacken
pip install black==19.3b0
black docs google tests noxfile.py setup.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_admin_database_v1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/docs/conf.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_admin_database_v1/gapic/database_admin_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_admin_database_v1/proto/backup_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_admin_database_v1/gapic/transports/database_admin_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_admin_database_v1/proto/common_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_admin_database_v1/proto/common_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_admin_database_v1/proto/spanner_database_admin_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_admin_instance_v1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_admin_database_v1/gapic/database_admin_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_admin_instance_v1/gapic/instance_admin_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_admin_instance_v1/gapic/transports/instance_admin_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_admin_database_v1/proto/backup_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_admin_instance_v1/gapic/instance_admin_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_admin_instance_v1/proto/spanner_instance_admin_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_v1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_v1/gapic/spanner_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_v1/gapic/transports/spanner_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_admin_database_v1/proto/spanner_database_admin_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_v1/proto/keys_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_v1/proto/keys_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_v1/proto/mutation_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_v1/gapic/spanner_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_v1/proto/query_plan_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_v1/proto/mutation_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_v1/proto/result_set_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_admin_instance_v1/proto/spanner_instance_admin_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_v1/proto/query_plan_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_v1/proto/result_set_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_v1/proto/transaction_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_v1/proto/spanner_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_v1/proto/type_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_v1/proto/type_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_v1/proto/transaction_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/tests/unit/gapic/v1/test_instance_admin_client_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/tests/unit/gapic/v1/test_database_admin_client_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/tests/unit/gapic/v1/test_spanner_client_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/google/cloud/spanner_v1/proto/spanner_pb2.py
All done! ✨ 🍰 ✨
38 files reformatted, 56 files left unchanged.
Session blacken was successful.
2020-04-21 06:29:01,355 synthtool > Wrote metadata to synth.metadata.

```
</details>
    @yoshi-automation
    yoshi-automation authored Apr 29, 2020
    Configuration menu
    Copy the full SHA
    c8c7723 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2020

  1. refactor: remove deprecated resource based routing support (#73) 

    Co-authored-by: larkee <[email protected]>
    @larkee
    larkee and larkee authored Apr 30, 2020
    Configuration menu
    Copy the full SHA
    df4be7f View commit details
    Browse the repository at this point in the history

Commits on May 4, 2020

  1. feat: add support for retrying aborted partitioned DML statements (#66) 

    * feat: add support for retrying aborted partitioned dml statements

* run blacken

* use retry settings from config

* fix imports from rebase

Co-authored-by: larkee <[email protected]>
    @larkee
    larkee and larkee authored May 4, 2020
    Configuration menu
    Copy the full SHA
    8a3d700 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2020

  1. refactor: PingingPool pings sessions using SELECT 1 (#75) 

    Currently, PingingPool pings sessions in the background by calling `session.exists()` which calls `GetSession`. 

Using `SELECT 1` is preferred and is used in other client libraries such as [Go](https://github.com/googleapis/google-cloud-go/blob/53898305c6f21b3c3eef34fcff6c61a2cb36f602/spanner/session.go#L227):
    @larkee
    larkee authored May 5, 2020
    Configuration menu
    Copy the full SHA
    7a07c2b View commit details
    Browse the repository at this point in the history

  2. tests: add backup integration tests (#69) 

    * tests: add backup integration tests

* use unique instance ids for restore instances

* remove optimization wait and ensure backups are being cleaned up on failures

Co-authored-by: larkee <[email protected]>
    @larkee
    larkee and larkee authored May 5, 2020
    Configuration menu
    Copy the full SHA
    b7739da View commit details
    Browse the repository at this point in the history

  3. chore: release 1.16.0 (#76) 

    * updated CHANGELOG.md [ci skip]

* updated setup.cfg [ci skip]

* updated setup.py [ci skip]

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: larkee <[email protected]>
    @release-please @larkee
    release-please[bot] and larkee authored May 5, 2020
    Configuration menu
    Copy the full SHA
    a34dc91 View commit details
    Browse the repository at this point in the history
Loading