Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ewels
Copy link
Member

@ewels ewels commented Oct 7, 2019

Merging to master for version 1.7 release of nf-core/tools

ewels and others added 30 commits August 9, 2018 12:17
lint fails more gracefully in travis doesn't have before_install
reverse conda env handling (fix for #114)
Corrects some syncing behaviour
Adding BWA and Bowtie2 indices to igenome config template
Fix typo in tools readme
Since PyYAML 5.1, a warning is thrown when yaml.load() is called without a loader argument.
More info:
https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation
Use yaml.safe_load() to silence warning about possible exploit
@ewels ewels requested a review from a team October 7, 2019 13:49
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Press the button!!

@ewels ewels merged commit 2d324b4 into master Oct 7, 2019
@@ -1,7 +1,6 @@
FROM continuumio/miniconda:4.5.4
FROM continuumio/miniconda:4.6.14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FROM continuumio/miniconda:4.6.14
FROM continuumio/miniconda:4.7.10

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we do a release now this will save us lots of time. 4.7.X contains better dependency solving algorithm: https://www.anaconda.com/how-we-made-conda-faster-4-7/

"lncpipe",
"ddamsproteomics",
"scrnaseq",
"guideseq"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"guideseq"
"guideseq",
"nanodemux",
"mnaseseq",
"bactmap",
"kmermaid",
"crisprvar"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.