Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@sven1103
Copy link
Member

@sven1103 sven1103 commented Apr 9, 2019

A bunch of changes to introduce for a new nf-core tools release.

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/tools/tree/master/.github/CONTRIBUTING.md

ewels and others added 30 commits March 13, 2019 23:17
Bump version to v1.6dev
add check for tracefiles in s3 buckets
Drop Rnaseq from blacklist
 Some more tweaks from the final rnaseq template merge
Get the latest release with nf-core download
download: Make unzipped files executable. Fixes #289
@sven1103 sven1103 requested a review from a team April 9, 2019 10:50
Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things to add/change before the release 👍

Copy link
Member Author

@sven1103 sven1103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor thing

@ewels
Copy link
Member

ewels commented Apr 9, 2019

This pull request introduces 1 alert and fixes 1 when merging 95624ed into 1855d34 - view on LGTM.com

new alerts:

  • 1 for Except block handles 'BaseException'

fixed alerts:

  • 1 for Unused local variable

Comment posted by LGTM.com

@sven1103 sven1103 merged commit 4ab80b8 into master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants