Thanks to visit codestin.com
Credit goes to github.com

Skip to content

unblock timeout for power-user select CLI tests #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 5, 2022
Merged

unblock timeout for power-user select CLI tests #985

merged 14 commits into from
May 5, 2022

Conversation

@wagoodman
Copy link
Contributor

@wagoodman wagoodman commented May 3, 2022 •
edited by spiffcs
Loading

The power user secrets CLI tests we're blocking and timing out when trying to access the same fixture contents. Creating a separate secret fixtures directory with different data unblocks the timeout and allows the tests to operate independently of each other.

@wagoodman wagoodman changed the title increase select CLI test verbosity Increase verbosity for select CLI tests May 3, 2022
@github-actions
Copy link

github-actions bot commented May 3, 2022 •
edited
Loading

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.14ms ± 0%    1.18ms ± 3%  +3.71%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            2.88ms ± 1%    3.15ms ± 9%  +9.48%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     933µs ± 1%     948µs ± 1%  +1.69%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         636µs ± 2%     635µs ± 1%    ~     (p=0.690 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     773µs ± 3%     764µs ± 1%    ~     (p=0.548 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      679µs ± 1%     674µs ± 1%    ~     (p=0.056 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      13.5ms ± 1%    13.2ms ± 1%  -1.89%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.19ms ± 1%    1.21ms ± 3%    ~     (p=0.095 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          2.09µs ± 2%    2.11µs ± 1%    ~     (p=0.167 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               184kB ± 0%     184kB ± 0%  -0.18%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             897kB ± 0%     896kB ± 0%    ~     (p=0.151 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     196kB ± 0%     196kB ± 0%    ~     (p=1.000 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         140kB ± 0%     140kB ± 0%    ~     (p=0.056 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     175kB ± 0%     176kB ± 0%    ~     (p=0.056 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      163kB ± 0%     164kB ± 0%    ~     (p=0.310 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.29MB ± 0%    3.29MB ± 0%    ~     (p=0.690 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.24MB ± 0%    1.24MB ± 0%    ~     (p=0.310 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            672B ± 0%      672B ± 0%    ~     (all equal)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               3.66k ± 0%     3.66k ± 0%    ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2             14.8k ± 0%     14.8k ± 0%    ~     (p=0.460 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     4.94k ± 0%     4.94k ± 0%    ~     (p=0.556 n=5+4)
ImagePackageCatalogers/javascript-package-cataloger-2         2.72k ± 0%     2.72k ± 0%    ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     3.95k ± 0%     3.95k ± 0%    ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                      4.02k ± 0%     4.02k ± 0%    ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       52.2k ± 0%     52.2k ± 0%    ~     (p=0.984 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      4.83k ± 0%     4.83k ± 0%    ~     (p=0.556 n=4+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            15.0 ± 0%      15.0 ± 0%    ~     (all equal)

spiffcs added 10 commits May 4, 2022 13:57
@spiffcs
update runCommand to have correct inputs
c64b758 
Signed-off-by: Christopher Phillips <[email protected]>
@spiffcs
does the test running matter here?
9490329 
Signed-off-by: Christopher Phillips <[email protected]>
@spiffcs
remove all poweruser commands
b81b639 
Signed-off-by: Christopher Phillips <[email protected]>
@spiffcs
isolating secret tests
6e20b24 
Signed-off-by: Christopher Phillips <[email protected]>
@spiffcs
add back single secrets test for timeout check
845769a 
Signed-off-by: Christopher Phillips <[email protected]>
@spiffcs
add back results don't reveal
632426d 
Signed-off-by: Christopher Phillips <[email protected]>
@spiffcs
check other SECRETS test for timeout
b420c4e 
Signed-off-by: Christopher Phillips <[email protected]>
@spiffcs
testing separate dir
2fd2d07 
Signed-off-by: Christopher Phillips <[email protected]>
@spiffcs
update separate fixtures
5be5ea8 
Signed-off-by: Christopher Phillips <[email protected]>
@spiffcs
update testing back to less verboce setup
40c5b7d 
Signed-off-by: Christopher Phillips <[email protected]>
@spiffcs spiffcs changed the title Increase verbosity for select CLI tests unblock timeout for power-user select CLI tests May 5, 2022
@spiffcs spiffcs marked this pull request as ready for review May 5, 2022 13:14
kzantow
kzantow reviewed May 5, 2022
View reviewed changes
@spiffcs
remove testing argument
e46ba2b 
Signed-off-by: Christopher Phillips <[email protected]>
@spiffcs spiffcs enabled auto-merge (squash) May 5, 2022 14:12
@spiffcs
no hang on dir
1af70bc 
Signed-off-by: Christopher Phillips <[email protected]>
@spiffcs spiffcs merged commit d2f053b into main May 5, 2022
@spiffcs spiffcs deleted the cli-hang branch May 5, 2022 15:12
spiffcs added a commit that referenced this pull request May 6, 2022
@spiffcs
Merge branch 'main' into 835-keyless-attestation-upgrade
e43e426 
* main:
  feat: add initial dotnet-support (#951)
  unblock timeout for power-user select CLI tests (#985)
  golang cataloger - main module version as is (#986)
  Fix `github-json` output option (#967)
  read Go main module version as is - (devel) (#981)
  reduce logging severity for non-Go binaries (#983)
  golang.org/x/crypto upgrade (#979)
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@wagoodman
unblock timeout for power-user select CLI tests (anchore#985)
231bed9 
* update to use shared secretsFixture to prevent race

Signed-off-by: Christopher Phillips <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spiffcs spiffcs spiffcs left review comments

@kzantow kzantow kzantow approved these changes

+1 more reviewer

@luhring luhring luhring approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wagoodman @kzantow @luhring @spiffcs