Bug 1920300: Allow stream timeout to be set from config #4529

wgahnagl · 2021-02-01T15:15:38Z

What type of PR is this?

/kind api-change
/kind bug
/kind ci
/kind cleanup
/kind dependency-change
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

allows the stream timeout to be set by config

Which issue(s) this PR fixes:

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1920300

Special notes for your reviewer:

Does this PR introduce a user-facing change?

allows users to set stream timeout from config

allows users to set stream timeout from config

openshift-ci-robot · 2021-02-01T15:15:46Z

Hi @wgahnagl. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

internal/criocli/criocli.go

haircommander · 2021-02-01T15:21:39Z

/ok-to-test

codecov · 2021-02-01T15:51:09Z

Codecov Report

Merging #4529 (6f096c5) into master (c75afa5) will increase coverage by 0.00%.
The diff coverage is 41.66%.

@@           Coverage Diff           @@
##           master    #4529   +/-   ##
=======================================
  Coverage   40.18%   40.18%           
=======================================
  Files         115      115           
  Lines        9327     9339   +12     
=======================================
+ Hits         3748     3753    +5     
- Misses       5161     5168    +7     
  Partials      418      418

mrunalp · 2021-02-01T16:45:06Z

docs/crio.8.md

 **--root, -r**="": The CRI-O root directory (default: /var/lib/containers/storage)

-**--runroot**="": The CRI-O state directory (default: /run/containers/storage)
+**--runroot**="": The CRI-O state directory (default: /var/run/containers/storage)


The changes in the file that aren't related to stream-idle-timeout should be dropped.

saschagrunert

Just one nit, otherwise LGTM

saschagrunert · 2021-02-02T08:12:11Z

server/server.go

+	if config.StreamIdleTimeout != "" {
+		idleTimeout, err := time.ParseDuration(config.StreamIdleTimeout)
+		if err != nil {
+			return nil, fmt.Errorf("unable to parse timeout as duration")


There is no format included and we'd like to stick to the github.com/pkg/errors package rather than fmt:

Suggested change

return nil, fmt.Errorf("unable to parse timeout as duration")

return nil, errors.New("unable to parse timeout as duration")

openshift-ci-robot · 2021-02-02T08:12:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, wgahnagl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mrunalp · 2021-02-02T20:58:33Z

We need to default this value to 15 minutes to follow security standards. Ref: https://vlab.ncep.noaa.gov/documents/179645/414991/FedRAMP-Rev-4-Baseline-Workbook-FINAL062014.xlsx/1d5c4681-edbe-4878-8797-de1f201b318c?version=1.0&targetExtension=pdf

wgahnagl · 2021-02-03T15:47:37Z

/retest

Signed-off-by: Skyler Clark <[email protected]>

wgahnagl · 2021-02-03T18:04:38Z

/retest

wgahnagl · 2021-02-03T19:20:27Z

/retest

wgahnagl · 2021-02-04T14:02:55Z

/retest

wgahnagl · 2021-02-08T20:51:44Z

/retest

wgahnagl · 2021-02-09T14:02:10Z

/retest

wgahnagl · 2021-02-09T19:08:04Z

/retest

haircommander · 2021-02-09T20:49:25Z

/lgtm

openshift-ci · 2021-02-09T20:50:06Z

@wgahnagl: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp	`6f096c5`	link	`/test e2e-gcp`
ci/prow/e2e-agnostic	`6f096c5`	link	`/test e2e-agnostic`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

wgahnagl requested review from mrunalp and runcom as code owners February 1, 2021 15:15

openshift-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Feb 1, 2021

openshift-ci-robot requested a review from sboeuf February 1, 2021 15:15

openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 1, 2021

wgahnagl force-pushed the idletimeout branch from 3c8576e to 5f76151 Compare February 1, 2021 15:20

openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Feb 1, 2021

haircommander reviewed Feb 1, 2021

View reviewed changes

internal/criocli/criocli.go Outdated Show resolved Hide resolved

openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 1, 2021

wgahnagl force-pushed the idletimeout branch from 5f76151 to 565c6af Compare February 1, 2021 15:36

mrunalp reviewed Feb 1, 2021

View reviewed changes

mrunalp changed the title ~~allows stream timeout to be set from config~~ Bug 1920300: allows stream timeout to be set from config Feb 1, 2021

mrunalp changed the title ~~Bug 1920300: allows stream timeout to be set from config~~ Bug 1920300: Allow stream timeout to be set from config Feb 1, 2021

wgahnagl force-pushed the idletimeout branch 2 times, most recently from d0488d3 to 6b888af Compare February 1, 2021 18:28

openshift-ci-robot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 1, 2021

wgahnagl force-pushed the idletimeout branch from 67a7c24 to 1a17a7a Compare February 1, 2021 18:55

openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Feb 1, 2021

wgahnagl force-pushed the idletimeout branch 2 times, most recently from aa9b20f to 7b74edc Compare February 1, 2021 19:09

saschagrunert approved these changes Feb 2, 2021

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2021

wgahnagl force-pushed the idletimeout branch 7 times, most recently from 8674ad2 to 7738b39 Compare February 2, 2021 20:26

allows stream timeout to be set from config

6f096c5

Signed-off-by: Skyler Clark <[email protected]>

wgahnagl force-pushed the idletimeout branch from 7738b39 to 6f096c5 Compare February 3, 2021 16:41

openshift-ci-robot assigned haircommander Feb 9, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2021

openshift-merge-robot merged commit 7f6ccb5 into cri-o:master Feb 9, 2021

This was referenced Feb 12, 2021

[release-1.18] backports session timeout fix from 1.21 to 1.18 #4562

Merged

[release-1.19] backports session timeout fix from 1.21 to 1.19 #4564

Merged

[release-1.20] backports session timeout fix from 1.21 to 1.20 #4565

Merged

haircommander mentioned this pull request Mar 8, 2021

Support configurable idle timeout for streaming server #4515

Closed

wgahnagl mentioned this pull request Feb 15, 2022

REQUEST: New membership for wgahnagl #5649

Closed

4 tasks

	return nil, fmt.Errorf("unable to parse timeout as duration")
	return nil, errors.New("unable to parse timeout as duration")

Bug 1920300: Allow stream timeout to be set from config #4529

Bug 1920300: Allow stream timeout to be set from config #4529

Uh oh!

Conversation

wgahnagl commented Feb 1, 2021

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

openshift-ci-robot commented Feb 1, 2021

Uh oh!

Uh oh!

haircommander commented Feb 1, 2021

Uh oh!

codecov bot commented Feb 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mrunalp Feb 1, 2021

Choose a reason for hiding this comment

Uh oh!

saschagrunert left a comment

Choose a reason for hiding this comment

Uh oh!

saschagrunert Feb 2, 2021

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Feb 2, 2021

Uh oh!

mrunalp commented Feb 2, 2021

Uh oh!

wgahnagl commented Feb 3, 2021

Uh oh!

wgahnagl commented Feb 3, 2021

Uh oh!

wgahnagl commented Feb 3, 2021

Uh oh!

wgahnagl commented Feb 4, 2021

Uh oh!

wgahnagl commented Feb 8, 2021

Uh oh!

wgahnagl commented Feb 9, 2021

Uh oh!

wgahnagl commented Feb 9, 2021

Uh oh!

haircommander commented Feb 9, 2021

Uh oh!

openshift-ci bot commented Feb 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Feb 1, 2021 •

edited

Loading