[1.22] prepend commands with taskset if InfraCtrCPUSet is configured #5546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The quantile has to be added manually since a couple of prometheus client releases and we missed that. Adding an integration test to ensure that the quantile exist in the future. Signed-off-by: Sascha Grunert <[email protected]>
…pick-5258-to-release-1.22 [release-1.22] Fix missing quantile in `latency_microseconds_total` metrics
if we fail to move conmon to a cgroup, we still need to call Wait() on the process, or else we will leak a child Signed-off-by: Peter Hunt <[email protected]>
or else we will leak a pid Signed-off-by: Peter Hunt <[email protected]>
…pick-5283-to-release-1.22 [release-1.22] oci: call wait on conmon if cgroup move fails
This reduces the noise on systems not having Intel RDT enabled. Signed-off-by: Sascha Grunert <[email protected]>
…pick-5293-to-release-1.22 [release-1.22] Do not log on startup if Intel RDT is not supported
If we haven't signaled on the stop pipe, then conmon will be sitting waiting to be told to start Instead, we need to kill the process. Signed-off-by: Peter Hunt <[email protected]>
…pick-5306-to-release-1.22 [release-1.22] server: do not wait forever on conmon cgroup move fail
Signed-off-by: Peter Hunt <[email protected]>
…pick-5313-to-release-1.22 [release-1.22] server: set spec when dropping infra
Signed-off-by: Peter Hunt <[email protected]>
to remain consistent with other times it's specified Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
…pick-5244-to-release-1.22 [release-1.22] server: fix some hostNet handling in container creation
Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
RHEL/CentOS 7's container-selinux package replaces container_file_t with svirt_sandbox_file_t under the hood. This causes the annotation to not work correctly. Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
If a container or pod specifies the SELinux type `spc_t`, then we skip the volume relabel. Signed-off-by: Sascha Grunert <[email protected]>
[1.22] server: conditionally relabel volumes given annotation
Fix https://bugzilla.redhat.com/show_bug.cgi?id=2012838 Merge in the storage_option from drop-in crio.conf to the storage.conf, do not override the configs from storage.conf. The override leads to configuration of containerruntimeconfig not working. Signed-off-by: Qi Wang <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
[1.22] bump to 1.22.1
Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
…pick-5445-to-release-1.22 [release-1.22] release-notes: update to main
…pick-5423-to-release-1.22 [release-1.22] Bug 2020729: fix override storage options from storage.conf
[1.22] oci: fix a couple of deadlocks in container stop code
Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
[1.22] workloads: fix if resources are empty
…pick-5336-to-release-1.22 [release-1.22] server: close namespaces on sandbox stop
Even if we kill the process, we still need to wait for it, or else we'll reap a zombie. Signed-off-by: Peter Hunt <[email protected]>
…pick-5500-to-release-1.22 [release-1.22] oci: always reap conmon zombies
Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
Contributor
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
@haircommander: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
|
@haircommander: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
If InfraCtrCPUSet is configured, then there is an expectation that all commands land on certain CPUs. However, this isn't always the case. Thus, we need a way of spawning commands given a list of CPUs.
To do this, update cmdrunner to be a singleton object that stores an optional command and args to prepend to commands. Then use this singleton anytime exec.Command would be called.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?