Add column_index to TimetableEntry
#6991
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* disallow shrinking more than child elements * disable selection on drag * unbehead changed files * unbehead all timetable files
* Use event's time boundaries * Apply suggestions and code improvements * minHour-- --------- Co-authored-by: Tomas R. <[email protected]>
Co-authored-by: Duarte Galvão <[email protected]>
We alrady store column & maxColumn from the CSS width and left offset can be easily computed when needed.
* resize by dragging * open create contrib modal * initial modification and usage of custom contrib modal * basic dialogues * fixed sizing issue and startdate * escape to cancel new entry * add default startdate * fix date error * rm redundant code and keep date when switching forms * extract sessionform logic * functional data passage between forms * session block and session in one form * colored sessions selector * support multiple forms and pass data to back-end * functional sessionblock create * contrib creation * add from backend data to redux * rm unwanted recommendation in extensions * session color picker to tsx * draft of cleaner entry creation * better entry response formatting * prepare edit functionalities * fix creation timezone issue, add color to break, etc * disable sessioblock creation when no session * rm consolelog * enable submitting again * Mapping to person links data * clean up and allow person links for sessionblock and contribution * rm obsolete code and fix title issue for session blocks * limit date choice and fix focusbutton nullpointer * cleanup and going through todos * fix lint issues * moved personlinks mapping fn and fixed bug in contrib form * rm optional chaining in favour of linter * fix ruff errors * minor pr comments * cleanup and fix date issues * unbehead * isort schemas file
* replaced state management for edit * clean up popup (dry), bugfixes, made create modal fit editing * refactoring, remove wet * fix person links * fix users addition to sessionblocks and contribs * post-rebase changes * merge entry components * fix double tooltip * Disable right click where unnecessary * cleanup entry.tsx * pass previously ignored fields for contrib on creation * additional fields sessionblock * break additional * Board number and program code visible again in edit * new serializer * pass avatarUrl * cleanup of modal * fetch entry data on edit and fix creation * fix location data, draft * rm console logs * process_PATCH marshmallow progress * passing patch without saving to db * functional contrib patch * functional load data on click for contrib * functional edit of contrib * functional edit with state update * break get and patch * functional edit dialogues opening * creation from timetable functional again * cleanup and fixed description entry in breakform * edit working without person links, creation still has person links * isort * edit right after creation without crash * fix colors and location fields * remove prints and logs * fix ruff issues * more ruff * adrian comments * using rh_args decorator instead of experimental * remove unnecessary, cleanup and make independent forms functional * isort schemas.py * rm unnecessary classes * clean-up * rm unintended newline * rm unintentional additional field to session schema * child ids working noiw * fix same-id bug * rm unused * rm unused partial flags * tomas comments pr
* real data in entrypopup * make code more readable and remove redundant things * cleanup serializer
This reverts commit bd8519a.
* make serializer more readable, add uniqueid, remove redundant code * separated uniqueID and objectID * rm unused id props * fix unscheduled ids and move modified legacy event serializer to new * fix child type being passed on edit
* Implement entry deletion feature * fix delete function * Change icon for contributions * Add tooltip & button color * Fix actions request * Fix actions form ajobs comments * fix imports and variable names * remove redundant error handling * remove try catch
* real data in entrypopup * make code more readable and remove redundant things * cleanup serializer * cleanup of interfaces, fixed crashing dialogue and translated strings * fixed merge conflict * semantic issue in mapping fn * show child info * move locationparent interface * fix child data * interfaces and attachments showing for children * make personLinks non optional
* Make prettier happy & reformat code * Remove extra onclick
* change refresh rate and speed * mv const pos
* Disable mouseenter for toolbar day selector * Disable scroll when mouse is outside scrollable area * Clamp values instead of disabling scroll
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One improvement in the new timetable is the ability to have a stable and predictable order when there are multiple parallel entries (there is currently a workaround for sorting session blocks using program codes).
In the new timetable you can choose any order you want simply by rearranging the entries. This however requires storing the order of the entries - hence this PR which adds the
column_indexto timetable entries. Thecolumn_indexis used to sort the entries.I still need to think about how to make sure existing events will be displayed correctly once we start using the index.