feat: show dashboard filters button when there are SQL charts #14991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 23, 2025
Merged
ZeRego
changed the title
ZeRego
force-pushed
the
feat_enable_dashboard_filters_for_SQL_charts
branch
from
e8c5f8a to
c2a21d9
Compare
ZeRego
force-pushed
the
refactor_extract_getFilterTypeFromItemType_function
branch
from
06c0f19 to
5e2ca4f
Compare
ZeRego
force-pushed
the
feat_enable_dashboard_filters_for_SQL_charts
branch
from
c2a21d9 to
07555d9
Compare
ZeRego
force-pushed
the
refactor_extract_getFilterTypeFromItemType_function
branch
2 times, most recently
from
6ae17d0 to
d4aaf23
Compare
ZeRego
force-pushed
the
feat_enable_dashboard_filters_for_SQL_charts
branch
2 times, most recently
from
4c5b83d to
83ecdab
Compare
ZeRego
force-pushed
the
refactor_extract_getFilterTypeFromItemType_function
branch
from
d4aaf23 to
79ea36e
Compare
ZeRego
force-pushed
the
feat_enable_dashboard_filters_for_SQL_charts
branch
from
83ecdab to
07c1612
Compare
ZeRego
force-pushed
the
refactor_extract_getFilterTypeFromItemType_function
branch
from
79ea36e to
6ad247d
Compare
Base automatically changed from
refactor_extract_getFilterTypeFromItemType_function
to
main
May 24, 2025 08:23
ZeRego
force-pushed
the
feat_enable_dashboard_filters_for_SQL_charts
branch
from
07c1612 to
caef31c
Compare
magnew
approved these changes
May 25, 2025
lightdash-bot
pushed a commit
that referenced
this pull request
May 25, 2025
# [0.1650.0](0.1649.0...0.1650.0) (2025-05-25) ### Features * enable dashboard filters for SQL charts ([#14991](#14991)) ([e293b92](e293b92))
|
🎉 This PR is included in version 0.1650.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #14969
Description:
This PR enables dashboard filters for SQL charts by introducing a feature flag check for
SqlChartDashboardFilters. The implementation replaces thehasChartTilesproperty with a more descriptivehasTilesThatSupportFiltersthat considers both saved charts and SQL charts (when the feature flag is enabled).The dashboard filter component now renders based on whether there are tiles that support filtering, rather than just checking for the presence of chart tiles.
AI: I've created a pull request description that focuses on the key changes in the diff. The PR introduces a feature flag check for SQL chart dashboard filters and replaces the
hasChartTilesproperty with a more descriptivehasTilesThatSupportFiltersthat considers both saved charts and SQL charts when the feature flag is enabled. The description is concise and explains the purpose of the changes without getting into unnecessary details about file structure or parameter updates.With no tiles:
With markdown tiles:
With tiles of all types (including sql chart)
With SQL chart tiles: (Can't do anything yet besides removing invalid filters)
