Release v2.9.0 #5777
Merged
Release v2.9.0 #5777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Potter <[email protected]>
Signed-off-by: Chris Potter <[email protected]>
Signed-off-by: Chris Potter <[email protected]>
Signed-off-by: Chris Potter <[email protected]>
Signed-off-by: Maria Paktiti <[email protected]>
Signed-off-by: Maria Paktiti <[email protected]>
…uery Signed-off-by: Machiko Yasuda <[email protected]>
Signed-off-by: Machiko Yasuda <[email protected]>
Signed-off-by: Machiko Yasuda <[email protected]>
Signed-off-by: Machiko Yasuda <[email protected]>
Signed-off-by: Machiko Yasuda <[email protected]>
Signed-off-by: Machiko Yasuda <[email protected]>
Signed-off-by: Machiko Yasuda <[email protected]>
Signed-off-by: Maria Paktiti <[email protected]>
Signed-off-by: Maria Paktiti <[email protected]>
Signed-off-by: Maria Paktiti <[email protected]>
Signed-off-by: Maria Paktiti <[email protected]>
Signed-off-by: Maria Paktiti <[email protected]>
Signed-off-by: Maria Paktiti <[email protected]>
…lid params Signed-off-by: Machiko Yasuda <[email protected]>
Signed-off-by: trojanh <[email protected]>
Signed-off-by: trojanh <[email protected]>
Signed-off-by: trojanh <[email protected]>
Signed-off-by: Maria Paktiti <[email protected]>
Signed-off-by: Machiko Yasuda <[email protected]>
Signed-off-by: Machiko Yasuda <[email protected]>
Signed-off-by: Machiko Yasuda <[email protected]>
Signed-off-by: Gary Ryan Vaz <[email protected]>
Signed-off-by: Chris Potter <[email protected]>
Signed-off-by: Machiko Yasuda <[email protected]>
von-steinkirch
previously approved these changes
Nov 1, 2019
rosshadden
previously approved these changes
Nov 1, 2019
Contributor
rosshadden
left a comment
There was a problem hiding this comment.
Looks good, once we figure out what is making the integration tests take a lot longer in this release.
spencern
previously requested changes
Nov 4, 2019
Contributor
spencern
left a comment
There was a problem hiding this comment.
Adding a blocking review - I want to understand what’s causing the significant increase in integration test execution time before we merge this.
Contributor
Author
|
Blocked. Issue to tackle this created here: #5779 (comment) |
* set jest integration test maxWorker flag to 1 * set max node memory consumption for CI container to 4000MB Signed-off-by: Gary Ryan Vaz <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
…dReset fix: password-reset route not working correctly
…-test fix: integration test in circle ci
Bug Fix - Value for the second parameter 'payment' of 'stripeCaptureCharge()' is missing. But its property is accessed in the function body at line 16 of imports/node-app/plugins/marketplace/util/stripeCaptureCharge.js.
Condition 'keywords' is always true because it evaluates to an array. Better to use 'keywords.length' instead.
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
[Fix] Create and Delete navigation item mutations
Signed-off-by: Ross Hadden <[email protected]>
bf94a63
rosshadden
approved these changes
Nov 13, 2019
Contributor
|
Block resolved by #5780. |
manueldelreal
approved these changes
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2.9.0
Reaction v2.9.0 adds integration tests for GraphQL API endpoints, security updates and fixes a fulfillment method bug.
This release is being coordinated with Reaction Platform and is designed to work with
v2.9.0of Reaction Hydra and Example Storefront.Notable changes
Add integration tests and increase
maxWorkersAs a part of the major push to remove the Meteor dependency from the GraphQL API, we've been adding more Jest integration tests with the goal of full integration test coverage for all GraphQL queries and mutations provided by all core and included plugins. In this release, we've added tests for the following GraphQL queries:
shopBySlug,orderByReferenceId,ordersByAccountId,addTagandremoveTag. See test coverage epic here.Fix a fulfillment bug
Refactors the
updateOrderFulfillmentGroupGraphQL mutation to update only the specified group, not all fulfillment groups.Update packages for security vulnerabilities
Bumps @reactioncommerce/data-factory to version 1.0.1 and @reactioncommerce/job-queue to version 1.0.5.
Tests
Security
Refactors & Fixes
Contributors
Thanks to @YuuwakU for contributing to this release! 🎉