Thanks to visit codestin.com
Credit goes to github.com

Skip to content

merge: v2.0 #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wderocco8 merged 51 commits into from
Aug 16, 2024
Merged

merge: v2.0 #89

wderocco8 merged 51 commits into from
Aug 16, 2024

Conversation

@jinyoungbang
Copy link
Contributor

@jinyoungbang jinyoungbang commented Jul 14, 2024 •
edited by wderocco8
Loading

What does this PR do?

Updating staging with some significant changes, but mainly revamped rush analytics/tracking

Type of change

  • Fix: Bug fix (non-breaking change which fixes an issue)
  • Refactor: Any code refactoring
  • Chore: technical debt, workflow improvements
  • Feature: New feature (non-breaking change which adds functionality)
  • Documentation: This change requires a documentation update
  • Merge: Pushing features to an upper envrironment

Tests Performed

Screenshots

Additional Comments

@jinyoungbang jinyoungbang changed the base branch from main to staging July 14, 2024 19:11
@github-actions
Copy link

github-actions bot commented Jul 14, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2034 1505 74% 70% 🟢

New Files

File Coverage Status
chalicelib/api/events_member.py 96% 🟢
chalicelib/api/events_rush.py 94% 🟢
chalicelib/services/EventsMemberService.py 40% 🟢
chalicelib/services/EventsRushService.py 15% 🟢
tests/api/test_events_members.py 100% 🟢
tests/api/test_events_rush.py 100% 🟢
tests/api/test_members.py 100% 🟢
tests/services/test_events_member_service.py 100% 🟢
TOTAL 81% 🟢

Modified Files

File Coverage Status
app.py 100% 🟢
chalicelib/api/accountability.py 62% 🟢
chalicelib/api/applicants.py 100% 🟢
chalicelib/api/insights.py 100% 🟢
chalicelib/api/listings.py 88% 🟢
chalicelib/api/members.py 98% 🟢
chalicelib/modules/mongo.py 25% 🟢
chalicelib/s3.py 41% 🟢
chalicelib/services/AccountabilityService.py 47% 🟢
chalicelib/services/InsightsService.py 94% 🟢
chalicelib/services/ListingService.py 71% 🟢
chalicelib/services/MemberService.py 33% 🟢
chalicelib/utils.py 100% 🟢
tests/api/test_applicants.py 100% 🟢
tests/api/test_insights.py 100% 🟢
tests/api/test_listings.py 100% 🟢
tests/services/test_applicant_service.py 100% 🟢
tests/services/test_insights_service.py 100% 🟢
tests/services/test_listing_service.py 100% 🟢
tests/test_decorators.py 100% 🟢
tests/test_dynamodb.py 100% 🟢
TOTAL 84% 🟢

updated for commit: 0217dbe by action🐍

@jinyoungbang jinyoungbang changed the title Merge pull request #88 from whyphi/fix/add-mongomock-unittests merge: v1.0.7 Jul 14, 2024
wderocco8 added 18 commits July 17, 2024 23:31
@wderocco8
fixed uploading errors for rush event image
aeac99d
@wderocco8
s3 delete_object working + switched to using _id for events (makes …
c2f5b1f 
…life easier)
@wderocco8
modify s3 image working :)
7ebd07a
@wderocco8
fixed documentation for s3 delete
9c43059
@wderocco8
Merge pull request #90 from whyphi/feat/enable-rush-event-cover-image…
b5baa4a 
…-zap

Feat/enable rush event cover image zap
@wderocco8
patched bug not being able to update event
4f2786d
@wderocco8
Merge pull request #91 from whyphi/fix/modify-rush-event-persist
6c8412c 
patched bug not being able to update event
@wderocco8
rush event deletion works properly again
8a095b5
@wderocco8
Revert "rush event deletion works properly again"
d8b83a8 
This reverts commit 8a095b5.

Undo commit to dev/v1.0
@wderocco8
fixed deleting rush event
ee07dbd
@wderocco8
Merge pull request #92 from whyphi/fix/delete-rush-event-bug
9948d73 
fixed deleting rush event
@wderocco8
split events member/rush into two separate services/APIs
443d496
@wderocco8
fixed dictionary unpacking for updating event
7662731
@wderocco8
checkin and delete event fully integrated with new attendees collection
1c751e3
@wderocco8
edited pytest APIs
a3bb047
@wderocco8
refactored events testing
46087fe
@wderocco8
Merge pull request #93 from whyphi/refactor/split-event-service-and-a…
bcd188c 
…uth-flagged-api

Refactor/split event service and split attendees into separate collection
@wderocco8
added functionality to get all events for rush category
04e8c5d
jinyoungbang and others added 24 commits July 25, 2024 17:35
@jinyoungbang
Merge pull request #94 from whyphi/feat/rush_dashboard_ZAP
6a0e81f 
added functionality to get all events for rush category
@wderocco8
re-embedded applicants and fixed checkin bug
baa1ed8
@wderocco8
added recent-old sorting on rush events
1b8e1c8
@wderocco8
added code to check if user has checkedIn to an event
af5e1c8
@wderocco8
switched GET to POST to send email to backend
ee59136
@wderocco8
Merge pull request #95 from whyphi/refactor/applicants-embedded
f4a7523 
Refactor/applicants embedded
@jinyoungbang
feat: implement get member API for user update
a7d6416
@wderocco8
added function to return rush event analytics
0c02bc2
@jinyoungbang
feat: implement update member API
fe45cfd
@jinyoungbang
test: create unit tests for member API
70dea1a
@jinyoungbang
lint: fix lint warnings
255f481
@wderocco8
returned categoryName in API
c416c19
@wderocco8
Merge pull request #98 from whyphi/feat/get-rush-analytics
e6bbc00 
Feat/get rush analytics
@jinyoungbang
Merge pull request #97 from whyphi/fix/ruff-lint
ed37246 
lint: fix lint warnings
@jinyoungbang
Merge pull request #96 from whyphi/feat/family-tree
7b2dac9 
feat: Create Update Member API + Implement Member API unit tests
@jinyoungbang
feat: implement family tree get filter api
3271fe4
@wderocco8
swapped order of decorators in api (need to check auth before handlin…
4cb5535 
…g exceptions --> otherwise user will not get 401 error even if they're unauthenticated)
@wderocco8
adjusted roles to use Roles object
5a649a4
@wderocco8
Merge pull request #100 from whyphi/bug/update-listing-settings
7c67795 
Bug/update listing settings
@jinyoungbang
Merge pull request #99 from whyphi/feat/family-tree
47f62a5 
feat: implement family tree get filter api
@wderocco8
returned list of all events in object
c95cf8c
@wderocco8
adjusted backend to handle flags for hiding code and attendee data
4b9a5db
@wderocco8
updated unit tests
e343ecf
@wderocco8
Merge pull request #101 from whyphi/feat/analytics-detail-view-ZAP
0217dbe 
Feat/analytics detail view zap
@wderocco8 wderocco8 added the breaking change Breaking Changes label Aug 16, 2024
@wderocco8 wderocco8 changed the title merge: v1.0.7 merge: v2.0 Aug 16, 2024
@wderocco8 wderocco8 marked this pull request as ready for review August 16, 2024 01:13
@wderocco8 wderocco8 merged commit f295656 into staging Aug 16, 2024
@jinyoungbang jinyoungbang deleted the dev/v1.0 branch January 21, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking change Breaking Changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jinyoungbang @wderocco8