Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Pavel/ Indices carousel #2737

Merged

Conversation

pavel-latyshou-deriv
Copy link
Contributor

Changes:

  • ...

Type of change

  • Bug fix
  • [ x] New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

niloofar-deriv and others added 30 commits January 11, 2022 19:10
* improve livechat performance

* address comments

Co-authored-by: Suthesan <[email protected]>
* refactoring code of files with answers to help centre to ts

* replaced interface on type
* NikitaK/ Convert contact us page to TS 51832

* changed React.FC on ReactElement

* delete all declared return types for components

* delete file because it realized in later master

* fix code smell - delete comment
* refactoring responsible page to typescript

* fix code smell - delete TODO comment
* convert interm/dbot to TS

* convert love trading file to ts
* Update CFD retail percentage

* Extract loss_percent varibale into a constant
* Chore: added new show component

* Chore: updated new component
* move livechat states to context

* rename setter

* fix code smell

Co-authored-by: Suthesan <[email protected]>
* chore: update packages patch version and fix eslint failures

* chore: update directus source plugin patch version

* chore: update all minor package versions

* chore: update all gatsby packages

* Revert "chore: update all gatsby packages"

This reverts commit f6ea933.

* chore: update svgr major version

* chore: update commander & i18next major version

* chore: update to Gatsby 4

* chore: update sitemap to support Gatsby 4

* chore: update types and typescript related packages major version

* chore: update stylelint related packages major version

* chore: remove unused flags

* chore: update babel styled components major version

* chore: update husky and lint staged major version

* chore: update fresnel major version

* chore: remove comments

* refactor: add quality 100

* fix: og images

* fix: og images

* chore: remove priority from sitemap

* chore: update latest patch versions

* chore: update embla to latest major version

* chore: remove commented lines

* Apply code suggestion

Co-authored-by: Yashim Wong <[email protected]>

Co-authored-by: Sean Ho <[email protected]>
Co-authored-by: Yashim Wong <[email protected]>
* fix: eslint rules

* Trigger lint workflow

* fix: stylelint rules

* fix: stylelint rules

Co-authored-by: Sean Ho <[email protected]>
* Update CFD retail percentage

* Extract loss_percent varibale into a constant
…-com#2382)

* feat:add deriv go navigation components

* feat: style trade navigation dropdown / add is_eu check

* fix: refactor PR remarks

* fix: broad of the trade nav

* feat: add deriv-go footer link

* refactor: place bonary bot nav card / update offset arrow useEffect

Co-authored-by: “Nikita” <“[email protected]”>
* add ts guideline to readme

* fix readme text

* fix typo

* Update documents/typescript-guidelines.md

Co-authored-by: Sean Ho <[email protected]>

Co-authored-by: Sean Ho <[email protected]>
* remove slash from the end of url

* fix typo
* chore: refactor dbanner

* chore: refactor dbanner

* refactored other files. work not complited yet

* end of refactoring, correction by comments

* fix code smells

* code smells refactor

* code smells refactor

* delete all declared return types for components

* keeped consistency in naming. filled the missed type

* also delited no need file which added in late master

* fix code smell - delete TODO comment

* fix is_eu_country

* replaced interface on type

* add {} to is_eu_country

* rename of component to fix code smell

* fix code smells

* rename component

* rename component

* create file with common types. type for meta_attributes
* reset-password to TS

* add deleted file

* remove duplication to fix sonarcloud error

* Update src/pages/reset-password/index.tsx

Co-authored-by: Yashim Wong <[email protected]>

* Update src/pages/reset-password/index.tsx

Co-authored-by: Yashim Wong <[email protected]>

* add values type

* fix error-type

* update errortype with partial

Co-authored-by: Yashim Wong <[email protected]>
* convert Trade Types page to Typescript

* handle code smell

* fixed build error

* --
* convert signup and landing-signup to TS

* trigger vercel
* working on converting Dtrader page to TS

* convert DTrader page to TS

* fixed code smell

* address PR comment

* address PR comment

* Address Pr comments
* Convert Terms & Conditions page to TS

* Adding space
…binary-com#2494)

* generalize academy and general footer into a single footer

* improve props naming

Co-authored-by: Sean Ho <[email protected]>
* feat: add preact and update needed dependencies

* feat: add preact aliases to webpack and tsconfig

* feat: use embla-carousel-react package

* fix: fix dependencies

* fix: regenerate package-lock

* feat: add postcss 8 since it's a vercel needed dep

* chore/ import ImageDataLike using type keyword

* chore/ implement proptypes

* fix/ fix not render problem imgs with 100% width

* fix/ fix transform nav button styles

* fix/ remove icons alts

* chore/ add comment

* chore/ change ref api usage since preact plugin update

Co-authored-by: Sean Ho <[email protected]>
* added deriv.be to supported domains along with an app ID

* added domain to whitelist

* using constant variables for app ID

* resolved deriv-app ID confusion
mohammad-hashemi-deriv and others added 17 commits February 23, 2022 14:54
* apply all changes according to Asset gaps pdf. only icons remained.

* add: all svg icons and update accoring files

* update eu changes

* update: uk assets information

* add UKEU component to visibility

* minify svgs

* fix: UK version problems

* fix: few bugs on EU version

* fix: remove cryptocurrency tab in uk market

* update symbols and add EU crypto items

* fix nzd-cad icon and remove micro-pairs from UK

* remove commodities options from UK

* add forex to noneu and nonuk

* separate cfds minor pairs from options minor pairs

* remove synthetic and crypto from uk

* remove synthetic indices and cryptocurrency from off-convas-menu and navbar

* merge eu uk forex cfds since the are the same

* add crypto-pairs icons to svg foler

* add import and export for all added crypto pairs icons in symbols.js

* add all crypto pairs icons to the site

* minify all crypto pair svgs

* add ava-usd and ter-usd to cryptocurrency

* remove crypto and synthetic from footer and other-markets in uk version

* rearrange all market names alphabetically

* rename cryptocurrency to crypto pairs in cfd trading

* remove synthetic indices from trade-types-multiplier page in uk version

* remove duplicate cad-chf from forex minor pairs and replace chf-jpy

* add uk_markets array to othermarkets

* remove navigate-replace from crypto and synthetic page in uk version

* cleaner map in _energy.js and use desktop and mobile component instead of show in _synthetic-indices.tsx

* minify svgs

* fix: space between other markets cards in UK version

* fix: unresovled conflicts which didn't allow project to run

* revert: remove image-not-available.png

* fix: update assets description

* fix: incorrect asset added to Options synthetic indices.

* fix: duplicate instruments on row forex page

* fix: empty energy list in comodities

* fix: add 300 ticks to crash boom row description

* fix: in uk remove synthetic indices from description

* fix: remove synthetic indices from trade-types page available markets

* fix: remove duplicate 'and' words

* fix: replace germany 30 by germany 40 in description

* fix: remove everything according to germany 30

* fix: remove synthetic indices and crypto from uk available markets

* refactor: hardcoded available markets component to dynamic components

* fix: other carousel issues after previous changes

* trigger vercel

* remove cr crash-boom 300

* feat: remove jump indices from eu and add metals for eu

* remove oil/usd from cr

* style: add 2px x-padding for volatility indices

* fix: markets tab scroll offset in mobile uk

* fix: add crash boom 300 to cr

* fix: bring back oil/usd to energy cr

* fix: remove crash boom from multipliers taab

* fix: energy under cfds tab and options tab are different now

* feat: add xalusd xcuusd xniusd xpbusd xznusd to metals

* fix: zinc typo

* fix: remove 5 metals from options

* fix: update crash/boom

* fix: now metal cfds are the same in all regions

* fix: volatility 200, 300 icon in eu region

* fix: trade-types multiplier crash boom description in cr

* fix: typo in crash boom description

* fix: update crash boom 300 icon and remove old icons from src

* fix: remove 200s 300s from countinous indices description

* chore: add crash boom 300 to CR

* fix: crash boom in cfds is now different than multipliers

* fix: remove crash boom 300 from trade-types/multiplier page

* fix: crash boom in eu trader tools shows 300 now

* fix: rename airbnb to airbnb inc

* chore: update graphql.types.ts

* fix: update other stock names

* fix: stocks order by alphabet

* chore: refactor to use the latest features of visibility.tsx
* use new show component

* remove unused codes

Co-authored-by: Suthesan <[email protected]>
Co-authored-by: Sean Ho <[email protected]>
* Revert "chore: update minor versions + fix failed build due to packagelock dependency (binary-com#2678)"

This reverts commit 52916ee.

* reverts 52916ee 7f5ab36

Co-authored-by: Sean Ho <[email protected]>
…d "zh-cn" language (binary-com#2657)

* fix  broken terms and condition link for zh-tw and zh-cn language

* .

* add some exceptions

* code improvement

* remove supported-domains
* apply all changes according to Asset gaps pdf. only icons remained.

* add: all svg icons and update accoring files

* update eu changes

* update: uk assets information

* add UKEU component to visibility

* minify svgs

* fix: UK version problems

* fix: few bugs on EU version

* fix: remove cryptocurrency tab in uk market

* update symbols and add EU crypto items

* fix nzd-cad icon and remove micro-pairs from UK

* remove commodities options from UK

* add forex to noneu and nonuk

* separate cfds minor pairs from options minor pairs

* remove synthetic and crypto from uk

* remove synthetic indices and cryptocurrency from off-convas-menu and navbar

* merge eu uk forex cfds since the are the same

* add crypto-pairs icons to svg foler

* add import and export for all added crypto pairs icons in symbols.js

* add all crypto pairs icons to the site

* minify all crypto pair svgs

* add ava-usd and ter-usd to cryptocurrency

* remove crypto and synthetic from footer and other-markets in uk version

* rearrange all market names alphabetically

* rename cryptocurrency to crypto pairs in cfd trading

* remove synthetic indices from trade-types-multiplier page in uk version

* remove duplicate cad-chf from forex minor pairs and replace chf-jpy

* add uk_markets array to othermarkets

* remove navigate-replace from crypto and synthetic page in uk version

* cleaner map in _energy.js and use desktop and mobile component instead of show in _synthetic-indices.tsx

* minify svgs

* fix: space between other markets cards in UK version

* fix: unresovled conflicts which didn't allow project to run

* revert: remove image-not-available.png

* fix: update assets description

* fix: incorrect asset added to Options synthetic indices.

* fix: duplicate instruments on row forex page

* fix: empty energy list in comodities

* fix: add 300 ticks to crash boom row description

* fix: in uk remove synthetic indices from description

* fix: remove synthetic indices from trade-types page available markets

* fix: remove duplicate 'and' words

* fix: replace germany 30 by germany 40 in description

* fix: remove everything according to germany 30

* fix: remove synthetic indices and crypto from uk available markets

* refactor: hardcoded available markets component to dynamic components

* fix: other carousel issues after previous changes

* trigger vercel

* remove cr crash-boom 300

* feat: remove jump indices from eu and add metals for eu

* remove oil/usd from cr

* style: add 2px x-padding for volatility indices

* fix: markets tab scroll offset in mobile uk

* fix: add crash boom 300 to cr

* fix: bring back oil/usd to energy cr

* fix: remove crash boom from multipliers taab

* fix: energy under cfds tab and options tab are different now

* feat: add xalusd xcuusd xniusd xpbusd xznusd to metals

* fix: zinc typo

* fix: remove 5 metals from options

* fix: update crash/boom

* fix: now metal cfds are the same in all regions

* fix: volatility 200, 300 icon in eu region

* fix: trade-types multiplier crash boom description in cr

* fix: typo in crash boom description

* fix: update crash boom 300 icon and remove old icons from src

* fix: remove 200s 300s from countinous indices description

* chore: add crash boom 300 to CR

* fix: crash boom in cfds is now different than multipliers

* fix: remove crash boom 300 from trade-types/multiplier page

* fix: crash boom in eu trader tools shows 300 now

* fix: rename airbnb to airbnb inc

* chore: update graphql.types.ts

* fix: update other stock names

* fix: stocks order by alphabet

* chore: refactor to use the latest features of visibility.tsx

* chore: remove package-lock.json

* chore: replace new package-lock.json

* chore: replace the original package-lock.json from deriv-com/master

* chore: update graphql.types

* chore: update graphql.types again
* fix hotfixes

* fix ocmments
@vercel
Copy link

vercel bot commented Mar 9, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-com/E6a4ndxzBoxVoXW6BAdgERMZ1QYp
✅ Preview: https://deriv-com-git-fork-pavel-latyshou-deriv-indices-carousel.binary.sx

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.5% 3.5% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 45
🟢 Accessibility 98
🟢 Best practices 93
🟢 SEO 92
🟠 PWA 75

Lighthouse ran on https://deriv-com-git-fork-pavel-latyshou-deriv-indices-carousel.binary.sx/

@habib-deriv habib-deriv merged commit e2d0ade into binary-com:indices-crowdin Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.