Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat!: remove the Tasks API from coderd and codersdk - #28789

Merged
ibetitsmike merged 3 commits into
mainfrom
mike/remove-tasks-api
Sep 11, 2026
Merged

feat!: remove the Tasks API from coderd and codersdk#28789
ibetitsmike merged 3 commits into
mainfrom
mike/remove-tasks-api

Conversation

@ibetitsmike

@ibetitsmike ibetitsmike commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Removes the Tasks API and task orchestration from coderd and codersdk: the /api/v2/tasks handlers, task middleware and search filters, task name generation, autobuild pause/resume logic, task notification enqueues, telemetry, and the codersdk task types. Regenerates apidoc, the API reference docs, and typesGenerated.ts.

Breaking change: the Tasks API is removed; requests to /api/v2/tasks fail. Tasks was deprecated in v2.34.

Stack context: Coder Tasks removal stack (CODAGT-642): #28743 frontend → #28788 CLI → #28789 API → #28790 provisioner → #29084 notifications → #29085 build reasons → #29086 tables → #28750 permissions. The last four PRs replace the single data-drop migration that used to live in #28750; each carries one concern and its own migration number.

Why: with the UI (#28743) and CLI (#28788) gone, this deletes the server surface. Database tables, RBAC, and notification templates stay until the top of the stack so every layer builds and migrates independently.

What to scrutinize:

  • The enable-ai-tasks option is removed outright (review feedback): configs still carrying enableAITasks fail to parse until the key is deleted.
  • provisionerdserver now writes HasAITask: false on template/build flags; the column and these lines are dropped in feat!: remove has_ai_task and the task build reasons #29085.
  • codersdk.ResourceTypeTask stays so audit logs recorded before the removal keep rendering.

Validation: go build ./..., go vet ./..., go test ./codersdk/..., site biome and tsc, CLI goldens regenerated, pre-commit hooks.

Size: +242/-10,792 over 76 files; additions are regenerated docs/goldens and test fixture updates.

Created by Xum (AI agent) on behalf of @ibetitsmike.

@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Docs preview

Check off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-01T00:42:59.095563Z 289cef8 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: df49870f1c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread site/src/utils/workspace.tsx
Comment thread coderd/audit/diff.go
Comment thread site/src/testHelpers/entities.ts
@ibetitsmike
ibetitsmike force-pushed the mike/remove-tasks-api branch from df49870 to 446acdc Compare August 31, 2026 21:30

@aslilac aslilac left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

90% there, just a couple things we should clear up

Comment thread coderd/users_test.go
Comment thread codersdk/deployment_test.go Outdated
Comment thread scripts/apidocgen/postprocess/main.go Outdated
Comment thread site/src/pages/AuditPage/AuditLogRow/AuditLogRow.stories.tsx
@ibetitsmike

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 66931e5c58

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread coderd/apidoc/swagger.json
Comment thread docs/ai-coder/agents/tasks-to-chats-migration.md Outdated
@ibetitsmike
ibetitsmike force-pushed the mike/remove-tasks-api branch from 66931e5 to a40060e Compare August 31, 2026 23:29
@ibetitsmike

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: a40060e83c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ibetitsmike
ibetitsmike force-pushed the mike/remove-tasks-api branch from a40060e to f233977 Compare August 31, 2026 23:53
@ibetitsmike

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f233977b72

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/ai-coder/agents/tasks-to-chats-migration.md Outdated
@ibetitsmike
ibetitsmike force-pushed the mike/remove-tasks-api branch from f233977 to fce4303 Compare September 1, 2026 00:27
@ibetitsmike

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: fce43031bc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ibetitsmike
ibetitsmike force-pushed the mike/remove-tasks-api branch from fce4303 to 289cef8 Compare September 1, 2026 00:38
@ibetitsmike

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 289cef8d63

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@johnstcn johnstcn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock. IMO this is best tested on dogfood but as this has no database-level changes it should be safe to revert if needed.

@johnstcn
johnstcn self-requested a review September 8, 2026 07:56

@aslilac aslilac left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple last things to address, but then looks good

Comment thread site/src/pages/AuditPage/AuditLogRow/AuditLogRow.stories.tsx Outdated
Comment thread site/src/pages/AuditPage/AuditLogRow/AuditLogRow.stories.tsx Outdated
Comment thread site/src/utils/workspace.tsx Outdated
Base automatically changed from mike/remove-tasks-cli to main September 10, 2026 22:51
ibetitsmike added a commit that referenced this pull request Sep 10, 2026
Removes every in-repo Tasks client: the `coder exp tasks` CLI command
family, the tasks scaletest runner, and the task-driven triage
automation (`traiage.yaml`, `code-review.yaml`,
`classify-issue-severity.yml`, `scripts/traiage.sh`). Triage runs
through `triage-via-chat-api.yaml` and coder/create-agent-chat-action
instead.

**Stack context:** Coder Tasks removal stack (CODAGT-642): #28743
frontend → #28788 CLI → #28789 API → #28790 provisioner → #29084
notifications and usage → #29085 build reasons → #29086 tables → #28750
permissions. The last four PRs replace the single data-drop migration
that used to live in #28750; each carries one concern and a focused
migration test.

**Why:** clients come off before the API they call. After this layer
nothing in the repo invokes the Tasks API outside coderd itself.

**What to scrutinize:** all but three files are whole-file deletions.
`triage-via-chat-api.yaml` gets a comment fix. `NavbarView.tsx` and its
stories carry two small repairs to the frontend layer below (unused
`user` prop, stale `TasksFilter` story wiring) so the stack lints clean
from this layer up; they rebase away if folded into #28743.

**Validation:** `go build ./...`, `go test ./cli -run TestCommandHelp`,
site tsc, pre-commit hooks (gen, fmt, lint).

**Size:** +4/-6,938 over 42 files; effectively pure deletion, so it
reads much faster than the line count suggests.

> Created by Xum (AI agent) on behalf of @ibetitsmike.
@ibetitsmike
ibetitsmike merged commit 9cd38b5 into main Sep 11, 2026
31 checks passed
@ibetitsmike
ibetitsmike deleted the mike/remove-tasks-api branch September 11, 2026 01:49
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release/breaking This label is applied to PRs to detect breaking changes as part of the release process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants