Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat!: remove has_ai_task and the task build reasons - #29085

Merged
ibetitsmike merged 2 commits into
mainfrom
mike/remove-tasks-build-reasons
Sep 11, 2026
Merged

feat!: remove has_ai_task and the task build reasons#29085
ibetitsmike merged 2 commits into
mainfrom
mike/remove-tasks-build-reasons

Conversation

@ibetitsmike

@ibetitsmike ibetitsmike commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Drops the has_ai_task column from template_versions and workspace_builds (with its index and view projections) and removes the three task build reasons (task_auto_pause, task_manual_pause, task_resume) from the build_reason enum. Existing rows are remapped before the enum swap: automatic pauses become autostop, manual pauses and resumes become initiator, and workspace_build_orchestrations.child_reason follows the same mapping. The query filters, provisionerdserver flag writes, and audit ignore entries for the column go with it.

Migration cost: recreating build_reason rewrites workspace_builds. TestMigration000593TaskBuildReasonRewriteTiming seeds 1,000 workspaces, 100,000 builds (30,000 with task reasons) and 5,000 orchestrations and asserts the migration stays under a two-minute bound; locally it takes about 0.7 to 1.0 s. The test is skipped under -short.

Breaking change: the down migration re-adds has_ai_task as false and restores the enum values; remapped reasons keep their new values.

Review changes: the migration test now asserts only the row remaps (schema and enum introspection removed per review); renumbered from 000592 to 000593.

Stack context: Coder Tasks removal stack (CODAGT-642): #28743 frontend → #28788 CLI → #28789 API → #28790 provisioner → #29084 notifications → #29085 build reasons#29086 tables → #28750 permissions. The last four PRs replace the single data-drop migration that used to live in #28750; each carries one concern and its own migration number.

Created by Xum (AI agent) on behalf of @ibetitsmike.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Docs preview

Check off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here.

@github-actions github-actions Bot added the release/breaking This label is applied to PRs to detect breaking changes as part of the release process label Sep 8, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-08T10:49:19.275025Z 88f8535 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 88f85359bb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread coderd/database/migrations/migrate_test.go Outdated
Comment thread coderd/database/migrations/migrate_test.go Outdated
Comment thread coderd/database/migrations/migrate_test.go Outdated
ibetitsmike added a commit that referenced this pull request Sep 10, 2026
Removes every in-repo Tasks client: the `coder exp tasks` CLI command
family, the tasks scaletest runner, and the task-driven triage
automation (`traiage.yaml`, `code-review.yaml`,
`classify-issue-severity.yml`, `scripts/traiage.sh`). Triage runs
through `triage-via-chat-api.yaml` and coder/create-agent-chat-action
instead.

**Stack context:** Coder Tasks removal stack (CODAGT-642): #28743
frontend → #28788 CLI → #28789 API → #28790 provisioner → #29084
notifications and usage → #29085 build reasons → #29086 tables → #28750
permissions. The last four PRs replace the single data-drop migration
that used to live in #28750; each carries one concern and a focused
migration test.

**Why:** clients come off before the API they call. After this layer
nothing in the repo invokes the Tasks API outside coderd itself.

**What to scrutinize:** all but three files are whole-file deletions.
`triage-via-chat-api.yaml` gets a comment fix. `NavbarView.tsx` and its
stories carry two small repairs to the frontend layer below (unused
`user` prop, stale `TasksFilter` story wiring) so the stack lints clean
from this layer up; they rebase away if folded into #28743.

**Validation:** `go build ./...`, `go test ./cli -run TestCommandHelp`,
site tsc, pre-commit hooks (gen, fmt, lint).

**Size:** +4/-6,938 over 42 files; effectively pure deletion, so it
reads much faster than the line count suggests.

> Created by Xum (AI agent) on behalf of @ibetitsmike.
@ibetitsmike
ibetitsmike force-pushed the mike/remove-tasks-build-reasons branch from 88f8535 to b531f20 Compare September 11, 2026 01:32
@ibetitsmike
ibetitsmike force-pushed the mike/remove-tasks-build-reasons branch from b531f20 to 103979f Compare September 11, 2026 01:49
pull Bot pushed a commit to Abaso007/coder that referenced this pull request Sep 11, 2026
Removes the Tasks API and task orchestration from coderd and codersdk:
the `/api/v2/tasks` handlers, task middleware and search filters, task
name generation, autobuild pause/resume logic, task notification
enqueues, telemetry, and the codersdk task types. Regenerates apidoc,
the API reference docs, and `typesGenerated.ts`.

**Breaking change:** the Tasks API is removed; requests to
`/api/v2/tasks` fail. Tasks was deprecated in v2.34.

**Stack context:** Coder Tasks removal stack (CODAGT-642): coder#28743
frontend → coder#28788 CLI → coder#28789 API → coder#28790 provisioner → coder#29084
notifications → coder#29085 build reasons → coder#29086 tables → coder#28750
permissions. The last four PRs replace the single data-drop migration
that used to live in coder#28750; each carries one concern and its own
migration number.

**Why:** with the UI (coder#28743) and CLI (coder#28788) gone, this deletes the
server surface. Database tables, RBAC, and notification templates stay
until the top of the stack so every layer builds and migrates
independently.

**What to scrutinize:**
- The `enable-ai-tasks` option is removed outright (review feedback):
configs still carrying `enableAITasks` fail to parse until the key is
deleted.
- provisionerdserver now writes `HasAITask: false` on template/build
flags; the column and these lines are dropped in coder#29085.
- `codersdk.ResourceTypeTask` stays so audit logs recorded before the
removal keep rendering.

**Validation:** `go build ./...`, `go vet ./...`, `go test
./codersdk/...`, site biome and tsc, CLI goldens regenerated, pre-commit
hooks.

**Size:** +242/-10,792 over 76 files; additions are regenerated
docs/goldens and test fixture updates.

> Created by Xum (AI agent) on behalf of @ibetitsmike.
ibetitsmike added a commit that referenced this pull request Sep 11, 2026
Removes AI task support from the provisioner protocol: the task-related
proto fields, terraform scanning for `coder_ai_task` resources, echo
provisioner support, the regenerated `.pb.go` and
`provisionerGenerated.ts`, and the terraform testdata that exercised
them. The provisioner API version change lives in
`provisionerd/proto/version.go`.

**Stack context:** Coder Tasks removal stack (CODAGT-642): #28743
frontend → #28788 CLI → #28789 API → #28790 provisioner → #29084
notifications and usage → #29085 build reasons → #29086 tables → #28750
permissions. The last four PRs replace the single data-drop migration
that used to live in #28750; each carries one concern and a focused
migration test.

**Why:** the proto fields lost their last consumer in #28789; this
deletes the producer side and the wire format.

**What to scrutinize:** the proto/version handling, and that
`coder_ai_task` resources in existing templates are now ignored rather
than errors (template imports simply no longer scan for them).

**Validation:** `go build ./...`, `go test ./provisionersdk/...
./provisionerd/...`, `go test ./provisioner/terraform -run
TestConvertResources`, provisioner list golden regenerated, site tsc,
pre-commit hooks.

**Size:** +580/-1,286 over 76 files; most files are mechanical testdata
and generated-code updates.

> Created by Xum (AI agent) on behalf of @ibetitsmike.
@ibetitsmike
ibetitsmike force-pushed the mike/remove-tasks-build-reasons branch from 103979f to d5de1aa Compare September 11, 2026 02:06
Base automatically changed from mike/remove-tasks-notifications-usage to main September 11, 2026 08:05
ibetitsmike added a commit that referenced this pull request Sep 11, 2026
Removes the six Coder Tasks notification templates (their preferences
and inbox history go with them via cascade) and the
`preference_task_notification_alert_dismissed` user setting with its two
queries. The `task` value of `ai_seat_usage_reason` stays: seats
consumed through tasks remain consumed, and remapping their reason would
misstate billing history.

**Breaking change:** migration 000592 deletes data. The down migration
restores the template definitions, not the deleted preferences or
notification history.

**Review changes:** dropped the `ai_seat_state` remap and enum swap and
the migration unit test (both per review); moved the migration from
000591 to 000592 because main took 000591.

**Stack context:** Coder Tasks removal stack (CODAGT-642): #28743
frontend → #28788 CLI → #28789 API → #28790 provisioner → **#29084
notifications** → #29085 build reasons → #29086 tables → #28750
permissions. The last four PRs replace the single data-drop migration
that used to live in #28750; each carries one concern and its own
migration number.

> Created by Xum (AI agent) on behalf of @ibetitsmike.
Drop has_ai_task from template versions and workspace builds, and remove the task build reasons.
Map automatic task pauses to autostop and manual pauses or resumes to initiator in workspace builds and build orchestrations.
Replacing the build_reason enum rewrites workspace_builds; the timing test exercises 100,000 builds.
The down migration restores the schema but cannot recover original reasons or flag values, so restored flags are false.
@ibetitsmike
ibetitsmike force-pushed the mike/remove-tasks-build-reasons branch from d5de1aa to 5fc53ee Compare September 11, 2026 08:05
@ibetitsmike
ibetitsmike merged commit 25af21b into main Sep 11, 2026
26 of 27 checks passed
@ibetitsmike
ibetitsmike deleted the mike/remove-tasks-build-reasons branch September 11, 2026 08:47
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release/breaking This label is applied to PRs to detect breaking changes as part of the release process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants