Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat!: drop the Coder Tasks tables and queries - #29086

Merged
ibetitsmike merged 2 commits into
mainfrom
mike/remove-tasks-tables
Sep 11, 2026
Merged

feat!: drop the Coder Tasks tables and queries#29086
ibetitsmike merged 2 commits into
mainfrom
mike/remove-tasks-tables

Conversation

@ibetitsmike

@ibetitsmike ibetitsmike commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Drops the tasks, task_workspace_apps and task_snapshots tables, the tasks_with_status view and the task_status enum, and recreates workspaces_expanded without the tasks join and task_id column. Deletes queries/tasks.sql and every wrapper, fixture and test that existed only for those queries (dbauthz, dbmock, dbmetrics, dbfake, dbgen, querier_test), plus the task_id projection in GetWorkspaceAgentAndWorkspaceByAuthToken.

Breaking change: migration 000594 deletes all task rows. The down migration restores the schema (tables, constraints, indexes, views), not the data.

Review changes: the schema-only migration test was removed per review (TestMigrate/UpDownUp still exercises the down path), the test file no longer reorders existing tests, and the migration moved from 000593 to 000594. The dump.sql reorder is pg_dump dependency ordering: tasks_with_status pulled its four workspace tables ahead of it, and without the view they return to alphabetical positions.

Stack context: Coder Tasks removal stack (CODAGT-642): #28743 frontend → #28788 CLI → #28789 API → #28790 provisioner → #29084 notifications → #29085 build reasons → #29086 tables#28750 permissions. The last four PRs replace the single data-drop migration that used to live in #28750; each carries one concern and its own migration number.

Created by Xum (AI agent) on behalf of @ibetitsmike.

Delivery record

Decision (2026-09-11 ~14:40Z): merge through the stack merge endpoint, squash, pinned to head f1d236a0c82f123b8a0d6878799c227ef9bd5776 (merge SHA appended below once landed).

Independent substantive reviews on this PR (3):

# Kind Reviewed commit Findings and disposition Source
1 Codex code review (bot), PR opened 24535f8410 No findings, no threads summary
2 Human review, spikecurtis (COMMENTED) 24535f8410 4 findings: dump.sql reorder question (answered: pg_dump dependency hoisting by tasks_with_status); two moved tests (undone, the test file is no longer touched); schema-only migration test (deleted). All resolved. review
3 Human review, spikecurtis (APPROVED) f1d236a0c8 (this head) Approval on the exact final head review

The four COMMENTED reviews by @ibetitsmike on f35688f40b are thread-reply wrappers and are not counted.

Pre-split history relevant to this diff: this layer's content lived in the monolithic #28750 until 2026-09-08, which received 10 completed Codex code reviews (2026-08-28 to 2026-09-01) and spikecurtis's CHANGES_REQUESTED review of 2026-09-04 that asked for the split. Counting those, the completed-review total relevant to this diff exceeds the six-review budget, so no further discretionary review or fresh final advisory was commissioned. The usable final recommendation for the final diff is review 3 above: the reviewer who authored every finding on this layer approved the exact head.

Exact-head checks: required SUCCESS in run 34580949353; rollup 15 success, 8 skipped, 1 failure. The failure is the non-required Analyze PR for Documentation Updates Needed job (103204101137), caused by the dormant doc-check-pr-29086 review workspace (CODAGT-1025), not a code finding; GitHub flags only required as required for this PR. Merge-ref freshness: refs/pull/29086/merge has the exact head as second parent and 25af21b5d5d (the #29085 squash) as first parent; main has since gained #29231, #28639 and #29218 (12 files, none overlapping this PR). The composed tree (git merge-tree of current main and this head) builds (go build ./...) and vets (go vet on coderd, coderd/database/..., coderd/wsrelated/...) cleanly. Layer diff parity with the previously pushed layer verified by numstat after both GitHub restacks. gh stack push did not run the local pre-push suite; CI is the validation evidence.

Deferred: the dormant doc-check workspace (CODAGT-1025) is outside this PR. Next in the stack, #28750, stays blocked: CHANGES_REQUESTED, its approval and CI predate the restack, and its review budget is exhausted.

Merged: b957e66ccc9b93d60150ef68f0e6bc4acac69d30 at 2026-09-11 14:24:33Z. Pre-merge recheck of the exact head passed (OPEN, APPROVED, MERGEABLE, 0 unresolved). #28750 was restacked onto main as 7f5b2f8a4a18 with layer parity (23 files).

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-08T10:46:38.839625Z 24535f8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Comment thread coderd/database/dump.sql
Comment thread coderd/database/migrations/migrate_test.go Outdated
Comment thread coderd/database/migrations/migrate_test.go
Comment thread coderd/database/migrations/migrate_test.go Outdated
ibetitsmike added a commit that referenced this pull request Sep 10, 2026
Removes every in-repo Tasks client: the `coder exp tasks` CLI command
family, the tasks scaletest runner, and the task-driven triage
automation (`traiage.yaml`, `code-review.yaml`,
`classify-issue-severity.yml`, `scripts/traiage.sh`). Triage runs
through `triage-via-chat-api.yaml` and coder/create-agent-chat-action
instead.

**Stack context:** Coder Tasks removal stack (CODAGT-642): #28743
frontend → #28788 CLI → #28789 API → #28790 provisioner → #29084
notifications and usage → #29085 build reasons → #29086 tables → #28750
permissions. The last four PRs replace the single data-drop migration
that used to live in #28750; each carries one concern and a focused
migration test.

**Why:** clients come off before the API they call. After this layer
nothing in the repo invokes the Tasks API outside coderd itself.

**What to scrutinize:** all but three files are whole-file deletions.
`triage-via-chat-api.yaml` gets a comment fix. `NavbarView.tsx` and its
stories carry two small repairs to the frontend layer below (unused
`user` prop, stale `TasksFilter` story wiring) so the stack lints clean
from this layer up; they rebase away if folded into #28743.

**Validation:** `go build ./...`, `go test ./cli -run TestCommandHelp`,
site tsc, pre-commit hooks (gen, fmt, lint).

**Size:** +4/-6,938 over 42 files; effectively pure deletion, so it
reads much faster than the line count suggests.

> Created by Xum (AI agent) on behalf of @ibetitsmike.
@ibetitsmike
ibetitsmike force-pushed the mike/remove-tasks-tables branch from 24535f8 to f35688f Compare September 11, 2026 01:32
@ibetitsmike
ibetitsmike force-pushed the mike/remove-tasks-tables branch from f35688f to 662bba9 Compare September 11, 2026 01:49
pull Bot pushed a commit to Abaso007/coder that referenced this pull request Sep 11, 2026
Removes the Tasks API and task orchestration from coderd and codersdk:
the `/api/v2/tasks` handlers, task middleware and search filters, task
name generation, autobuild pause/resume logic, task notification
enqueues, telemetry, and the codersdk task types. Regenerates apidoc,
the API reference docs, and `typesGenerated.ts`.

**Breaking change:** the Tasks API is removed; requests to
`/api/v2/tasks` fail. Tasks was deprecated in v2.34.

**Stack context:** Coder Tasks removal stack (CODAGT-642): coder#28743
frontend → coder#28788 CLI → coder#28789 API → coder#28790 provisioner → coder#29084
notifications → coder#29085 build reasons → coder#29086 tables → coder#28750
permissions. The last four PRs replace the single data-drop migration
that used to live in coder#28750; each carries one concern and its own
migration number.

**Why:** with the UI (coder#28743) and CLI (coder#28788) gone, this deletes the
server surface. Database tables, RBAC, and notification templates stay
until the top of the stack so every layer builds and migrates
independently.

**What to scrutinize:**
- The `enable-ai-tasks` option is removed outright (review feedback):
configs still carrying `enableAITasks` fail to parse until the key is
deleted.
- provisionerdserver now writes `HasAITask: false` on template/build
flags; the column and these lines are dropped in coder#29085.
- `codersdk.ResourceTypeTask` stays so audit logs recorded before the
removal keep rendering.

**Validation:** `go build ./...`, `go vet ./...`, `go test
./codersdk/...`, site biome and tsc, CLI goldens regenerated, pre-commit
hooks.

**Size:** +242/-10,792 over 76 files; additions are regenerated
docs/goldens and test fixture updates.

> Created by Xum (AI agent) on behalf of @ibetitsmike.
ibetitsmike added a commit that referenced this pull request Sep 11, 2026
Removes AI task support from the provisioner protocol: the task-related
proto fields, terraform scanning for `coder_ai_task` resources, echo
provisioner support, the regenerated `.pb.go` and
`provisionerGenerated.ts`, and the terraform testdata that exercised
them. The provisioner API version change lives in
`provisionerd/proto/version.go`.

**Stack context:** Coder Tasks removal stack (CODAGT-642): #28743
frontend → #28788 CLI → #28789 API → #28790 provisioner → #29084
notifications and usage → #29085 build reasons → #29086 tables → #28750
permissions. The last four PRs replace the single data-drop migration
that used to live in #28750; each carries one concern and a focused
migration test.

**Why:** the proto fields lost their last consumer in #28789; this
deletes the producer side and the wire format.

**What to scrutinize:** the proto/version handling, and that
`coder_ai_task` resources in existing templates are now ignored rather
than errors (template imports simply no longer scan for them).

**Validation:** `go build ./...`, `go test ./provisionersdk/...
./provisionerd/...`, `go test ./provisioner/terraform -run
TestConvertResources`, provisioner list golden regenerated, site tsc,
pre-commit hooks.

**Size:** +580/-1,286 over 76 files; most files are mechanical testdata
and generated-code updates.

> Created by Xum (AI agent) on behalf of @ibetitsmike.
@ibetitsmike
ibetitsmike force-pushed the mike/remove-tasks-tables branch from 662bba9 to acdf467 Compare September 11, 2026 02:06
ibetitsmike added a commit that referenced this pull request Sep 11, 2026
Removes the six Coder Tasks notification templates (their preferences
and inbox history go with them via cascade) and the
`preference_task_notification_alert_dismissed` user setting with its two
queries. The `task` value of `ai_seat_usage_reason` stays: seats
consumed through tasks remain consumed, and remapping their reason would
misstate billing history.

**Breaking change:** migration 000592 deletes data. The down migration
restores the template definitions, not the deleted preferences or
notification history.

**Review changes:** dropped the `ai_seat_state` remap and enum swap and
the migration unit test (both per review); moved the migration from
000591 to 000592 because main took 000591.

**Stack context:** Coder Tasks removal stack (CODAGT-642): #28743
frontend → #28788 CLI → #28789 API → #28790 provisioner → **#29084
notifications** → #29085 build reasons → #29086 tables → #28750
permissions. The last four PRs replace the single data-drop migration
that used to live in #28750; each carries one concern and its own
migration number.

> Created by Xum (AI agent) on behalf of @ibetitsmike.
@ibetitsmike
ibetitsmike force-pushed the mike/remove-tasks-tables branch from acdf467 to d24654e Compare September 11, 2026 08:06
Base automatically changed from mike/remove-tasks-build-reasons to main September 11, 2026 08:47
Drop the task tables, status view, and status enum, and remove their queries and Go helpers.
Rebuild the expanded workspace view without task joins while preserving workspace rows.
The down migration restores the schema but cannot restore deleted task data.
Add focused migration coverage and order the 590 through 593 tests without changing the earlier test bodies.
@ibetitsmike
ibetitsmike force-pushed the mike/remove-tasks-tables branch from d24654e to f1d236a Compare September 11, 2026 08:47
pull Bot pushed a commit to Klomgor/coder that referenced this pull request Sep 11, 2026
Drops the `has_ai_task` column from `template_versions` and
`workspace_builds` (with its index and view projections) and removes the
three task build reasons (`task_auto_pause`, `task_manual_pause`,
`task_resume`) from the `build_reason` enum. Existing rows are remapped
before the enum swap: automatic pauses become `autostop`, manual pauses
and resumes become `initiator`, and
`workspace_build_orchestrations.child_reason` follows the same mapping.
The query filters, provisionerdserver flag writes, and audit ignore
entries for the column go with it.

**Migration cost:** recreating `build_reason` rewrites
`workspace_builds`. `TestMigration000593TaskBuildReasonRewriteTiming`
seeds 1,000 workspaces, 100,000 builds (30,000 with task reasons) and
5,000 orchestrations and asserts the migration stays under a two-minute
bound; locally it takes about 0.7 to 1.0 s. The test is skipped under
`-short`.

**Breaking change:** the down migration re-adds `has_ai_task` as `false`
and restores the enum values; remapped reasons keep their new values.

**Review changes:** the migration test now asserts only the row remaps
(schema and enum introspection removed per review); renumbered from
000592 to 000593.

**Stack context:** Coder Tasks removal stack (CODAGT-642): coder#28743
frontend → coder#28788 CLI → coder#28789 API → coder#28790 provisioner → coder#29084
notifications → **coder#29085 build reasons** → coder#29086 tables → coder#28750
permissions. The last four PRs replace the single data-drop migration
that used to live in coder#28750; each carries one concern and its own
migration number.

> Created by Xum (AI agent) on behalf of @ibetitsmike.
@ibetitsmike
ibetitsmike merged commit b957e66 into main Sep 11, 2026
27 of 28 checks passed
@ibetitsmike
ibetitsmike deleted the mike/remove-tasks-tables branch September 11, 2026 14:24
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants