Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat!: remove the task notification templates - #29084

Merged
ibetitsmike merged 2 commits into
mainfrom
mike/remove-tasks-notifications-usage
Sep 11, 2026
Merged

feat!: remove the task notification templates#29084
ibetitsmike merged 2 commits into
mainfrom
mike/remove-tasks-notifications-usage

Conversation

@ibetitsmike

@ibetitsmike ibetitsmike commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Removes the six Coder Tasks notification templates (their preferences and inbox history go with them via cascade) and the preference_task_notification_alert_dismissed user setting with its two queries. The task value of ai_seat_usage_reason stays: seats consumed through tasks remain consumed, and remapping their reason would misstate billing history.

Breaking change: migration 000592 deletes data. The down migration restores the template definitions, not the deleted preferences or notification history.

Review changes: dropped the ai_seat_state remap and enum swap and the migration unit test (both per review); moved the migration from 000591 to 000592 because main took 000591.

Stack context: Coder Tasks removal stack (CODAGT-642): #28743 frontend → #28788 CLI → #28789 API → #28790 provisioner → #29084 notifications#29085 build reasons → #29086 tables → #28750 permissions. The last four PRs replace the single data-drop migration that used to live in #28750; each carries one concern and its own migration number.

Created by Xum (AI agent) on behalf of @ibetitsmike.

Delivery record

Merged as f8097762296 at 2026-09-11 08:05:53Z (squash via the stack merge endpoint, pinned to head c0f79e0160dec266b66d694bf3272b9710905e49).

Independent substantive reviews (3) plus final advisory (1):

# Kind Reviewed commit Findings and disposition Source
1 Codex code review (bot) 96846269be No findings summary
2 Human review, spikecurtis (COMMENTED) 96846269be 2 findings, both applied: keep the task AI seat usage reason (remap and enum swap removed); drop the raw-SQL migration unit test. Threads resolved. review, r3957823076, r3957881760
3 Human review, johnstcn (APPROVED) c0f79e0160 (merged head) "Approving with the reduced scope." review
4 Final advisory (Xum advisor, gpt-5.5-pro, local, 2026-09-11 ~08:00Z) c0f79e0160 Recommended merge, conditional on a merge-ref freshness check. Check result: refs/pull/29084/merge had second parent equal to the head and first parent two commits behind main (df1a9108158 vs 2e0db07498f); the drift touched only .github/actions/test-go-pg/action.yaml and .github/workflows/doc-check.yaml, no overlap with this PR's files, so it was judged immaterial and the merge proceeded. local advisor report, not on GitHub

The two COMMENTED reviews by @ibetitsmike on 47adf28db9 are thread-reply wrappers, not reviews, and are not counted.

Exact-head CI: ci run 34553318613 on c0f79e0160 completed success; status rollup SUCCESS (21 success, 6 skipped); required job SUCCESS. Local: make gen no diff, go build ./..., migration package tests (Once, Twice, Parallel, UpDownUp, fixtures), TestUpsertAISeats, pre-commit hook on the fix commit. gh stack push did not run the local pre-push suite; CI is the validation evidence.

Why review stopped here: all findings applied, exact-head human approval, zero unresolved threads, green required CI; no further review was commissioned.

Downstream state at merge time: GitHub restacked #29085 (5fc53ee9538), #29086 (d24654ebc3), #28750 (2c4c613d37) with per-layer diff parity verified. #29085 is next on main but blocked: its approval is on 88f85359bb (pre-fix, pre-restack) and CI on the new head was unfinished. Deferred, not code findings: the AI Documentation Check jobs on #29085 and #29086 fail because their doc-check-pr-* review workspaces are dormant (CODAGT-1025).

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Docs preview

Check off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here.

@github-actions github-actions Bot added the release/breaking This label is applied to PRs to detect breaking changes as part of the release process label Sep 8, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-08T10:45:44.271166Z 9684626 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Comment thread coderd/database/migrations/000591_remove_task_notifications_and_usage.up.sql Outdated
Comment thread coderd/database/migrations/migrate_test.go Outdated
ibetitsmike added a commit that referenced this pull request Sep 10, 2026
Removes every in-repo Tasks client: the `coder exp tasks` CLI command
family, the tasks scaletest runner, and the task-driven triage
automation (`traiage.yaml`, `code-review.yaml`,
`classify-issue-severity.yml`, `scripts/traiage.sh`). Triage runs
through `triage-via-chat-api.yaml` and coder/create-agent-chat-action
instead.

**Stack context:** Coder Tasks removal stack (CODAGT-642): #28743
frontend → #28788 CLI → #28789 API → #28790 provisioner → #29084
notifications and usage → #29085 build reasons → #29086 tables → #28750
permissions. The last four PRs replace the single data-drop migration
that used to live in #28750; each carries one concern and a focused
migration test.

**Why:** clients come off before the API they call. After this layer
nothing in the repo invokes the Tasks API outside coderd itself.

**What to scrutinize:** all but three files are whole-file deletions.
`triage-via-chat-api.yaml` gets a comment fix. `NavbarView.tsx` and its
stories carry two small repairs to the frontend layer below (unused
`user` prop, stale `TasksFilter` story wiring) so the stack lints clean
from this layer up; they rebase away if folded into #28743.

**Validation:** `go build ./...`, `go test ./cli -run TestCommandHelp`,
site tsc, pre-commit hooks (gen, fmt, lint).

**Size:** +4/-6,938 over 42 files; effectively pure deletion, so it
reads much faster than the line count suggests.

> Created by Xum (AI agent) on behalf of @ibetitsmike.
@ibetitsmike
ibetitsmike force-pushed the mike/remove-tasks-notifications-usage branch from 9684626 to 47adf28 Compare September 11, 2026 01:32
@ibetitsmike ibetitsmike changed the title feat!: remove the task notification templates and AI seat usage reason feat!: remove the task notification templates Sep 11, 2026
@ibetitsmike
ibetitsmike force-pushed the mike/remove-tasks-notifications-usage branch from 47adf28 to 649ce72 Compare September 11, 2026 01:49
pull Bot pushed a commit to Abaso007/coder that referenced this pull request Sep 11, 2026
Removes the Tasks API and task orchestration from coderd and codersdk:
the `/api/v2/tasks` handlers, task middleware and search filters, task
name generation, autobuild pause/resume logic, task notification
enqueues, telemetry, and the codersdk task types. Regenerates apidoc,
the API reference docs, and `typesGenerated.ts`.

**Breaking change:** the Tasks API is removed; requests to
`/api/v2/tasks` fail. Tasks was deprecated in v2.34.

**Stack context:** Coder Tasks removal stack (CODAGT-642): coder#28743
frontend → coder#28788 CLI → coder#28789 API → coder#28790 provisioner → coder#29084
notifications → coder#29085 build reasons → coder#29086 tables → coder#28750
permissions. The last four PRs replace the single data-drop migration
that used to live in coder#28750; each carries one concern and its own
migration number.

**Why:** with the UI (coder#28743) and CLI (coder#28788) gone, this deletes the
server surface. Database tables, RBAC, and notification templates stay
until the top of the stack so every layer builds and migrates
independently.

**What to scrutinize:**
- The `enable-ai-tasks` option is removed outright (review feedback):
configs still carrying `enableAITasks` fail to parse until the key is
deleted.
- provisionerdserver now writes `HasAITask: false` on template/build
flags; the column and these lines are dropped in coder#29085.
- `codersdk.ResourceTypeTask` stays so audit logs recorded before the
removal keep rendering.

**Validation:** `go build ./...`, `go vet ./...`, `go test
./codersdk/...`, site biome and tsc, CLI goldens regenerated, pre-commit
hooks.

**Size:** +242/-10,792 over 76 files; additions are regenerated
docs/goldens and test fixture updates.

> Created by Xum (AI agent) on behalf of @ibetitsmike.
Base automatically changed from mike/remove-tasks-provisioner to main September 11, 2026 02:06
ibetitsmike added a commit that referenced this pull request Sep 11, 2026
Removes AI task support from the provisioner protocol: the task-related
proto fields, terraform scanning for `coder_ai_task` resources, echo
provisioner support, the regenerated `.pb.go` and
`provisionerGenerated.ts`, and the terraform testdata that exercised
them. The provisioner API version change lives in
`provisionerd/proto/version.go`.

**Stack context:** Coder Tasks removal stack (CODAGT-642): #28743
frontend → #28788 CLI → #28789 API → #28790 provisioner → #29084
notifications and usage → #29085 build reasons → #29086 tables → #28750
permissions. The last four PRs replace the single data-drop migration
that used to live in #28750; each carries one concern and a focused
migration test.

**Why:** the proto fields lost their last consumer in #28789; this
deletes the producer side and the wire format.

**What to scrutinize:** the proto/version handling, and that
`coder_ai_task` resources in existing templates are now ignored rather
than errors (template imports simply no longer scan for them).

**Validation:** `go build ./...`, `go test ./provisionersdk/...
./provisionerd/...`, `go test ./provisioner/terraform -run
TestConvertResources`, provisioner list golden regenerated, site tsc,
pre-commit hooks.

**Size:** +580/-1,286 over 76 files; most files are mechanical testdata
and generated-code updates.

> Created by Xum (AI agent) on behalf of @ibetitsmike.
Remove the six task notification templates and the task-alert dismissal setting.
Remap task AI seat events to aibridge while preserving consumed seats, then remove task from the usage reason enum.
The down migration restores template definitions and the enum value.
Deleted preferences and notification history cannot be reconstructed, and remapped events cannot recover their original reason.
@ibetitsmike
ibetitsmike force-pushed the mike/remove-tasks-notifications-usage branch from 649ce72 to c0f79e0 Compare September 11, 2026 02:06

@johnstcn johnstcn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the reduced scope.

@ibetitsmike
ibetitsmike merged commit f809776 into main Sep 11, 2026
27 checks passed
@ibetitsmike
ibetitsmike deleted the mike/remove-tasks-notifications-usage branch September 11, 2026 08:05
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release/breaking This label is applied to PRs to detect breaking changes as part of the release process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants