-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
[MNT]: Remove 3.7-deprecated API #26865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Good first issue - notes for new contributorsThis issue is suited to new contributors because it does not require understanding of the Matplotlib internals. To get started, please see our contributing guide. We do not assign issues. Check the Development section in the sidebar for linked pull requests (PRs). If there are none, feel free to start working on it. If there is an open PR, please collaborate on the work by reviewing it rather than duplicating it in a competing PR. If something is unclear, please reach out on any of our communication channels. |
Note that we expect to have PRs for smaller chunks here, so even if there are open ones, there might still be some chance to work on this issue; see the checklist above. |
Change in progress lib/matplotlib/contour.py # |
Hi, Can anyone please tell me how I should start with this issue...? |
Hi Sir, For the first time, I am doing open source contribution. I want to share with you my work so that I can know whether I have the right job or not. Will you please guide me with the steps to create a pull request and send you my work for reviewing? |
It would be very helpful if you also guide me with what I have done wrong and how I can correct it. |
Please see our contributing guide |
#26865 removing deprecations to patches.py and axislines.py
Not quite finished. |
Hi, |
@Yen-yen I think we have open PRs for all of these already. This may not be a good issue to start on right now. |
Got it. Thank you so much. I will look into another one! |
I believe this is now complete. |
Not sure why I missed listing these in matplotlib#26865.
Not sure why I missed listing these in matplotlib#26865.
Not sure why I missed listing these in matplotlib#26865.
Summary
As old and unused API (classes, methods, functions) are found, they are marked deprecated with removal intended in a later release. These API are decorated or otherwise wrapped with the deprecation functions in
_api
(i.e.,deprecated
,warn_deprecated
,rename_parameter
,delete_parameter
,make_keyword_only
,deprecate_method_override
, ordeprecate_privatize_attribute
).Now that 3.8 is out and
main
targets 3.9, we can start the process of removing API that were deprecated in 3.7 (i.e., those withsince="3.7"
and withoutpending=True
).Proposed fix
Each part of the deprecated API should be removed:
a. Items marked with
_api.warn_deprecated
,@_api.deprecated
or@_api.deprecate_privatize_attribute
are to be removed on expiry, i.e., any of the marked lines below:@_api.rename_parameter
should have this decorator removed, and no other changes will be necessary (the parameter rename should already have been made when the decorator was added.), i.e.,-@_api.rename_parameter("3.7", "old_name", "new_name") def foo(new_name): ...
@_api.make_keyword_only
should have the decorator removed, and the parameter named there should be made keyword-only (by adding a*
before that point).@_api.delete_parameter
will need to have the parameter deleted and all following parameters made keyword-only.*.pyi
file.ci/mypy-stubtest-allowlist.txt
, if there are any.Additionally, the removal should be documented by placing a snippet in
doc/api/next_api_changes/removals/
(see00001-ABC.rst
in that directory for a template). For writing these snippets, you may wish to copy the original deprecation notice, modifying it slightly to state that the API has been removed instead. Please ensure that any references to deleted API include a full path (as there may be many methods with the same name, but on different classes.)NOTE: After removing the deprecated API, there may be some additional fallout that should be corrected. For example,
This is some text referencing ``matplotlib.submodule.RemovedClass``.
See also our documentation on removing deprecated API and #26853 for an example removing several types of deprecated API.
Task list
A quick search shows the following sets of possible parts to remove (for GHC OSD, please use Slack and/or Zoom to make sure someone else hasn't started working on the same set):
lib/matplotlib/animation.py
- 2 deprecations Deprecated code removed in animation.py #26872lib/matplotlib/axis.py
- 1 deprecation Removed the deprecated code fromaxis.py
#26871lib/matplotlib/backends/*.py
- 3 deprecations andsrc/_backend_agg_wrapper.cpp
- 2 deprecations Remove backend 3.7-deprecated API #26962lib/matplotlib/cm.py
- 2 deprecations (Note: the documentation for this removal may be a bit tricky to write.) Removal of deprecated API cm #26965lib/matplotlib/contour.py
- 5 deprecations Removal of deprecations for Contour #26907lib/matplotlib/collections.py
- 2 deprecations Cleaned up the span_where class method from Polycollections. #26874lib/matplotlib/_fontconfig_patterns.py
- 1 deprecation Remove deprecated code from _fontconfig_patterns #26884lib/matplotlib/gridspec.py
- 1 deprecation Removed deprecated code from gridspec.py #26885 (!)lib/matplotlib/lines.py
- 2 deprecations Fixed deprecated APIs in lines.py #26902lib/matplotlib/offsetbox.py
- 3 deprecations Removed the deprecated code from offsetbox.py #26910Updated offsetbox.py #26880lib/matplotlib/patches.py
- 1 deprecation Removing deprecated api from patches #26890 issue: 26871 - Remove SimplePath class from patches.py #26876 #26865 removing deprecations to axislines.py #26900 (!)lib/matplotlib/quiver.py
- 2 deprecations 26865 Removed deprecations from quiver.py #26918lib/matplotlib/tri/*.py
- 8 deprecations deprecated api tri #26909lib/mpl_toolkits/axisartist/axislines.py
- 2 deprecations #26865 removing deprecations to axislines.py #26900There may be some other items I've missed here, but note that we do not want to remove any with
pending=True
, orsince="3.8"
or higher.The text was updated successfully, but these errors were encountered: