Fix issue 7712 #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpl3 wx supports any wxpython that does support Py3 (i.e., wwpython>=4), so we can drop the version checks.
…plotlib into fixed-issue-8576
…mple code for markevery
…mple code for markevery
…b into fixed-issue-8576
... so we can just do an equality check. (Likewise, for Windows, sys.platform is *always* "win32".) (https://docs.python.org/3/library/sys.html#sys.platform)
Corrected mistitling on the annotation tutorial page
Avoid narrowing conversion in image_wrapper on 32-bit.
Remove some wx version checks.
…pep257 Minor cleanup: PEP8, PEP257
sys.platform is normalized to "linux" on Py3.
…th-setting FIX: reorder linewidth setting before linestyle
Update copyright date to 2018
…se-alias FIX: re-instate verbose alias
FIX: ffmpeg logging level
Fix image fmt detection for Path input.
FIX/TST OS X builds
make centre_baseline legal for Text.set_verticalalignment
Implemented support for 'markevery' in prop_cycle
API: check locator and formatter args when passed
… tests cases to fit, added next_api_changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR addresses the overlapping date intervals that can still be found. I noticed PR #8251 just changed the hard coded data table, yet it still resulted in overlaps when dealing with minutely changes. Without changing the data table, I used rcParam's figsize and fontsize to make a conservative estimation of characters that can fit per inch.
Although the solution requires more information I believe this makes less dependent on future changes to the table. I have modified all image tests required, added coverage, and added to next_api_changes to inform users that image outputs have changed. Thanks in advance for any feedback on this PR.
PR Checklist